This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Update Tools/world/world
Type: Stage:
Components: Library (Lib) Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: doerwalter Nosy List: doerwalter, loewis
Priority: normal Keywords: patch

Created on 2002-06-06 18:47 by doerwalter, last changed 2022-04-10 16:05 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
diff.txt doerwalter, 2002-06-06 18:47
diff2.txt doerwalter, 2002-06-07 10:41
Messages (5)
msg40236 - (view) Author: Walter Dörwald (doerwalter) * (Python committer) Date: 2002-06-06 18:47
This patch replaces string module functions with string
methods in the Tools/world/world scripts.

It also updates two outdated URLs and the countrycodes
dictionary.
msg40237 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-06-07 06:54
Logged In: YES 
user_id=21627

The

 elif string.find(w, '-'):

chunk looks wrong: find returns -1 on failure, which is also
True (this bug was in the original code already).
msg40238 - (view) Author: Walter Dörwald (doerwalter) * (Python committer) Date: 2002-06-07 10:41
Logged In: YES 
user_id=89016

OK, I changed this in diff2.txt and also replaced <> with !=
two times.

I guess the part
try:
   fp = open(file)
except IOError, (err, msg):
   print msg, ':', file

is wrong too, because it goes on to use fp even after an error.
msg40239 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-06-07 14:40
Logged In: YES 
user_id=21627

The patch looks fine, please apply.
msg40240 - (view) Author: Walter Dörwald (doerwalter) * (Python committer) Date: 2002-06-07 14:48
Logged In: YES 
user_id=89016

Checked in as Tools/world/world 3.14.
History
Date User Action Args
2022-04-10 16:05:23adminsetgithub: 36705
2002-06-06 18:47:18doerwaltercreate