Logged In: YES
user_id=21627
The patch looks good, but I'd like you to improve
standards conformance of the telnet options. I.e. you
should document which version of arpa/telnet.h you've used
as a basis. In addition, you should consider adding telnet
options not listed in this file.
In the past, they were all collected in an RFC; the last
one who did this was RFC 2400. Now, IANA has a separate
table, http://www.iana.org/assignments/telnet-options.
I recommend that you add all those constants in addition
to their telnet.h names, e.g. TOPT_XDL, TOPT_3270,
TOPT_X_3.
As for the callback design: Another option would be to
allow subclassing the telnet class, e.g. a self.do_option
method. I'm not sure what it best here, your current
approach seems fine.
Please also try to draft a patch for
Doc/lib/libtelnetlib.tex. At a minimum, this should
document the callback and the existence of the constants;
if possible, it should give an example of option
negotiation.
|