[XML-SIG] [Q] xml.utils.boolean C API
Uche Ogbuji
uche.ogbuji@fourthought.com
Wed, 11 Sep 2002 13:38:34 -0600
> On Tue, 2002-09-10 at 13:10, Fred L. Drake, Jr. wrote:
> >
> > The C API to the boolean module, expressed in extensions/boolean.h,
> > does not appear to be used. It certainly can't be used as-is when the
> > module is built to be dynamically loaded. The boolean_new() function
> > it references is not present in boolean.c at all.
>
> It confused me as well. But it is actually used. In the init of the
> module, we expose a ref to false and true. The are the only two
> instances of boolean ever created.
>
> >
> > Is there any reason this header is used, or can the needed information
> > simply be merged into the implementation?
> >
> > The implementation also uses DL_EXPORT for a few things that should be
> > static, and almost nobody outside the Python core needs to use the
> > tp_print slot; the use made by this code is certainly avoidable in
> > efficient ways.
> >
> > Uche, Mike, et al.: any objection to a little cleanup here?
>
> Not at all. Though, you might need to here from Jeremy before you do
> much as he wrote it.
No. I wrote it. There is for sure nothing there that Fred can't handle
easily.
--
Uche Ogbuji Fourthought, Inc.
http://uche.ogbuji.net http://4Suite.org http://fourthought.com
Apache 2.0 API - http://www-106.ibm.com/developerworks/linux/library/l-apache/
Basic XML and RDF techniques for knowledge management, Part 7 - http://www-106.ibm.com/developerworks/xml/library/x-think12.html
Keeping pace with James Clark - http://www-106.ibm.com/developerworks/xml/library/x-jclark.html