[XML-SIG] Re: [XML-checkins]CVS: xml/xml/dom expatbuilder.py,1.5,1.6

[Martin v. Loewis]

"Fred L. Drake" <fdrake@users.sourceforge.net> writes:

> ***************
> *** 273,277 ****
>                   None, name, doctype)
>               if self._standalone >= 0:
> !                 doc.standalone = self._standalone
>               doc.encoding = self._encoding
>               doc.version = self._version
> --- 275,279 ----
>                   None, name, doctype)
>               if self._standalone >= 0:
> !                 doc.standalone = self._standalone and True or False
>               doc.encoding = self._encoding
>               doc.version = self._version

I personally find this change quite ugly. Wouldn't it be much better
if pyexpat would use True and False in the standalone flag?

I believe a simple change like

             ("(O&O&O)",
              STRING_CONV_FUNC,version, STRING_CONV_FUNC,encoding,
              standalone ? Py_True:Py_False))

would do.

Also, what is the purpose of initializing _standalone to -1?

Regards,
Martin