From metatracker at psf.upfronthosting.co.za Fri Jun 1 00:11:43 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Fri, 01 Jun 2018 04:11:43 +0000 Subject: [Tracker-discuss] [issue644] 'Random Issue' Button isn't working In-Reply-To: <1508803113.44.0.213398074469.issue644@psf.upfronthosting.co.za> Message-ID: <1527826303.48.0.682650639539.issue644@psf.upfronthosting.co.za> Berker Peksag added the comment: Thank you for taking a look at this again, John. I will incorporate your suggestions and prepare a patch this weekend. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Jun 2 01:53:42 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Sat, 02 Jun 2018 05:53:42 +0000 Subject: [Tracker-discuss] [issue644] 'Random Issue' Button isn't working In-Reply-To: <1508803113.44.0.213398074469.issue644@psf.upfronthosting.co.za> Message-ID: <1527918822.93.0.81473610881.issue644@psf.upfronthosting.co.za> Berker Peksag added the comment: I've just committed John's suggested approach in https://hg.python.org/tracker/python-dev/rev/9e1d65b4927c but it needs to be deployed by bugs.p.o maintainers. Thank you, again! > I'll keep poking at it to try to figure out why random seems to be > losing state, but I am stumped here. Did you get a chance to look at what was wrong on Roundup's side? ---------- status: chatting -> testing _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Jun 2 03:50:16 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Sat, 02 Jun 2018 07:50:16 +0000 Subject: [Tracker-discuss] [issue644] 'Random Issue' Button isn't working In-Reply-To: <1508803113.44.0.213398074469.issue644@psf.upfronthosting.co.za> Message-ID: <1527925816.52.0.592728768989.issue644@psf.upfronthosting.co.za> Berker Peksag added the comment: Ezio has just deployed 9e1d65b4927c and I've confirmed that it works on bugs.python.org. Closing as 'resolved'. Thanks for the report, Cheryl. ---------- status: testing -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sun Jun 3 20:03:42 2018 From: metatracker at psf.upfronthosting.co.za (John Rouillard) Date: Mon, 04 Jun 2018 00:03:42 +0000 Subject: [Tracker-discuss] [issue644] 'Random Issue' Button isn't working In-Reply-To: <1527918822.93.0.81473610881.issue644@psf.upfronthosting.co.za> Message-ID: <20180604000331.5787B4C0672@itserver6.localdomain> John Rouillard added the comment: Hi Berker: In message <1527918822.93.0.81473610881.issue644 at psf.upfronthosting.co.za>, Berker Peksag writes: >Berker Peksag added the comment: > >I've just committed John's suggested approach in > https://hg.python.org/tracker/python-dev/rev/9e1d65b4927c but it >needs to be deployed by bugs.p.o maintainers. Thank you, again! > >> I'll keep poking at it to try to figure out why random seems to be >> losing state, but I am stumped here. > >Did you get a chance to look at what was wrong on Roundup's side? I spent about 4 hours on it but didn't come up with any cause. I couldn't reproduce in a test case. Every theory I came up with didn't predict the symptoms I was seeing. The major change in the newest release is that roundup's core now uses SystemRandom/os.urandom when available. This is used for various one time keys/nonces to prevent CSRF and other nastyness. The Random Issue extension uses the pseudo-random generator since calling seed() has an effect. When using SystemRandom/os.urandom seed() is a no-op. My only guess is that somehow those two random's are interacting badly with the result that the pseudorandom generator is not being properly initialized/reinitialized/state preserved. As a result on every random call the same number is returned. Proving that theory would require looking at the C code and seeing what the relationship is between these two implementations. I was going down that path and just ran out of steam. (Frankly I think this theory is junk but it's the only one I have that explains the symptoms.) The solution I proposed does have the slight risk that the return value of the pseudo random generator elsewhere in the roundup code could be predicted. By hitting the random article the attacker can seed the pseudo-random generator with one of a few known values. As a result values returned by other uses of random may be predictable. This shouldn't affect the core roundup use on any system that has urandom.SystemRandom so there is no security issue AFAICT. Hopefully this email will open and reresolve the issue. If it leaves it open, sorry about that. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sun Jun 3 20:21:52 2018 From: metatracker at psf.upfronthosting.co.za (John Rouillard) Date: Mon, 04 Jun 2018 00:21:52 +0000 Subject: [Tracker-discuss] [issue557] "broken form: multiple @action values submitted" on show issue In-Reply-To: <1416301192.73.0.0447576491579.issue557@psf.upfronthosting.co.za> Message-ID: <1528071712.88.0.592728768989.issue557@psf.upfronthosting.co.za> John Rouillard added the comment: I believe this was fixed during the roundup tracker upgrade last fall. I can't reproduce using the directions provided. Thanks for reporting the issue. -- rouilj ---------- nosy: +rouilj status: unread -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon Jun 4 07:22:50 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Mon, 04 Jun 2018 11:22:50 +0000 Subject: [Tracker-discuss] [issue615] Set stage to 'patch review' when a PR is added In-Reply-To: <1487512232.69.0.355373365979.issue615@psf.upfronthosting.co.za> Message-ID: <1528111370.57.0.592728768989.issue615@psf.upfronthosting.co.za> Berker Peksag added the comment: This has already been deployed. Closing as 'resolved'. ---------- status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon Jun 4 09:31:46 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Mon, 04 Jun 2018 13:31:46 +0000 Subject: [Tracker-discuss] [issue593] Small improvements to issue.item.html In-Reply-To: <1465451224.3.0.969789688095.issue593@psf.upfronthosting.co.za> Message-ID: <1528119106.97.0.592728768989.issue593@psf.upfronthosting.co.za> Berker Peksag added the comment: > 1. Add a 't' mark to mark our triagers Ezio's suggestion in msg3197 is much better than mine. I will open a new issue when I have a patch. > 2. List only core developers in the 'assigned to' field It seems too late to change this one. Other core developers already using it with non-core developers. I dropped this idea. > 3. Fix style of the 'Submit Changes' button This seems like the most uncontroversial part of the patch. Applied in https://hg.python.org/tracker/python-dev/rev/0f6adc6f3e55 Here's a screenshot: https://www.dropbox.com/s/y9v00j88240e5p1/bpo.png?dl=0 Closing this one as 'resolved'. ---------- status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon Jun 4 10:50:01 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Mon, 04 Jun 2018 14:50:01 +0000 Subject: [Tracker-discuss] [issue599] Strip content when replying to an issue via email In-Reply-To: <1465804507.36.0.926205719395.issue599@psf.upfronthosting.co.za> Message-ID: <1528123801.69.0.592728768989.issue599@psf.upfronthosting.co.za> Berker Peksag added the comment: We can use https://github.com/zapier/email-reply-parser to solve this issue. ---------- nosy: +ezio.melotti status: unread -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon Jun 4 19:16:29 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Mon, 04 Jun 2018 23:16:29 +0000 Subject: [Tracker-discuss] [issue654] Add triager icon Message-ID: <1528154189.0.0.592728768989.issue654@psf.upfronthosting.co.za> New submission from Berker Peksag : Here's patch that implements Ezio's suggestion in msg3197. ---------- files: add_triager_icon.diff messages: 3461 nosy: berker.peksag, ezio.melotti, r.david.murray priority: feature status: unread title: Add triager icon _______________________________________________________ PSF Meta Tracker _______________________________________________________ -------------- next part -------------- diff --git a/extensions/pydevutils.py b/extensions/pydevutils.py --- a/extensions/pydevutils.py +++ b/extensions/pydevutils.py @@ -16,16 +16,20 @@ def is_history_ok(request): # currently not used return True def is_coordinator(request): user = request.client.userid db = request.client.db return 'Coordinator' in db.user.get(user, 'roles') +def is_triager(request, userid): + db = request.client.db + return 'Developer' in db.user.get(userid, 'roles') + def clean_ok_message(ok_message): """Remove nosy_count and message_count from the ok_message.""" pattern = '\s*(?:nosy|message)_count,|,\s*(?:nosy|message)_count(?= edited)' return ''.join(re.sub(pattern, '', line) for line in ok_message) + '
' def issueid_and_action_from_class(cls): """ @@ -86,13 +90,14 @@ class RandomIssueAction(Action): random.seed() url = self.db.config.TRACKER_WEB + 'issue' + random.choice(issue_ids) raise Redirect(url) def init(instance): instance.registerUtil('is_history_ok', is_history_ok) instance.registerUtil('is_coordinator', is_coordinator) + instance.registerUtil('is_triager', is_triager) instance.registerUtil('clean_ok_message', clean_ok_message) instance.registerUtil('issueid_and_action_from_class', issueid_and_action_from_class) instance.registerUtil('clas_as_json', clas_as_json) instance.registerAction('random', RandomIssueAction) diff --git a/html/issue.item.html b/html/issue.item.html --- a/html/issue.item.html +++ b/html/issue.item.html @@ -358,16 +358,19 @@ replace="author_name" /> () * (Python committer) + Triager Date:

diff --git a/html/triager.png b/html/triager.png new file mode 100644 index 0000000000000000000000000000000000000000..0bcdca6e48e75017037e837b0d6fba8662769fd6 GIT binary patch literal 477 zc$@*<0V4j1P)Px#0%A)?L;(MXkIcUS000SaNLh0L01FcU01FcV0GgZ_00007bV*G`2jT_<7CIt- z7&3tX00Ci1L_t(2&sC8zOB`VkhM(PAxz8gu2ZEPiW0 at k5CZ)wex)fRn<_BmKB&{|U zCLw|RfdmUvNK#mcl{OM9kqd_=ogkXn92N)SNp^0(nQv3<-Wg}Qd7gKsn2568Y-iI} z_he)u>l-Tw1`rPfn^~(X9wRuGn8X$Hp`a|I7>WmIP%GvMyj#^NAIYX9Qt^z;LXD;?PuzHnhaDi&ui<6%P~p4|^b&{`YU6Th9$8)M+Gx z{OxZ0>#u8+ob2H7gV%;(Fq&kdPPy6ovUxV|W`ncgF++tY*58V8ymP)#dwCxl=?}8F z|H+H;^V+>Akd at GY(>;0-js}nDU$zY8YAeqR1^%2Y9&r&7Q>8|J(Y;G6&zjtlazi&E zkdlIz;EL5xX$d(Ux+psQMQ={pnHb99Y5OgnzodBbXdvJiXM! Message-ID: <1528154269.13.0.592728768989.issue593@psf.upfronthosting.co.za> Berker Peksag added the comment: > Ezio's suggestion in msg3197 is much better than mine. I will open a new issue when I have a patch. I've opened issue654. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed Jun 6 10:00:29 2018 From: metatracker at psf.upfronthosting.co.za (Nick Coghlan) Date: Wed, 06 Jun 2018 14:00:29 +0000 Subject: [Tracker-discuss] [issue644] 'Random Issue' Button isn't working In-Reply-To: <1508803113.44.0.213398074469.issue644@psf.upfronthosting.co.za> Message-ID: <1528293629.54.0.592728768989.issue644@psf.upfronthosting.co.za> Nick Coghlan added the comment: Note that a potential variation of the new approach is that rather than reseeding the default instance, the Action could create and seed a new random.Random() instance every time. It would be slightly slower, but I don't think this gets hit often enough for that to be a major concern. ---------- nosy: +ncoghlan _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed Jun 6 10:11:36 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Wed, 06 Jun 2018 14:11:36 +0000 Subject: [Tracker-discuss] [issue644] 'Random Issue' Button isn't working In-Reply-To: <1508803113.44.0.213398074469.issue644@psf.upfronthosting.co.za> Message-ID: <1528294296.41.0.592728768989.issue644@psf.upfronthosting.co.za> Berker Peksag added the comment: Thank you again for taking a look at this, John. I didn't think about using random.Random() to be honest, thank you Nick! Is there a reason why random.Random() is undocumented in the random module documentation? _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed Jun 6 10:23:19 2018 From: metatracker at psf.upfronthosting.co.za (Nick Coghlan) Date: Wed, 06 Jun 2018 14:23:19 +0000 Subject: [Tracker-discuss] [issue644] 'Random Issue' Button isn't working In-Reply-To: <1508803113.44.0.213398074469.issue644@psf.upfronthosting.co.za> Message-ID: <1528294999.47.0.592728768989.issue644@psf.upfronthosting.co.za> Nick Coghlan added the comment: Huh, I'd never noticed how easy that documentation is to miss: it's in the preamble text at the start of https://docs.python.org/3/library/random.html I filed https://bugs.python.org/issue33783 to suggest giving it some proper Sphinx markup. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed Jun 6 10:28:13 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Wed, 06 Jun 2018 14:28:13 +0000 Subject: [Tracker-discuss] [issue644] 'Random Issue' Button isn't working In-Reply-To: <1508803113.44.0.213398074469.issue644@psf.upfronthosting.co.za> Message-ID: <1528295293.76.0.592728768989.issue644@psf.upfronthosting.co.za> Berker Peksag added the comment: Ah, I've definitely missed the "You can instantiate your own instances of Random to get generators that don?t share state." part. Thanks! _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed Jun 6 10:42:28 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Wed, 06 Jun 2018 14:42:28 +0000 Subject: [Tracker-discuss] [issue644] 'Random Issue' Button isn't working In-Reply-To: <1508803113.44.0.213398074469.issue644@psf.upfronthosting.co.za> Message-ID: <1528296148.67.0.592728768989.issue644@psf.upfronthosting.co.za> Berker Peksag added the comment: Implemented Nick's suggestion in https://hg.python.org/tracker/python-dev/rev/ad6158d8414f _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Jun 9 09:25:32 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Sat, 09 Jun 2018 13:25:32 +0000 Subject: [Tracker-discuss] [issue654] Add triager icon In-Reply-To: <1528154189.0.0.592728768989.issue654@psf.upfronthosting.co.za> Message-ID: <1528550732.87.0.592728768989.issue654@psf.upfronthosting.co.za> Berker Peksag added the comment: Addressed Ezio's review comments in issue654_v2.diff. ---------- status: unread -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________ -------------- next part -------------- diff --git a/extensions/pydevutils.py b/extensions/pydevutils.py --- a/extensions/pydevutils.py +++ b/extensions/pydevutils.py @@ -16,16 +16,20 @@ def is_history_ok(request): # currently not used return True def is_coordinator(request): user = request.client.userid db = request.client.db return 'Coordinator' in db.user.get(user, 'roles') +def is_triager(request, userid): + db = request.client.db + return 'Developer' in db.user.get(userid, 'roles') + def clean_ok_message(ok_message): """Remove nosy_count and message_count from the ok_message.""" pattern = '\s*(?:nosy|message)_count,|,\s*(?:nosy|message)_count(?= edited)' return ''.join(re.sub(pattern, '', line) for line in ok_message) + '
' def issueid_and_action_from_class(cls): """ @@ -86,13 +90,14 @@ class RandomIssueAction(Action): rand = random.Random() url = self.db.config.TRACKER_WEB + 'issue' + rand.choice(issue_ids) raise Redirect(url) def init(instance): instance.registerUtil('is_history_ok', is_history_ok) instance.registerUtil('is_coordinator', is_coordinator) + instance.registerUtil('is_triager', is_triager) instance.registerUtil('clean_ok_message', clean_ok_message) instance.registerUtil('issueid_and_action_from_class', issueid_and_action_from_class) instance.registerUtil('clas_as_json', clas_as_json) instance.registerAction('random', RandomIssueAction) diff --git a/html/issue.item.html b/html/issue.item.html --- a/html/issue.item.html +++ b/html/issue.item.html @@ -358,16 +358,18 @@ replace="author_name" /> (
) * (Python committer) + (Python triager) Date:

diff --git a/html/triager.png b/html/triager.png new file mode 100644 index 0000000000000000000000000000000000000000..0bcdca6e48e75017037e837b0d6fba8662769fd6 GIT binary patch literal 477 zc$@*<0V4j1P)Px#0%A)?L;(MXkIcUS000SaNLh0L01FcU01FcV0GgZ_00007bV*G`2jT_<7CIt- z7&3tX00Ci1L_t(2&sC8zOB`VkhM(PAxz8gu2ZEPiW0 at k5CZ)wex)fRn<_BmKB&{|U zCLw|RfdmUvNK#mcl{OM9kqd_=ogkXn92N)SNp^0(nQv3<-Wg}Qd7gKsn2568Y-iI} z_he)u>l-Tw1`rPfn^~(X9wRuGn8X$Hp`a|I7>WmIP%GvMyj#^NAIYX9Qt^z;LXD;?PuzHnhaDi&ui<6%P~p4|^b&{`YU6Th9$8)M+Gx z{OxZ0>#u8+ob2H7gV%;(Fq&kdPPy6ovUxV|W`ncgF++tY*58V8ymP)#dwCxl=?}8F z|H+H;^V+>Akd at GY(>;0-js}nDU$zY8YAeqR1^%2Y9&r&7Q>8|J(Y;G6&zjtlazi&E zkdlIz;EL5xX$d(Ux+psQMQ={pnHb99Y5OgnzodBbXdvJiXM! Message-ID: <1528551557.4.0.592728768989.issue654@psf.upfronthosting.co.za> Berker Peksag added the comment: Ezio gave his LGTM on #python-dev and I just applied in https://hg.python.org/tracker/python-dev/rev/aac421fdfffb ---------- status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Jun 9 10:10:39 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Sat, 09 Jun 2018 14:10:39 +0000 Subject: [Tracker-discuss] [issue599] Strip content when replying to an issue via email In-Reply-To: <1465804507.36.0.926205719395.issue599@psf.upfronthosting.co.za> Message-ID: <1528553439.15.0.592728768989.issue599@psf.upfronthosting.co.za> Berker Peksag added the comment: This is a duplicate of issue491. ---------- status: chatting -> resolved superseder: +Ignore email signatures _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Jun 9 10:14:05 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Sat, 09 Jun 2018 14:14:05 +0000 Subject: [Tracker-discuss] [issue599] Strip content when replying to an issue via email In-Reply-To: <1465804507.36.0.926205719395.issue599@psf.upfronthosting.co.za> Message-ID: <1528553645.41.0.592728768989.issue599@psf.upfronthosting.co.za> Berker Peksag added the comment: Reading issue 491 again, I don't think this is exactly a duplicate of that issue. Reopening. ---------- status: resolved -> chatting superseder: -Ignore email signatures _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Jun 9 10:18:56 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Sat, 09 Jun 2018 14:18:56 +0000 Subject: [Tracker-discuss] [issue456] Add user links to roundup users In-Reply-To: <1334151020.0.0.534784635455.issue456@psf.upfronthosting.co.za> Message-ID: <1528553936.19.0.592728768989.issue456@psf.upfronthosting.co.za> Berker Peksag added the comment: This appears to be working now. I've just set it in my profile: https://bugs.python.org/user14674 Closing as 'resolved'. ---------- nosy: +berker.peksag status: in-progress -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Jun 9 10:31:40 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Sat, 09 Jun 2018 14:31:40 +0000 Subject: [Tracker-discuss] [issue603] update the SSL certificate In-Reply-To: <1470182862.63.0.941603312183.issue603@psf.upfronthosting.co.za> Message-ID: <1528554700.08.0.592728768989.issue603@psf.upfronthosting.co.za> Berker Peksag added the comment: > * The server supports only older protocols, but not the current best TLS 1.2. > Grade capped to C. There is an open issue for this item: issue 578 I'm not sure whether we should close that as a duplicate of this one. ---------- nosy: +berker.peksag _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Jun 9 16:09:26 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Sat, 09 Jun 2018 20:09:26 +0000 Subject: [Tracker-discuss] [issue624] bpo emails contain useless non-github pull_request number - users want a link to actual github PR In-Reply-To: <1490979933.98.0.318344152862.issue624@psf.upfronthosting.co.za> Message-ID: <1528574966.86.0.592728768989.issue624@psf.upfronthosting.co.za> Berker Peksag added the comment: Here's patch to fix this issue. Example output: ---------- components: +Tkinter versions: +Python 2.4 pull_request: https://github.com/python/cpython/pull/341 Old version: ---------- components: +Tkinter versions: +Python 2.4 pull_requests: +42 ---------- nosy: +berker.peksag _______________________________________________________ PSF Meta Tracker _______________________________________________________ -------------- next part -------------- diff --git a/detectors/sendmail.py b/detectors/sendmail.py --- a/detectors/sendmail.py +++ b/detectors/sendmail.py @@ -1,8 +1,10 @@ +import re + from roundup import roundupdb def determineNewMessages(cl, nodeid, oldvalues): ''' Figure a list of the messages that are being added to the given node in this transaction. ''' messages = [] if oldvalues is None: @@ -32,16 +34,26 @@ def is_spam(db, msgid): msg = db.getnode("msg", msgid) if msg.has_key('spambayes_score') and \ msg['spambayes_score'] > cutoff_score: return True return False +def extract_pr_number(changenote): + # Example input for 'changenote': + # + # '\n----------\nmessage_count: 2.0 -> 3.0\npull_requests: +20\nversions: +Python 3.1' + match = re.search(r'pull_requests: \+(\d+)', changenote, flags=re.M|re.S) + if match is None: + return None + return match.group(1) + + def sendmail(db, cl, nodeid, oldvalues): """Send mail to various recipients, when changes occur: * For all changes (property-only, or with new message), send mail to all e-mail addresses defined in db.config.detectors['BUSYBODY_EMAIL'] * For all changes (property-only, or with new message), send mail @@ -70,19 +82,28 @@ def sendmail(db, cl, nodeid, oldvalues): pass oldfiles = [] oldmsglist = [] else: changenote = cl.generateChangeNote(nodeid, oldvalues) oldfiles = oldvalues.get('files', []) oldmsglist = oldvalues.get('messages', []) - # Silence nosy_count/message_count lines = changenote.splitlines() - changenote = '\n'.join(line for line in lines if '_count' not in line) + + pr_number = extract_pr_number(changenote) + if pr_number is not None: + pr_number = db.pull_request.get(pr_number, 'number') + pr_url = 'pull_request: https://github.com/python/cpython/pull/%d' % pr_number + lines.append(pr_url) + + # Silence nosy_count/message_count/pull_requests + changenote = '\n'.join( + line for line in lines if '_count' not in line and 'pull_requests' not in line + ) newfiles = db.issue.get(nodeid, 'files', []) if oldfiles != newfiles: added = [fid for fid in newfiles if fid not in oldfiles] removed = [fid for fid in oldfiles if fid not in newfiles] filemsg = "" for fid in added: From metatracker at psf.upfronthosting.co.za Sat Jun 9 16:59:59 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Sat, 09 Jun 2018 20:59:59 +0000 Subject: [Tracker-discuss] [issue645] Searching for open bugs sets the button to all In-Reply-To: <1511737643.7.0.213398074469.issue645@psf.upfronthosting.co.za> Message-ID: <1528577999.16.0.592728768989.issue645@psf.upfronthosting.co.za> Berker Peksag added the comment: Here's a patch to fix this issue. ---------- nosy: +berker.peksag, ezio.melotti status: unread -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________ -------------- next part -------------- diff --git a/html/page.html b/html/page.html --- a/html/page.html +++ b/html/page.html @@ -42,20 +42,21 @@ status_all string:-1,1,2,3; From metatracker at psf.upfronthosting.co.za Sun Jun 10 01:17:10 2018 From: metatracker at psf.upfronthosting.co.za (Nick Coghlan) Date: Sun, 10 Jun 2018 05:17:10 +0000 Subject: [Tracker-discuss] [issue624] bpo emails contain useless non-github pull_request number - users want a link to actual github PR In-Reply-To: <1490979933.98.0.318344152862.issue624@psf.upfronthosting.co.za> Message-ID: <1528607830.82.0.592728768989.issue624@psf.upfronthosting.co.za> Nick Coghlan added the comment: Berker's patch using a post-filtering step, where the mail sending code notices the internal DB reference, adds a link to the GitHub PR based on a DB lookup, and then filters out the DB reference. That seems like a nice low impact way to resolve the UX problem to me, so +1 here. ---------- nosy: +ncoghlan _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sun Jun 10 01:22:36 2018 From: metatracker at psf.upfronthosting.co.za (Nick Coghlan) Date: Sun, 10 Jun 2018 05:22:36 +0000 Subject: [Tracker-discuss] [issue645] Searching for open bugs sets the button to all In-Reply-To: <1511737643.7.0.213398074469.issue645@psf.upfronthosting.co.za> Message-ID: <1528608156.29.0.592728768989.issue645@psf.upfronthosting.co.za> Nick Coghlan added the comment: To make this more obviously an either/or situation when looking at the template, perhaps the check on the "All" radio button could be: checked python:request.form.getvalue('status') != status_notresolved Otherwise I'd be wondering which button gets checked on an initial page load when the form hasn't been submitted at all. ---------- nosy: +ncoghlan _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sun Jun 10 08:56:38 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Sun, 10 Jun 2018 12:56:38 +0000 Subject: [Tracker-discuss] [issue645] Searching for open bugs sets the button to all In-Reply-To: <1511737643.7.0.213398074469.issue645@psf.upfronthosting.co.za> Message-ID: <1528635398.59.0.592728768989.issue645@psf.upfronthosting.co.za> Berker Peksag added the comment: Good catch, Nick. Fixed in issue645_v2.diff. Thanks! _______________________________________________________ PSF Meta Tracker _______________________________________________________ -------------- next part -------------- diff --git a/html/page.html b/html/page.html --- a/html/page.html +++ b/html/page.html @@ -42,20 +42,21 @@ status_all string:-1,1,2,3; From metatracker at psf.upfronthosting.co.za Sun Jun 10 11:34:11 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Sun, 10 Jun 2018 15:34:11 +0000 Subject: [Tracker-discuss] [issue624] bpo emails contain useless non-github pull_request number - users want a link to actual github PR In-Reply-To: <1490979933.98.0.318344152862.issue624@psf.upfronthosting.co.za> Message-ID: <1528644851.9.0.592728768989.issue624@psf.upfronthosting.co.za> Berker Peksag added the comment: Note that the regex code can be probably be simplified, I'm open to suggestions. I'm not sure whether re.S is still needed. + pr_number = db.pull_request.get(pr_number, 'number') Also, I need to be more defensive here and don't do anything if the query returned an empty result. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 10:20:01 2018 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Tue, 12 Jun 2018 14:20:01 +0000 Subject: [Tracker-discuss] [issue654] Add triager icon In-Reply-To: <1528154189.0.0.592728768989.issue654@psf.upfronthosting.co.za> Message-ID: <1528813201.43.0.475983251502.issue654@psf.upfronthosting.co.za> Ezio Melotti added the comment: I applied this yesterday but it's sometimes failing with the following error: File "extensions/pydevutils.py", line 26, in is_triager return 'Developer' in db.user.get(userid, 'roles') TypeError: argument of type 'NoneType' is not iterable Perhaps it would be better implementing the is_triager function in the same way the is_coordinator function is implemented. ---------- status: resolved -> in-progress _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 10:59:50 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 14:59:50 +0000 Subject: [Tracker-discuss] [issue654] Add triager icon In-Reply-To: <1528154189.0.0.592728768989.issue654@psf.upfronthosting.co.za> Message-ID: <1528815590.6.0.475983251502.issue654@psf.upfronthosting.co.za> Berker Peksag added the comment: I tried to copy is_coordinator() first, but request.client.userid gives the ID of the user who made the request, so it would return invalid results. Did you get the traceback on production? Is it possible to add a print to see the userid? Also, I can be more defensive and change the code to avoid TypeError: def is_triager(request, userid): db = request.client.db query = db.user.get(userid, 'roles') if query is None: return False return 'Developer' in query _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 11:04:21 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 15:04:21 +0000 Subject: [Tracker-discuss] [issue624] bpo emails contain useless non-github pull_request number - users want a link to actual github PR In-Reply-To: <1490979933.98.0.318344152862.issue624@psf.upfronthosting.co.za> Message-ID: <1528815861.25.0.475983251502.issue624@psf.upfronthosting.co.za> Berker Peksag added the comment: I just noticed that I probably need to update the clean_ok_message() function in pydevutils.py to remove pull_requests. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 13:27:31 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 17:27:31 +0000 Subject: [Tracker-discuss] [issue654] Add triager icon In-Reply-To: <1528154189.0.0.592728768989.issue654@psf.upfronthosting.co.za> Message-ID: <1528824451.0.0.475983251502.issue654@psf.upfronthosting.co.za> Berker Peksag added the comment: Applied issue654_followup.diff in https://hg.python.org/tracker/python-dev/rev/9363c06cda40 _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 13:37:22 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 17:37:22 +0000 Subject: [Tracker-discuss] [issue654] Add triager icon In-Reply-To: <1528154189.0.0.592728768989.issue654@psf.upfronthosting.co.za> Message-ID: <1528825042.88.0.947875510639.issue654@psf.upfronthosting.co.za> Berker Peksag added the comment: Ezio has just deployed 9363c06cda40 and confirmed that the bug is fixed. Closing as 'resolved' again. ---------- status: in-progress -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:23:10 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:23:10 +0000 Subject: [Tracker-discuss] [issue645] Searching for open bugs sets the button to all In-Reply-To: <1511737643.7.0.213398074469.issue645@psf.upfronthosting.co.za> Message-ID: <1528827790.06.0.947875510639.issue645@psf.upfronthosting.co.za> Berker Peksag added the comment: Applied in https://hg.python.org/tracker/python-dev/rev/9c6cedab723d Thanks for the review, Nick. ---------- status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:26:11 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:26:11 +0000 Subject: [Tracker-discuss] [issue439] Email notifictations not received for rietveld review In-Reply-To: <1331683700.81.0.418164698072.issue439@psf.upfronthosting.co.za> Message-ID: <1528827971.32.0.947875510639.issue439@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:26:42 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:26:42 +0000 Subject: [Tracker-discuss] [issue484] AttributeError 'NoneType' object has no attribute 'issue' when replying to issue In-Reply-To: <1349060930.13.0.228095148392.issue484@psf.upfronthosting.co.za> Message-ID: <1528828002.08.0.947875510639.issue484@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:28:14 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:28:14 +0000 Subject: [Tracker-discuss] [issue490] Review links crash after changing username In-Reply-To: <1352142685.19.0.283559618206.issue490@psf.upfronthosting.co.za> Message-ID: <1528828094.96.0.947875510639.issue490@psf.upfronthosting.co.za> Berker Peksag added the comment: Thanks for the report and for the patch. The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: unread -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:28:37 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:28:37 +0000 Subject: [Tracker-discuss] [issue508] 'NoneType' object has no attribute 'user_has_selected_nickname' In-Reply-To: <1361649523.28.0.651717211054.issue508@psf.upfronthosting.co.za> Message-ID: <1528828117.6.0.947875510639.issue508@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: unread -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:30:17 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:30:17 +0000 Subject: [Tracker-discuss] [issue365] No issue exists with that id In-Reply-To: <1293200576.2.0.44483259406.issue365@psf.upfronthosting.co.za> Message-ID: <1528828217.66.0.947875510639.issue365@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:30:57 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:30:57 +0000 Subject: [Tracker-discuss] [issue434] ProgrammingError while deleting patch set In-Reply-To: <1327350186.37.0.213968267021.issue434@psf.upfronthosting.co.za> Message-ID: <1528828257.05.0.947875510639.issue434@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:32:21 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:32:21 +0000 Subject: [Tracker-discuss] [issue435] Rietveld Code Review Tool bugs In-Reply-To: <1327568593.26.0.104803212189.issue435@psf.upfronthosting.co.za> Message-ID: <1528828341.2.0.947875510639.issue435@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:32:44 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:32:44 +0000 Subject: [Tracker-discuss] [issue432] Rietveld traceback In-Reply-To: <1323942602.68.0.925393034145.issue432@psf.upfronthosting.co.za> Message-ID: <1528828364.87.0.947875510639.issue432@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:33:12 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:33:12 +0000 Subject: [Tracker-discuss] [issue424] Rietveld: AssertionError when trying to reply to comments In-Reply-To: <1318328000.91.0.751562811451.issue424@psf.upfronthosting.co.za> Message-ID: <1528828392.79.0.947875510639.issue424@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:33:48 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:33:48 +0000 Subject: [Tracker-discuss] [issue382] Bad CC on review In-Reply-To: <1301154873.73.0.955420098799.issue382@psf.upfronthosting.co.za> Message-ID: <1528828428.97.0.947875510639.issue382@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:35:42 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:35:42 +0000 Subject: [Tracker-discuss] [issue517] Issue Tracker crashes when replying to patch review In-Reply-To: <1368614539.09.0.10268095981.issue517@psf.upfronthosting.co.za> Message-ID: <1528828542.07.0.947875510639.issue517@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:40:05 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:40:05 +0000 Subject: [Tracker-discuss] [issue394] Better integration with Rietveld code review tool In-Reply-To: <1303156350.85.0.792534425783.issue394@psf.upfronthosting.co.za> Message-ID: <1528828805.78.0.947875510639.issue394@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:41:13 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:41:13 +0000 Subject: [Tracker-discuss] [issue554] Add special mark to Rietvelds emails In-Reply-To: <1413143480.64.0.313151672251.issue554@psf.upfronthosting.co.za> Message-ID: <1528828873.16.0.947875510639.issue554@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:42:42 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:42:42 +0000 Subject: [Tracker-discuss] [issue485] Autoclosing Rietveld issue In-Reply-To: <1349187694.92.0.504301868158.issue485@psf.upfronthosting.co.za> Message-ID: <1528828962.32.0.947875510639.issue485@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: unread -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:43:30 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:43:30 +0000 Subject: [Tracker-discuss] [issue404] Personal comment rating In-Reply-To: <1307133665.5.0.190293604429.issue404@psf.upfronthosting.co.za> Message-ID: <1528829010.85.0.947875510639.issue404@psf.upfronthosting.co.za> Berker Peksag added the comment: I agree with Serhiy. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:48:17 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:48:17 +0000 Subject: [Tracker-discuss] [issue518] Plaintext connections when logging in In-Reply-To: <1372403857.35.0.242184511597.issue518@psf.upfronthosting.co.za> Message-ID: <1528829297.71.0.947875510639.issue518@psf.upfronthosting.co.za> Berker Peksag added the comment: All HTTP requests now redirected to HTTPS: $ curl -I http://bugs.python.org HTTP/1.1 301 Moved Permanently Date: Tue, 12 Jun 2018 18:47:14 GMT Server: Apache/2.2.16 (Debian) Location: https://bugs.python.org/ Content-Type: text/html; charset=iso-8859-1 Closing as 'resolved'. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:51:19 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:51:19 +0000 Subject: [Tracker-discuss] [issue156] Have a Core Bug Chaser Create a Bug Reporting Screencast In-Reply-To: <1189687665.63.0.143239718478.issue156@psf.upfronthosting.co.za> Message-ID: <1528829479.57.0.947875510639.issue156@psf.upfronthosting.co.za> Berker Peksag added the comment: After 11 years, I think the better place to discuss this is the core-workflow list. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:52:09 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:52:09 +0000 Subject: [Tracker-discuss] [issue410] More useful filenames for patches generated from hg In-Reply-To: <1311174897.41.0.079884081521.issue410@psf.upfronthosting.co.za> Message-ID: <1528829529.3.0.947875510639.issue410@psf.upfronthosting.co.za> Berker Peksag added the comment: The recommended way of contributing to Python is now GitHub pull requests and we no longer maintain our Rietveld instance. Closing this issue. ---------- nosy: +berker.peksag status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 12 14:54:10 2018 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 12 Jun 2018 18:54:10 +0000 Subject: [Tracker-discuss] [issue387] Need OpenID login for this tracker In-Reply-To: <1301995928.44.0.997339418316.issue387@psf.upfronthosting.co.za> Message-ID: <1528829650.63.0.947875510639.issue387@psf.upfronthosting.co.za> Berker Peksag added the comment: I don't think it's worth to add OpenID login since the level of traffic and active users are pretty low here. ---------- nosy: +berker.peksag status: unread -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Fri Jun 15 06:48:09 2018 From: metatracker at psf.upfronthosting.co.za (Nick Coghlan) Date: Fri, 15 Jun 2018 10:48:09 +0000 Subject: [Tracker-discuss] [issue655] Migrate to the "python" org on GitHub? Message-ID: <1529059689.28.0.947875510639.issue655@psf.upfronthosting.co.za> New submission from Nick Coghlan : Hi folks, bugs.python.org is currently a key piece of CPython workflow automation, but it's relatively difficult to contribute to as it uses a different workflow from both CPython itself *and* the rest of the core workflow projects (cherry picker, blurb, miss-islington, the knights-who-say-ni, etc). It also uses a workflow different from that of the main python.org website, as well as that of PyPI. Accordingly, I'd like to propose that we start migrating the tracker's development processes to a new "python/bugs.python.org" repo on Github via the following process: 1. Create the project repo immediately, and start using its issue tracker for new issues in preference to the current metatracker. (I'd migrate this issue over there, and turn these bullet points into a task list) 2. Prepare to migrate the Mercurial repo to GitHub, using the CPython repo migration PEP as a guide 3. Actually migrate the source repo 4. Update the links in the b.p.o service accordingly In parallel with 2-4, the fate of the meta-tracker could be determined (either bulk closing all issues, and requesting they be reopened in GitHub if they're still relevant, or else figuring out a way to migrate them automatically) (I know I'm glossing over a lot of steps there, but I'd elaborate on them more in a GitHub task list assuming the idea is accepted by the current maintainers as acceptable-in-principle) ---------- messages: 3505 nosy: ncoghlan priority: wish status: unread title: Migrate to the "python" org on GitHub? _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Fri Jun 15 07:56:26 2018 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Fri, 15 Jun 2018 11:56:26 +0000 Subject: [Tracker-discuss] [issue655] Migrate to the "python" org on GitHub? In-Reply-To: <1529059689.28.0.947875510639.issue655@psf.upfronthosting.co.za> Message-ID: <1529063786.43.0.947875510639.issue655@psf.upfronthosting.co.za> Ezio Melotti added the comment: Keep in mind that converting the repo to Git will make it more difficult to upgrade, since our roundup is a clone of the main Roundup repo. So, assuming this issue moves forward, we can either: * start using official Roundup releases (this means no changes to Roundup, only the instances); * wait for upstream Roundup to switch to git and keep the same workflow (there has been some talk about it, but if/when will happen is still unknown); * keep updating from their clone with some extra steps in between to convert between hg and git every time; * come up with a new workflow that is equally flexible and easy; Note that one of the reasons why we run a clone of Roundup is to be able to fix/change things upstream and being able to deploy them on our tracker immediately, without having to wait months for the next release and without having our branch diverge and have to deal with conflicts later. This has been done several times in the past in case of security issues. As for the metatracker, I wouldn't be against moving it to github (if it's possible to create a source-less project just to use the issue tracker). ---------- nosy: +ezio.melotti status: unread -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Fri Jun 15 09:48:58 2018 From: metatracker at psf.upfronthosting.co.za (Nick Coghlan) Date: Fri, 15 Jun 2018 13:48:58 +0000 Subject: [Tracker-discuss] [issue655] Migrate to the "python" org on GitHub? In-Reply-To: <1529059689.28.0.947875510639.issue655@psf.upfronthosting.co.za> Message-ID: <1529070538.62.0.947875510639.issue655@psf.upfronthosting.co.za> Nick Coghlan added the comment: Issue-tracker-only repos technically aren't sourceless, but the trick is that the only file you create is a README, and perhaps some issue templates: https://github.com/python/bugs.python.org Alternatively, they can also be good places to host the source code for ReadTheDocs Sphinx projects: https://github.com/python/bugs.python.org/issues/3 Anyway, given that https://github.com/python/bugs.python.org/issues/1 and https://github.com/python/bugs.python.org/issues/2 are now filed, and Ernest has responded on the latter, I'm going to mark this one as "resolved". ---------- status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Fri Jun 15 12:25:11 2018 From: metatracker at psf.upfronthosting.co.za (Eric Snow) Date: Fri, 15 Jun 2018 16:25:11 +0000 Subject: [Tracker-discuss] [issue600] Convert patches to GitHub Pull Request (depends on issue586) In-Reply-To: <1466359411.87.0.930389612417.issue600@psf.upfronthosting.co.za> Message-ID: <1529079911.77.0.947875510639.issue600@psf.upfronthosting.co.za> Eric Snow added the comment: The main goal here is to make it easier for folks to move patches to GitHub. So there are a number of things we can do to help, which mostly build on one another: 1. determine a git commit hash on which a patch applies cleanly * best guess based on date (i.e. from the patch's tracker metadata) or even by attempt [1] * it doesn't have to be perfect (folks can rebase, etc.) 2. add a column (in the "Files" table) for "Base Git Revision" 3. add a button/link (in its own column?) for "Create Git Branch" a. get necessary info (e.g. otherwise hidden form, pop-up, separate page) 1. field for repo URL (pre-filled with generated GH one) [or use dedicated user/repo fields?] + use GH username associated with current user, if available + use "cpython" as default repo name 2. field for branch name (pre-filled based on patch file name) 3. field for base revision (blank? pre-filled with result of (1) above) 4. field for commit message (pre-filled with something simple) 5. check box for "create PR" b. apply the patch to a (local) git clone 1. checkout the base revision 2. create the branch 3. apply the patch 4. commit c. push the branch to the repo URL d. (optionally) create the PR 4. add a column (in the "Files" table) for links to PRs that have been created from the patch (maybe) automate: 5. determine which patches on an issue should be turned into PRs 6. automate create PRs for groups of (manually/programatically) selected patches 7. (probably not) create PRs for all [valid (see (5) above)] patches on all open issues Note that even just (2) would save folks a lot of hassle. For older patches it's a real pain to figure out where the patch applies cleanly. [1] If there isn't already a tool to help with this, there ought to be. It would give a set of git hashes based on a timestamp (and hg repo). If also given a patch, it could identify the newest one of those hashes to which the patch applies cleanly. ---------- nosy: +eric.snow _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Fri Jun 15 12:29:01 2018 From: metatracker at psf.upfronthosting.co.za (Eric Snow) Date: Fri, 15 Jun 2018 16:29:01 +0000 Subject: [Tracker-discuss] [issue635] Information on meta-tracker server migration In-Reply-To: <1500883975.73.0.767118106632.issue635@psf.upfronthosting.co.za> Message-ID: <1529080141.93.0.947875510639.issue635@psf.upfronthosting.co.za> Eric Snow added the comment: related: #655 ---------- nosy: +eric.snow _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Fri Jun 15 12:29:44 2018 From: metatracker at psf.upfronthosting.co.za (Eric Snow) Date: Fri, 15 Jun 2018 16:29:44 +0000 Subject: [Tracker-discuss] [issue655] Migrate to the "python" org on GitHub? In-Reply-To: <1529059689.28.0.947875510639.issue655@psf.upfronthosting.co.za> Message-ID: <1529080184.24.0.947875510639.issue655@psf.upfronthosting.co.za> Eric Snow added the comment: related: issue635 ---------- nosy: +eric.snow _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Fri Jun 15 12:45:23 2018 From: metatracker at psf.upfronthosting.co.za (Eric Snow) Date: Fri, 15 Jun 2018 16:45:23 +0000 Subject: [Tracker-discuss] [issue656] Support GitHub Auth in Sidebar Message-ID: <1529081123.16.0.947875510639.issue656@psf.upfronthosting.co.za> New submission from Eric Snow : In the sidebar under the "Login" section we currently have links (via icons) for Google and Launchpad. Adding one for GitHub makes a lot of sense, particularly since the repos are on GitHub. I expect that it would also lower the barrier-to-entry for new contributors. ---------- messages: 3511 nosy: eric.snow priority: feature status: unread title: Support GitHub Auth in Sidebar _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Fri Jun 15 21:50:15 2018 From: metatracker at psf.upfronthosting.co.za (Nick Coghlan) Date: Sat, 16 Jun 2018 01:50:15 +0000 Subject: [Tracker-discuss] [issue635] Information on meta-tracker server migration In-Reply-To: <1500883975.73.0.767118106632.issue635@psf.upfronthosting.co.za> Message-ID: <1529113815.83.0.56676864532.issue635@psf.upfronthosting.co.za> Nick Coghlan added the comment: As per https://github.com/python/bugs.python.org/issues/1 (and #655 as Eric linked above), I'm now proposing that we switch the meta-tracker over to GitHub, since we don't need the workflow customisation for bugs.python.org itself that we currently want for CPython. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Fri Jun 15 23:58:45 2018 From: metatracker at psf.upfronthosting.co.za (Nick Coghlan) Date: Sat, 16 Jun 2018 03:58:45 +0000 Subject: [Tracker-discuss] [issue605] Python tracker needs two classes of "easy" issues -- requiring C or not In-Reply-To: <1473885929.19.0.0101452580973.issue605@psf.upfronthosting.co.za> Message-ID: <1529121525.55.0.56676864532.issue605@psf.upfronthosting.co.za> Nick Coghlan added the comment: Marking as resolved based on the "easy (C)" keyword (part of the https://github.com/python/bugs.python.org/issues/1 issue review) ---------- status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Jun 16 00:03:06 2018 From: metatracker at psf.upfronthosting.co.za (Nick Coghlan) Date: Sat, 16 Jun 2018 04:03:06 +0000 Subject: [Tracker-discuss] [issue414] Mercurial integration: verify repo when adding In-Reply-To: <1312642333.95.0.845747072773.issue414@psf.upfronthosting.co.za> Message-ID: <1529121786.24.0.56676864532.issue414@psf.upfronthosting.co.za> Nick Coghlan added the comment: Marking as obsolete given CPython's migration to GitHub (part of the https://github.com/python/bugs.python.org/issues/1 issue review) ---------- nosy: +ncoghlan status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Jun 16 09:45:29 2018 From: metatracker at psf.upfronthosting.co.za (Julien Palard) Date: Sat, 16 Jun 2018 13:45:29 +0000 Subject: [Tracker-discuss] [issue562] Gmail (google) marks registration email as spam In-Reply-To: <1422157456.62.0.726959967661.issue562@psf.upfronthosting.co.za> Message-ID: <1529156729.3.0.56676864532.issue562@psf.upfronthosting.co.za> Julien Palard added the comment: Protonmail is now displaying me a huge red banner on b.p.o emails: > email has failed its domain's authentication requirements. It may be spoofed or improperly forwarded! Adding an SPF entry should be enough, if not going full SPF+DKIM+DMARC. SPF entry can be simple if "Mail is consistently sent from report at bugs.python.org, always from the same IP address, 46.4.197.70. 46.4.197.70" is still true, something like: bugs.python.org. IN TXT "v=spf1 ip4:46.4.197.70 ip4:46.4.197.70 -all" is enough. ---------- nosy: +mdk _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sun Jun 17 08:50:28 2018 From: metatracker at psf.upfronthosting.co.za (Nick Coghlan) Date: Sun, 17 Jun 2018 12:50:28 +0000 Subject: [Tracker-discuss] [issue562] Gmail (google) marks registration email as spam In-Reply-To: <1422157456.62.0.726959967661.issue562@psf.upfronthosting.co.za> Message-ID: <1529239828.01.0.56676864532.issue562@psf.upfronthosting.co.za> Nick Coghlan added the comment: I've migrated this issue over to the new meta-tracker at https://github.com/python/bugs.python.org/issues/10 This is one of several problems with the existing bugs.python.org infrastructure that are leading to it being rehosted elsewhere, and I've tagged the folks working on that project in the new issue. ---------- nosy: +ncoghlan _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 19 18:34:25 2018 From: metatracker at psf.upfronthosting.co.za (Cheryl Sabella) Date: Tue, 19 Jun 2018 22:34:25 +0000 Subject: [Tracker-discuss] [issue644] 'Random Issue' Button isn't working In-Reply-To: <1508803113.44.0.213398074469.issue644@psf.upfronthosting.co.za> Message-ID: <1529447665.13.0.56676864532.issue644@psf.upfronthosting.co.za> Cheryl Sabella added the comment: Thanks Berker! _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 26 09:26:21 2018 From: metatracker at psf.upfronthosting.co.za (James Stevens) Date: Tue, 26 Jun 2018 13:26:21 +0000 Subject: [Tracker-discuss] [issue591] Unable to register on bugs.python.org if an homepage is specified In-Reply-To: <1464754461.87.0.614181639598.issue591@psf.upfronthosting.co.za> Message-ID: <1530019581.14.0.56676864532.issue591@psf.upfronthosting.co.za> James Stevens added the comment: I ran into the same issue of the "homepage" validation - but failed to notice the error message amongst all the other information. I suggest if an error occurs in the confirmation, the error should be (virtually) the only thing displayed - giving the current issue list as well is confusing and unnecessary. If the confirmation succeeds a dedicated screen is displayed - the same should be true if it fails. I would have thought adding some Javascript into the "onSubmit" of the form to validate the various fields would be relatively trivial - and more helpful to the user than relying on the backend validation. A regex for most of the fields would be readily available via Google. At the very least, javascript to automatically add a prefix "http://" (like a browser would) is literally one line of code. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Jun 26 09:15:06 2018 From: metatracker at psf.upfronthosting.co.za (James Stevens) Date: Tue, 26 Jun 2018 13:15:06 +0000 Subject: [Tracker-discuss] [issue591] Unable to register on bugs.python.org if an homepage is specified In-Reply-To: <1464754461.87.0.614181639598.issue591@psf.upfronthosting.co.za> Message-ID: <1530018906.17.0.56676864532.issue591@psf.upfronthosting.co.za> James Stevens added the comment: When I tried to register, my registration was silently ignored becuase of this bug. I never received any kind of error message saying why (screenshot) It took quite a lot of persistence to find why the registration was not working - the initial response was that I wasn't clicking the link correctly. Couldn't you just add some validation Javascript to the website (in the onSubmit for the registration form) - that seems to me to be a really easy fix? Or automatically add a preceding "http://" if one is lacking, just like a browser would, as indicated by "jamesray" ---------- nosy: +james_stevens _______________________________________________________ PSF Meta Tracker _______________________________________________________ -------------- next part -------------- A non-text attachment was scrubbed... Name: Selection_2018-06-26_002.png Type: image/png Size: 278016 bytes Desc: not available URL: