From metatracker at psf.upfronthosting.co.za Thu Feb 2 00:10:04 2017 From: metatracker at psf.upfronthosting.co.za (Zachary Ware) Date: Thu, 02 Feb 2017 05:10:04 +0000 Subject: [Tracker-discuss] [issue611] Update issue with a commit information In-Reply-To: <1485224514.2.0.124865035832.issue611@psf.upfronthosting.co.za> Message-ID: <1486012204.93.0.97597245987.issue611@psf.upfronthosting.co.za> Zachary Ware added the comment: This seems to have some odd behavior, see for example https://bugs.python.org/issue29381 Each action (add message, change status, change resolution, change stage) all happened separately, which means 4 separate emails sent to everyone on the nosy list. Also, automatic closure isn't the correct behavior, IMO; it should match the existing hg integration where closure only occurs if the message contains "Closes #" or "Fixes #" rather than just "Issue #". Other than those two points, this seems to be working quite well; thank you Maciej! ---------- nosy: +zach.ware _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Thu Feb 2 00:17:35 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Thu, 02 Feb 2017 05:17:35 +0000 Subject: [Tracker-discuss] [issue611] Update issue with a commit information In-Reply-To: <1485224514.2.0.124865035832.issue611@psf.upfronthosting.co.za> Message-ID: <1486012655.72.0.789321227671.issue611@psf.upfronthosting.co.za> Berker Peksag added the comment: > Also, automatic closure isn't the correct behavior, [...] I agree with Zachary. BTW, there is a separate issue to set appropriate fields when an issue is manually closed: http://psf.upfronthosting.co.za/roundup/meta/issue595 (I should probably apply it :)) ---------- nosy: +berker.peksag _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Thu Feb 2 01:07:52 2017 From: metatracker at psf.upfronthosting.co.za (Zachary Ware) Date: Thu, 02 Feb 2017 06:07:52 +0000 Subject: [Tracker-discuss] [issue611] Update issue with a commit information In-Reply-To: <1485224514.2.0.124865035832.issue611@psf.upfronthosting.co.za> Message-ID: <1486015672.01.0.328396308881.issue611@psf.upfronthosting.co.za> Zachary Ware added the comment: Note https://mail.python.org/pipermail/docs/2017-February/thread.html The multiple email issue is definitely going to need to be fixed sooner rather than later :) Also, I just noticed that the date is not set on the messages. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Thu Feb 2 07:43:36 2017 From: metatracker at psf.upfronthosting.co.za (Maciej Szulik) Date: Thu, 02 Feb 2017 12:43:36 +0000 Subject: [Tracker-discuss] [issue611] Update issue with a commit information In-Reply-To: <1485224514.2.0.124865035832.issue611@psf.upfronthosting.co.za> Message-ID: <1486039416.94.0.485817413682.issue611@psf.upfronthosting.co.za> Maciej Szulik added the comment: > This seems to have some odd behavior, see for example https://bugs.python.org/issue29381 > Each action (add message, change status, change resolution, change stage) all happened separately, which means 4 separate emails sent to everyone on the nosy list. Thanks for the pointer, I'll look into why there are multiple events. Yes, one should be done. > Also, automatic closure isn't the correct behavior, IMO; it should match the existing hg integration where closure only occurs if the message contains "Closes #" or "Fixes #" rather than just "Issue #". Yes it should work like that, apparently something went wrong, will dig deeper. > BTW, there is a separate issue to set appropriate fields when an issue is manually closed: http://psf.upfronthosting.co.za/roundup/meta/issue595 (I should probably apply it :)) Didn't know about that, I'll look and apply accordingly. > Note https://mail.python.org/pipermail/docs/2017-February/thread.html > The multiple email issue is definitely going to need to be fixed sooner rather than later :) Multiple emails due to hg + gh will be fixed when we migrate to gh. Multiple emails due to above needs fixing - agreed. Multiple emails due to multiple branches - unfortunately won't, b/c each push is against separate branch and when processing that I don't know anything about related pushes. > Also, I just noticed that the date is not set on the messages. Good point, will fix. Zach and Berker thanks for pointers, greatly appreciated! _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Thu Feb 2 11:01:55 2017 From: metatracker at psf.upfronthosting.co.za (Zachary Ware) Date: Thu, 02 Feb 2017 16:01:55 +0000 Subject: [Tracker-discuss] [issue611] Update issue with a commit information In-Reply-To: <1485224514.2.0.124865035832.issue611@psf.upfronthosting.co.za> Message-ID: <1486051315.58.0.853003828701.issue611@psf.upfronthosting.co.za> Zachary Ware added the comment: > Multiple emails due to multiple branches - unfortunately won't, b/c each push is against separate > branch and when processing that I don't know anything about related pushes. Fair enough; if we can't do it, we can't do it [1]. Fixing the automatic closing and separate actions will go a long way toward alleviating the email flood. And of course the hg/git duplication is expected for now. Thanks for working on this! [1] Although, we could consider doing something heinous like checking if the latest message on the issue was a commit message and editing new commit information into it, but I did use the word "heinous" there for a reason :) _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Thu Feb 2 12:37:07 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Thu, 02 Feb 2017 17:37:07 +0000 Subject: [Tracker-discuss] [issue611] Update issue with a commit information In-Reply-To: <1485224514.2.0.124865035832.issue611@psf.upfronthosting.co.za> Message-ID: <1486057027.31.0.299973129933.issue611@psf.upfronthosting.co.za> Berker Peksag added the comment: Another alternative is to only send notifications for 2.7 and master branches for now [1] For example, see http://bugs.python.org/issue29407 we would only see the latest notification with this approach: http://bugs.python.org/msg286687 Since commit hashes don't change, there shouldn't be much problem with this approach. [1] Since we are going to use "commit to master; cherry-pick to bugfix branches" with git, perhaps we could store these events in a queue, then periodically group them together and send them to bugs.p.o? _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Thu Feb 2 14:07:15 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Thu, 02 Feb 2017 19:07:15 +0000 Subject: [Tracker-discuss] [issue595] Set stage to 'resolved' when an issue is closed In-Reply-To: <1465455890.27.0.55118446796.issue595@psf.upfronthosting.co.za> Message-ID: <1486062435.78.0.120768215491.issue595@psf.upfronthosting.co.za> Berker Peksag added the comment: I tested this again and addressed David's review comment. Applied in https://hg.python.org/tracker/python-dev/rev/5b89f6f8abd3 ---------- status: chatting -> testing _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Thu Feb 2 15:03:24 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Thu, 02 Feb 2017 20:03:24 +0000 Subject: [Tracker-discuss] [issue611] Update issue with a commit information In-Reply-To: <1485224514.2.0.124865035832.issue611@psf.upfronthosting.co.za> Message-ID: <1486065804.4.0.209263397697.issue611@psf.upfronthosting.co.za> Berker Peksag added the comment: The attached patch should fix the empty date issue. _______________________________________________________ PSF Meta Tracker _______________________________________________________ -------------- next part -------------- diff --git a/roundup/github.py b/roundup/github.py --- a/roundup/github.py +++ b/roundup/github.py @@ -1,15 +1,16 @@ import hashlib import hmac import json import re import os import logging +from roundup.date import Date from roundup.exceptions import Unauthorised, MethodNotAllowed, \ UnsupportedMediaType, Reject if hasattr(hmac, 'compare_digest'): compare_digest = hmac.compare_digest else: def compare_digest(a, b): return a == b @@ -350,17 +351,20 @@ class Push(Event): # close the issue messages[issue_id] = (curr_msg + u'\n' + msg, curr_close|close) if not messages: return for issue_id, (msg, close) in messages.iteritems(): # add comments to appropriate issues... id = issue_id.encode('utf-8') issue_msgs = self.db.issue.get(id, 'messages') - newmsg = self.db.msg.create(content=msg.encode('utf-8'), author=self.db.getuid()) + newmsg = self.db.msg.create( + content=msg.encode('utf-8'), author=self.db.getuid(), + date=Date('.'), + ) issue_msgs.append(newmsg) self.db.issue.set(id, messages=issue_msgs) # ... and close, if needed if close: self.db.issue.set(id, status=self.db.status.lookup('closed')) self.db.issue.set(id, resolution=self.db.resolution.lookup('fixed')) diff --git a/test/test_github.py b/test/test_github.py --- a/test/test_github.py +++ b/test/test_github.py @@ -1,16 +1,17 @@ import unittest import os import db_test_base import cgi from BaseHTTPServer import BaseHTTPRequestHandler from StringIO import StringIO from roundup.cgi import client from roundup.backends import list_backends +from roundup.date import Date from roundup.github import GitHubHandler from roundup.exceptions import * NEEDS_INSTANCE = 1 class HTTPRequest(BaseHTTPRequestHandler): def __init__(self, filename): @@ -303,16 +304,18 @@ class TestCase(unittest.TestCase): msgs = self.db.issue.get('1', 'messages') self.assertEqual(len(msgs), 1) content = self.db.msg.get(msgs[0], 'content') self.assertIn("""New changeset 65c3a074262662a2c55109ff9a2456ee7647fcc9 by Maciej Szulik in branch 'test1': #1: fix tests. https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9 """, content) + self.assertIsInstance(self.db.msg.get(msgs[0], 'creation'), Date) + self.assertIsInstance(self.db.msg.get(msgs[0], 'date'), Date) # issue status status = self.db.issue.get('1', 'status') self.assertNotEqual(self.db.status.get(status, 'name'), 'closed') self.assertIsNone(self.db.issue.get('1', 'resolution')) self.assertIsNone(self.db.issue.get('1', 'stage')) def testPushEventAddsCommentAndClose(self): dummy_client = self._make_client('pushevent1.txt') From metatracker at psf.upfronthosting.co.za Thu Feb 2 15:06:26 2017 From: metatracker at psf.upfronthosting.co.za (Maciej Szulik) Date: Thu, 02 Feb 2017 20:06:26 +0000 Subject: [Tracker-discuss] [issue611] Update issue with a commit information In-Reply-To: <1485224514.2.0.124865035832.issue611@psf.upfronthosting.co.za> Message-ID: <1486065986.89.0.369509837781.issue611@psf.upfronthosting.co.za> Maciej Szulik added the comment: > Another alternative is to only send notifications for 2.7 and master branches for now That's reasonable approach. I think we've talked about it with Brett and Ezio some time ago. > perhaps we could store these events in a queue, then periodically group them together and send them to bugs.p.o? That would be nice improvement :) _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Thu Feb 2 16:30:47 2017 From: metatracker at psf.upfronthosting.co.za (Maciej Szulik) Date: Thu, 02 Feb 2017 21:30:47 +0000 Subject: [Tracker-discuss] [issue611] Update issue with a commit information In-Reply-To: <1485224514.2.0.124865035832.issue611@psf.upfronthosting.co.za> Message-ID: <1486071047.77.0.636462608652.issue611@psf.upfronthosting.co.za> Maciej Szulik added the comment: Berker's date patch applied here: https://hg.python.org/tracker/roundup/rev/5d2e54d9b327 All the others were addressed here: https://hg.python.org/tracker/roundup/rev/68b787ac295b _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Fri Feb 3 00:57:08 2017 From: metatracker at psf.upfronthosting.co.za (Jim DeLaHunt) Date: Fri, 03 Feb 2017 05:57:08 +0000 Subject: [Tracker-discuss] [issue612] Unable to log in with OpenId, "Not authenticated (no session)" Message-ID: <1486101428.05.0.334787650816.issue612@psf.upfronthosting.co.za> New submission from Jim DeLaHunt: I log in via OpenID as http://id.jdlh.com/jdlh . When I try to log in at the Python Issues Tracker http://bugs.python.org/, it fails with an error message, Not authenticated (no session) To reproduce: ? Browse to http://bugs.python.org/. The main bug tracker page appears. In the left pane are two text entry boxes, the upper with an OpenID logo in it. ? In the first text box, enter http://id.jdlh.com/jdlh ? Don't touch the second text box. ? Press the [Login] button. ? The first time I did this, the login UI of my delegated provider, openid.stackexchange.com, appeared, and I logged in normally. Subsequently, this step did not occur. ? The main bug tracker page appears again, with a looong URL beginning: http://bugs.python.org/?@action=openid_return.... Expected behaviour: ? I am logged in with a tracker user based on my OpenID. ? No error messages. Observed behaviour: ? An error message, in white letters on a red background, appears at the top of the screen. It reads, Not authenticated (no session) ? I am not logged in. Discussion: This bug is identical to http://psf.upfronthosting.co.za/roundup/meta/issue440 from 2013. This was reported on 14. March 2013, and on 2. April of that year, the reporter said that it worked again. The issue has no details about what might have caused the problem to occur or to stop. I have worked around this bug by registering my own user ID, as "JDLH". I am using Firefox 51.0.1 (64-bit) on a Mac OS X 10.10.5 OS. The more complete URL is: http://bugs.python.org/?@action=openid_return&__came_from=&openid.claimed_id=http%3A%2F%2Fid.jdlh.com%2Fjdlh&openid.identity=https%3A%2F%2Fopenid.stackexchange.com%2Fuser%2F& [...snip...] &openid.op_endpoint=https%3A%2F%2Fopenid.stackexchange.com%2Fopenid%2Fprovider&openid.return_to=http%3A%2F%2Fbugs.python.org%2F%3F%40action%3Dopenid_return%26__came_from%3D&openid.response_nonce=2017-02-03T05%3A[...snip...]&openid.mode=id_res&openid.ns=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0 (I snipped out some opaque data from the URL, for greater security, though if I understand OpenID correctly, that data isn't sensitive anyway.) ---------- messages: 3245 nosy: JDLH priority: bug status: unread title: Unable to log in with OpenId, "Not authenticated (no session)" _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 14 09:04:39 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 14 Feb 2017 14:04:39 +0000 Subject: [Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o Message-ID: <1487081079.53.0.00639887245621.issue613@psf.upfronthosting.co.za> New submission from Berker Peksag: See http://bugs.python.org/issue29438#msg287733 for example. All PRs have been correctly set bpo-NNNN in the ir commit messages. ---------- messages: 3246 nosy: berker.peksag, ezio.melotti, maciej.szulik priority: bug status: unread title: Commits notifications don't show up on bugs.p.o _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 14 13:58:23 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 14 Feb 2017 18:58:23 +0000 Subject: [Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o In-Reply-To: <1487081079.53.0.00639887245621.issue613@psf.upfronthosting.co.za> Message-ID: <1487098703.81.0.854077062634.issue613@psf.upfronthosting.co.za> Berker Peksag added the comment: I got an email for http://bugs.python.org/issue29534 Mark Dickinson added the comment: New changeset 6d1dece06d13a7d40637e07b2c79f34aab368766 by Mark Dickinson in branch 'master': Fixed #29534 - _decimal difference with _pydecimal (#65) https://github.com/python/cpython/commit/6d1dece06d13a7d40637e07b2c79f34aab368766 ---------- _______________________________________ Python tracker But it doesn't show up at http://bugs.python.org/issue29534 Note that "Mark Dickinson added the comment" should be "Roundup Robot added the comment". ---------- status: unread -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 14 16:13:47 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 14 Feb 2017 21:13:47 +0000 Subject: [Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o In-Reply-To: <1487081079.53.0.00639887245621.issue613@psf.upfronthosting.co.za> Message-ID: <1487106827.47.0.35299623395.issue613@psf.upfronthosting.co.za> Berker Peksag added the comment: > Note that "Mark Dickinson added the comment" should be "Roundup Robot added the comment". Ezio told me that this was an intentional change. Sorry for the noise. Brett, is there an easy way to resend payloads so we can debug this? ---------- nosy: +brett.cannon _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 14 16:18:07 2017 From: metatracker at psf.upfronthosting.co.za (Brett C.) Date: Tue, 14 Feb 2017 21:18:07 +0000 Subject: [Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o In-Reply-To: <1487081079.53.0.00639887245621.issue613@psf.upfronthosting.co.za> Message-ID: <1487107087.37.0.061476190278.issue613@psf.upfronthosting.co.za> Brett C. added the comment: Re-sending a webhook event is easy ... if I can figure out which one to resend. :) There are tons of events going on so I need to know the delivery_id to easily find the event to resend. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 14 16:44:40 2017 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Tue, 14 Feb 2017 21:44:40 +0000 Subject: [Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o In-Reply-To: <1487081079.53.0.00639887245621.issue613@psf.upfronthosting.co.za> Message-ID: <1487108680.3.0.67809895464.issue613@psf.upfronthosting.co.za> Ezio Melotti added the comment: The commit message includes the pull request id, and it got accidentally captured by the regex that looks for issue numbers. The code doesn't check if the issue id exists, and that caused the failure. An easy fix is to add a try/except, but once we reach PR #1000 it will start matching and adding comments on old issues. This might be good enough once we figure out a better solution. Is the PR id always automatically added at the end of the commit message, between (...)? If that's the case it might be easier to strip the end of the commit message, or only match for bpo-NNNNN once everyone starts using the convention. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 14 16:48:36 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 14 Feb 2017 21:48:36 +0000 Subject: [Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o In-Reply-To: <1487081079.53.0.00639887245621.issue613@psf.upfronthosting.co.za> Message-ID: <1487108916.34.0.500240466583.issue613@psf.upfronthosting.co.za> Berker Peksag added the comment: > Is the PR id always automatically added at the end of the commit message, between (...)? Yes, but backport PRs can have titles like Fix some sphinx warnings (#9) (#81) #9 is the original PR number and #81 is the backport PR number. See: https://github.com/python/cpython/commit/9268855ba6e99bf595e75b75780cf29667371f45 _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 14 17:09:47 2017 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Tue, 14 Feb 2017 22:09:47 +0000 Subject: [Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o In-Reply-To: <1487081079.53.0.00639887245621.issue613@psf.upfronthosting.co.za> Message-ID: <1487110187.1.0.166598329219.issue613@psf.upfronthosting.co.za> Ezio Melotti added the comment: I pushed the try/except fix in https://hg.python.org/tracker/roundup/rev/1e58dddad971 I don't have a delivery_id, but the event was pushed almost 3h ago, around 19:18:56 UTC. See https://mail.python.org/pipermail/python-bugs-list/2017-February/326183.html If you can find and resend the event, we should see the message popping up in http://bugs.python.org/issue29534 otherwise we can just wait for the next push. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 14 17:15:09 2017 From: metatracker at psf.upfronthosting.co.za (Brett C.) Date: Tue, 14 Feb 2017 22:15:09 +0000 Subject: [Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o In-Reply-To: <1487081079.53.0.00639887245621.issue613@psf.upfronthosting.co.za> Message-ID: <1487110509.47.0.289235279192.issue613@psf.upfronthosting.co.za> Brett C. added the comment: It's delivery ID 6d377980-f2ea-11e6-8db5-e3e11d869c19 and a re-delivery worked! _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 14 19:39:10 2017 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Wed, 15 Feb 2017 00:39:10 +0000 Subject: [Tracker-discuss] [issue586] Add GitHub Pull Request URL on issue page In-Reply-To: <1468311341.73.0.296282421587.issue586@psf.upfronthosting.co.za> Message-ID: <1487119150.85.0.831413822809.issue586@psf.upfronthosting.co.za> Ezio Melotti added the comment: This seems to work, so I'm going to close it. ---------- status: testing -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 14 19:43:15 2017 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Wed, 15 Feb 2017 00:43:15 +0000 Subject: [Tracker-discuss] [issue589] Add GitHub PR to b.p.o issues using GitHub webhooks (depends on issue586) In-Reply-To: <1464035377.63.0.520552418309.issue589@psf.upfronthosting.co.za> Message-ID: <1487119395.82.0.294776840037.issue589@psf.upfronthosting.co.za> Ezio Melotti added the comment: I noticed that it's possible to add the same PR multiple times to the same issue, see e.g. http://bugs.python.org/issue29546 This probably happened because the payload was re-sent manually, and shouldn't otherwise be an issue, so we might not have to fix it (but feel free to do it if you want). I'm going to leave this open a while more to see if anything else comes up. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 14 20:05:49 2017 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Wed, 15 Feb 2017 01:05:49 +0000 Subject: [Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o In-Reply-To: <1487081079.53.0.00639887245621.issue613@psf.upfronthosting.co.za> Message-ID: <1487120749.75.0.589965129005.issue613@psf.upfronthosting.co.za> Ezio Melotti added the comment: ISTM that best way to fix this is to just ignore all the (#NNN) at the end of the commit message. The try/except should also stay to avoid failures in case of typos or other extraneous ids. If the commit message references other PRs directly, it might cause false positives when we reach 1000+ PRs. This is probably not going to happen very often, but, if it does, we might want to implement something smarter (e.g. avoid posting messages to issues that have been closed for over a year). ---------- status: chatting -> done-cbb _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed Feb 15 11:16:34 2017 From: metatracker at psf.upfronthosting.co.za (Maciej Szulik) Date: Wed, 15 Feb 2017 16:16:34 +0000 Subject: [Tracker-discuss] [issue589] Add GitHub PR to b.p.o issues using GitHub webhooks (depends on issue586) In-Reply-To: <1464035377.63.0.520552418309.issue589@psf.upfronthosting.co.za> Message-ID: <1487175394.92.0.776746280468.issue589@psf.upfronthosting.co.za> Maciej Szulik added the comment: I'll double check the duplication path and see what might have caused it and work on a fix. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed Feb 15 11:22:41 2017 From: metatracker at psf.upfronthosting.co.za (Maciej Szulik) Date: Wed, 15 Feb 2017 16:22:41 +0000 Subject: [Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o In-Reply-To: <1487081079.53.0.00639887245621.issue613@psf.upfronthosting.co.za> Message-ID: <1487175761.83.0.370339097928.issue613@psf.upfronthosting.co.za> Maciej Szulik added the comment: Yeah, as soon as I fix the local testing of those things I'll get back to having 4-digit requirement for bpo issues, that should additionally save us from unnecessary errors, like the one above. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Thu Feb 16 18:50:47 2017 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Thu, 16 Feb 2017 23:50:47 +0000 Subject: [Tracker-discuss] [issue589] Add GitHub PR to b.p.o issues using GitHub webhooks (depends on issue586) In-Reply-To: <1464035377.63.0.520552418309.issue589@psf.upfronthosting.co.za> Message-ID: <1487289047.44.0.151687322664.issue589@psf.upfronthosting.co.za> Ezio Melotti added the comment: Note that we check duplication when adding PRs manually to the issue, but afaik not when the PR is added by GitHub through the webhooks. I don't know if there might be cases where separate events might cause a PR to be added more than once (except for manually resend the payload like it happened in the aforementioned case). _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Feb 18 00:31:20 2017 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Sat, 18 Feb 2017 05:31:20 +0000 Subject: [Tracker-discuss] [issue614] Duplicate commit message on branch merge Message-ID: <1487395880.4.0.526142839342.issue614@psf.upfronthosting.co.za> New submission from Ezio Melotti: Nick just did a merge in https://github.com/python/cpython/pull/118 and for each merged changeset that contained a reference to bpo, a new message has been resent to the corresponding issue, see: http://bugs.python.org/msg288063 http://bugs.python.org/msg288062 http://bugs.python.org/msg288061 http://bugs.python.org/msg288060 http://bugs.python.org/msg288059 http://bugs.python.org/msg288058 (follow the bpo link in the message to see the original commit message). We should probably ignore all branches except master/3.6/3.5/etc. ---------- messages: 3260 nosy: anish.shah, brett.cannon, ezio.melotti, maciej.szulik, ncoghlan priority: bug status: unread title: Duplicate commit message on branch merge _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Feb 18 00:33:30 2017 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Sat, 18 Feb 2017 05:33:30 +0000 Subject: [Tracker-discuss] [issue614] Duplicate commit message on branch merge In-Reply-To: <1487395880.4.0.526142839342.issue614@psf.upfronthosting.co.za> Message-ID: <1487396010.92.0.585049029445.issue614@psf.upfronthosting.co.za> Ezio Melotti added the comment: See also https://github.com/python/core-workflow/issues/33 If it can be fixed on the GitHub side we can close this. ---------- status: unread -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Feb 18 00:48:03 2017 From: metatracker at psf.upfronthosting.co.za (Anish Shah) Date: Sat, 18 Feb 2017 05:48:03 +0000 Subject: [Tracker-discuss] [issue614] Duplicate commit message on branch merge In-Reply-To: <1487396010.92.0.585049029445.issue614@psf.upfronthosting.co.za> Message-ID: Anish Shah added the comment: Hi Ezio, can you tell me which webhook was triggered? Was it pull request event? _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Feb 18 00:49:12 2017 From: metatracker at psf.upfronthosting.co.za (Anish Shah) Date: Sat, 18 Feb 2017 05:49:12 +0000 Subject: [Tracker-discuss] [issue614] Duplicate commit message on branch merge In-Reply-To: Message-ID: Anish Shah added the comment: I think if we ignore other branches except master/3.6/3.5 etc, this will be solved. I can work on this. :) _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Feb 18 01:06:04 2017 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Sat, 18 Feb 2017 06:06:04 +0000 Subject: [Tracker-discuss] [issue614] Duplicate commit message on branch merge In-Reply-To: <1487395880.4.0.526142839342.issue614@psf.upfronthosting.co.za> Message-ID: <1487397964.55.0.0376814465151.issue614@psf.upfronthosting.co.za> Ezio Melotti added the comment: This should be the commit webhook that generates messages whenever a new commit includes bpo-NNNNN in the message. I'd suggest to wait a bit and see if it can be fixed from the GitHub side (i.e. if we can avoid to trigger those requests in the first place, rather than receiving them and discarding them from Roundup). _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat Feb 18 04:16:56 2017 From: metatracker at psf.upfronthosting.co.za (Nick Coghlan) Date: Sat, 18 Feb 2017 09:16:56 +0000 Subject: [Tracker-discuss] [issue614] Duplicate commit message on branch merge In-Reply-To: <1487395880.4.0.526142839342.issue614@psf.upfronthosting.co.za> Message-ID: <1487409416.47.0.786893065565.issue614@psf.upfronthosting.co.za> Nick Coghlan added the comment: I checked on a different repo where I have the ability to add webhooks, and it looks like GitHub only permits you to filter based on the *kind* of event, not on any of the values (like the branch affected). So I think this will need to be fixed on the b.p.o webhook side, and I'll close the core-workflow issue. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sun Feb 19 08:50:32 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Sun, 19 Feb 2017 13:50:32 +0000 Subject: [Tracker-discuss] [issue615] Set stage to 'patch review' when a PR is added Message-ID: <1487512232.69.0.355373365979.issue615@psf.upfronthosting.co.za> New submission from Berker Peksag: I wonder if we should be defensive and check the value of the stage field first. ---------- nosy: +berker.peksag status: unread -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sun Feb 19 23:14:54 2017 From: metatracker at psf.upfronthosting.co.za (Anish Shah) Date: Mon, 20 Feb 2017 04:14:54 +0000 Subject: [Tracker-discuss] [issue614] Duplicate commit message on branch merge In-Reply-To: <1487395880.4.0.526142839342.issue614@psf.upfronthosting.co.za> Message-ID: <1487564094.7.0.982157817461.issue614@psf.upfronthosting.co.za> Anish Shah added the comment: I have added a patch. Let me know what do you guys think! :) _______________________________________________________ PSF Meta Tracker _______________________________________________________ -------------- next part -------------- diff -r 1e58dddad971 roundup/github.py --- a/roundup/github.py Wed Feb 15 00:00:44 2017 +0200 +++ b/roundup/github.py Mon Feb 20 09:41:30 2017 +0530 @@ -18,6 +18,7 @@ URL_RE = re.compile(r'https://github.com/python/cpython/pull/(?P\d+)') VERBS = r'(?:\b(?Pclose[sd]?|closing|)\s+)?' ISSUE_RE = re.compile(r'%sbpo-(?P\d+)' % VERBS, re.I|re.U) +BRANCH_RE = re.compile(r'(2\.\d|3\.\d|master)', re.I) COMMENT_TEMPLATE = u"""\ New changeset {changeset_id} by {author} in branch '{branch}': @@ -386,6 +387,8 @@ https://hg.python.org/hooks/file/tip/hgroundup.py """ branch = ref.split('/')[-1] + if not BRANCH_RE.match(branch): + return dict() description = commit.get('message', '') matches = ISSUE_RE.finditer(description) messages = {} diff -r 1e58dddad971 test/data/pushevent.txt --- a/test/data/pushevent.txt Wed Feb 15 00:00:44 2017 +0200 +++ b/test/data/pushevent.txt Mon Feb 20 09:41:30 2017 +0530 @@ -5,7 +5,7 @@ X-GitHub-Event: push X-GitHub-Delivery: 3d4b5180-5c89-11e6-88fd-1aa99d941991 content-type: application/json -X-Hub-Signature: sha1=17986b73f55e476921481f99de2cce92c69ff05e -Content-Length: 5851 +X-Hub-Signature: sha1=20226d9d4666d07fc839c10b210cf15eefdd7ef2 +Content-Length: 5852 -{"ref":"refs/heads/test1","before":"6c5d08240c73014f282bc7336c08fe9ec0b557b0","after":"65c3a074262662a2c55109ff9a2456ee7647fcc9","created":false,"deleted":false,"forced":false,"base_ref":null,"compare":"https://github.com/python/cpython/compare/6c5d08240c73...65c3a0742626","commits":[{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"bpo-1: fix tests.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]}],"head_commit":{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"Fixes#1","timestamp":"2017-01-19T22:19:07+01:00","url":"https://gi thub.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},"repository":{"id":76687672,"name":"cpython","full_name":"python/cpython","owner":{"name":"python"},"private":false,"html_url":"https://github.com/python/cpython","description":"Semi-officialread-onlymirroroftheCPythonMercurialrepository","fork":true,"url":"https://github.com/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/ python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/s ubscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/r epos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":1481924711,"updated_at":"2016-12-16T21:45:35Z","pushed_at":1484860759,"git_url":"git://github.com/python/cpython.git","ssh_url":"git at github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"","size":269743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","stargazers":0,"master_branch":"master"},"pusher":{"name":" soltysh","email":"soltysh at gmail.com"},"sender":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}} +{"ref":"refs/heads/master","before":"6c5d08240c73014f282bc7336c08fe9ec0b557b0","after":"65c3a074262662a2c55109ff9a2456ee7647fcc9","created":false,"deleted":false,"forced":false,"base_ref":null,"compare":"https://github.com/python/cpython/compare/6c5d08240c73...65c3a0742626","commits":[{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"bpo-1: fix tests.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]}],"head_commit":{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"Fixes#1","timestamp":"2017-01-19T22:19:07+01:00","url":"https://g ithub.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},"repository":{"id":76687672,"name":"cpython","full_name":"python/cpython","owner":{"name":"python"},"private":false,"html_url":"https://github.com/python/cpython","description":"Semi-officialread-onlymirroroftheCPythonMercurialrepository","fork":true,"url":"https://github.com/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos /python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/ subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/ repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":1481924711,"updated_at":"2016-12-16T21:45:35Z","pushed_at":1484860759,"git_url":"git://github.com/python/cpython.git","ssh_url":"git at github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"","size":269743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","stargazers":0,"master_branch":"master"},"pusher":{"name": "soltysh","email":"soltysh at gmail.com"},"sender":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}} diff -r 1e58dddad971 test/data/pushevent1.txt --- a/test/data/pushevent1.txt Wed Feb 15 00:00:44 2017 +0200 +++ b/test/data/pushevent1.txt Mon Feb 20 09:41:30 2017 +0530 @@ -5,7 +5,7 @@ X-GitHub-Event: push X-GitHub-Delivery: 3d4b5180-5c89-11e6-88fd-1aa99d941991 content-type: application/json -X-Hub-Signature: sha1=4a5dd11e56f7cecb873a1be22c622ec96fd995e8 -Content-Length: 5858 +X-Hub-Signature: sha1=a0ae30a6ae1ae1ae63b0faee643e66b267c371a2 +Content-Length: 5859 -{"ref":"refs/heads/test1","before":"6c5d08240c73014f282bc7336c08fe9ec0b557b0","after":"65c3a074262662a2c55109ff9a2456ee7647fcc9","created":false,"deleted":false,"forced":false,"base_ref":null,"compare":"https://github.com/python/cpython/compare/6c5d08240c73...65c3a0742626","commits":[{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"closes bpo-1: fix tests.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]}],"head_commit":{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"Fixes#1","timestamp":"2017-01-19T22:19:07+01:00","url":"htt ps://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},"repository":{"id":76687672,"name":"cpython","full_name":"python/cpython","owner":{"name":"python"},"private":false,"html_url":"https://github.com/python/cpython","description":"Semi-officialread-onlymirroroftheCPythonMercurialrepository","fork":true,"url":"https://github.com/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com /repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cp ython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.githu b.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":1481924711,"updated_at":"2016-12-16T21:45:35Z","pushed_at":1484860759,"git_url":"git://github.com/python/cpython.git","ssh_url":"git at github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"","size":269743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","stargazers":0,"master_branch":"master"},"pusher":{" name":"soltysh","email":"soltysh at gmail.com"},"sender":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}} +{"ref":"refs/heads/master","before":"6c5d08240c73014f282bc7336c08fe9ec0b557b0","after":"65c3a074262662a2c55109ff9a2456ee7647fcc9","created":false,"deleted":false,"forced":false,"base_ref":null,"compare":"https://github.com/python/cpython/compare/6c5d08240c73...65c3a0742626","commits":[{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"closes bpo-1: fix tests.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]}],"head_commit":{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"Fixes#1","timestamp":"2017-01-19T22:19:07+01:00","url":"ht tps://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},"repository":{"id":76687672,"name":"cpython","full_name":"python/cpython","owner":{"name":"python"},"private":false,"html_url":"https://github.com/python/cpython","description":"Semi-officialread-onlymirroroftheCPythonMercurialrepository","fork":true,"url":"https://github.com/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.co m/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/c python/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.gith ub.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":1481924711,"updated_at":"2016-12-16T21:45:35Z","pushed_at":1484860759,"git_url":"git://github.com/python/cpython.git","ssh_url":"git at github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"","size":269743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","stargazers":0,"master_branch":"master"},"pusher":{ "name":"soltysh","email":"soltysh at gmail.com"},"sender":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}} diff -r 1e58dddad971 test/data/pushevent2.txt --- a/test/data/pushevent2.txt Wed Feb 15 00:00:44 2017 +0200 +++ b/test/data/pushevent2.txt Mon Feb 20 09:41:30 2017 +0530 @@ -5,7 +5,7 @@ X-GitHub-Event: push X-GitHub-Delivery: 3d4b5180-5c89-11e6-88fd-1aa99d941991 content-type: application/json -X-Hub-Signature: sha1=3c45a0ecabfe5ca39201fbacb849e5bf083e12b9 -Content-Length: 6348 +X-Hub-Signature: sha1=db83b9f5e0337b68879854cda4e59cdc69a17915 +Content-Length: 6346 -{"ref":"refs/heads/test1","before":"6c5d08240c73014f282bc7336c08fe9ec0b557b0","after":"65c3a074262662a2c55109ff9a2456ee7647fcc9","created":false,"deleted":false,"forced":false,"base_ref":null,"compare":"https://github.com/python/cpython/compare/6c5d08240c73...65c3a0742626","commits":[{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"bpo-1: fix tests.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},{"id":"4488ebcdf2d16393d1a78c4105e4a18e4d0d77af","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"bpo-1: fix else.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.c om/python/cpython/commit/4488ebcdf2d16393d1a78c4105e4a18e4d0d77af","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]}],"head_commit":{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"Fixes bpo-1","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},"repository":{"id":76687672,"name":"cpython","full_name":"python/cpython","owner":{"name":"python"},"private":false,"html_url":"https://github.com/python/cpython","description":"Semi-officialread-onlymir roroftheCPythonMercurialrepository","fork":true,"url":"https://github.com/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"h ttps://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path} ","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":1481924711,"updated_at":"2016-12-16T21:45:35Z","pushed_at":1484860759,"git_url":"git://github.com/python/cpy thon.git","ssh_url":"git at github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"","size":269743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","stargazers":0,"master_branch":"master"},"pusher":{"name":"soltysh","email":"soltysh at gmail.com"},"sender":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.co m/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}} +{"ref":"refs/heads/2.7","before":"6c5d08240c73014f282bc7336c08fe9ec0b557b0","after":"65c3a074262662a2c55109ff9a2456ee7647fcc9","created":false,"deleted":false,"forced":false,"base_ref":null,"compare":"https://github.com/python/cpython/compare/6c5d08240c73...65c3a0742626","commits":[{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"bpo-1: fix tests.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},{"id":"4488ebcdf2d16393d1a78c4105e4a18e4d0d77af","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"bpo-1: fix else.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com /python/cpython/commit/4488ebcdf2d16393d1a78c4105e4a18e4d0d77af","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]}],"head_commit":{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"Fixes bpo-1","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},"repository":{"id":76687672,"name":"cpython","full_name":"python/cpython","owner":{"name":"python"},"private":false,"html_url":"https://github.com/python/cpython","description":"Semi-officialread-onlymirro roftheCPythonMercurialrepository","fork":true,"url":"https://github.com/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"htt ps://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}", "compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":1481924711,"updated_at":"2016-12-16T21:45:35Z","pushed_at":1484860759,"git_url":"git://github.com/python/cpyth on.git","ssh_url":"git at github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"","size":269743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","stargazers":0,"master_branch":"master"},"pusher":{"name":"soltysh","email":"soltysh at gmail.com"},"sender":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/ users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}} diff -r 1e58dddad971 test/data/pushevent3.txt --- a/test/data/pushevent3.txt Wed Feb 15 00:00:44 2017 +0200 +++ b/test/data/pushevent3.txt Mon Feb 20 09:41:30 2017 +0530 @@ -5,7 +5,7 @@ X-GitHub-Event: push X-GitHub-Delivery: 3d4b5180-5c89-11e6-88fd-1aa99d941991 content-type: application/json -X-Hub-Signature: sha1=8883c17012d2e3c8847aaba628ee6ddd41418df1 -Content-Length: 6352 +X-Hub-Signature: sha1=c9aa3d142baf2141ec0666fcfe6f60c305ce1077 +Content-Length: 6350 -{"ref":"refs/heads/test1","before":"6c5d08240c73014f282bc7336c08fe9ec0b557b0","after":"65c3a074262662a2c55109ff9a2456ee7647fcc9","created":false,"deleted":false,"forced":false,"base_ref":null,"compare":"https://github.com/python/cpython/compare/6c5d08240c73...65c3a0742626","commits":[{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"closing bpo-1: fix tests.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},{"id":"4488ebcdf2d16393d1a78c4105e4a18e4d0d77af","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"bpo-1: fix else.","timestamp":"2017-01-19T22:19:07+01:00","url":"https:// github.com/python/cpython/commit/4488ebcdf2d16393d1a78c4105e4a18e4d0d77af","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]}],"head_commit":{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"Fixes#1","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},"repository":{"id":76687672,"name":"cpython","full_name":"python/cpython","owner":{"name":"python"},"private":false,"html_url":"https://github.com/python/cpython","description":"Semi-officialread-onl ymirroroftheCPythonMercurialrepository","fork":true,"url":"https://github.com/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url ":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+p ath}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":1481924711,"updated_at":"2016-12-16T21:45:35Z","pushed_at":1484860759,"git_url":"git://github.com/python /cpython.git","ssh_url":"git at github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"","size":269743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","stargazers":0,"master_branch":"master"},"pusher":{"name":"soltysh","email":"soltysh at gmail.com"},"sender":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.githu b.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}} +{"ref":"refs/heads/3.5","before":"6c5d08240c73014f282bc7336c08fe9ec0b557b0","after":"65c3a074262662a2c55109ff9a2456ee7647fcc9","created":false,"deleted":false,"forced":false,"base_ref":null,"compare":"https://github.com/python/cpython/compare/6c5d08240c73...65c3a0742626","commits":[{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"closing bpo-1: fix tests.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},{"id":"4488ebcdf2d16393d1a78c4105e4a18e4d0d77af","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"bpo-1: fix else.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://gi thub.com/python/cpython/commit/4488ebcdf2d16393d1a78c4105e4a18e4d0d77af","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]}],"head_commit":{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"Fixes#1","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},"repository":{"id":76687672,"name":"cpython","full_name":"python/cpython","owner":{"name":"python"},"private":false,"html_url":"https://github.com/python/cpython","description":"Semi-officialread-onlym irroroftheCPythonMercurialrepository","fork":true,"url":"https://github.com/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url": "https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+pat h}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":1481924711,"updated_at":"2016-12-16T21:45:35Z","pushed_at":1484860759,"git_url":"git://github.com/python/c python.git","ssh_url":"git at github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"","size":269743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","stargazers":0,"master_branch":"master"},"pusher":{"name":"soltysh","email":"soltysh at gmail.com"},"sender":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github. com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}} diff -r 1e58dddad971 test/data/pushevent4.txt --- a/test/data/pushevent4.txt Wed Feb 15 00:00:44 2017 +0200 +++ b/test/data/pushevent4.txt Mon Feb 20 09:41:30 2017 +0530 @@ -5,7 +5,7 @@ X-GitHub-Event: push X-GitHub-Delivery: 3d4b5180-5c89-11e6-88fd-1aa99d941991 content-type: application/json -X-Hub-Signature: sha1=0b5370ee3cbc50d9cc4a5e9dcfea22282d694f22 -Content-Length: 6351 +X-Hub-Signature: sha1=1e1cc1e1b5a49583b978b6d543c01a080707f730 +Content-Length: 6349 -{"ref":"refs/heads/test1","before":"6c5d08240c73014f282bc7336c08fe9ec0b557b0","after":"65c3a074262662a2c55109ff9a2456ee7647fcc9","created":false,"deleted":false,"forced":false,"base_ref":null,"compare":"https://github.com/python/cpython/compare/6c5d08240c73...65c3a0742626","commits":[{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"closes bpo-1: fix tests.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},{"id":"4488ebcdf2d16393d1a78c4105e4a18e4d0d77af","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"bpo-2: fix else.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://g ithub.com/python/cpython/commit/4488ebcdf2d16393d1a78c4105e4a18e4d0d77af","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]}],"head_commit":{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"Fixes#1","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},"repository":{"id":76687672,"name":"cpython","full_name":"python/cpython","owner":{"name":"python"},"private":false,"html_url":"https://github.com/python/cpython","description":"Semi-officialread-only mirroroftheCPythonMercurialrepository","fork":true,"url":"https://github.com/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url" :"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+pa th}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":1481924711,"updated_at":"2016-12-16T21:45:35Z","pushed_at":1484860759,"git_url":"git://github.com/python/ cpython.git","ssh_url":"git at github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"","size":269743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","stargazers":0,"master_branch":"master"},"pusher":{"name":"soltysh","email":"soltysh at gmail.com"},"sender":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github .com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}} +{"ref":"refs/heads/3.6","before":"6c5d08240c73014f282bc7336c08fe9ec0b557b0","after":"65c3a074262662a2c55109ff9a2456ee7647fcc9","created":false,"deleted":false,"forced":false,"base_ref":null,"compare":"https://github.com/python/cpython/compare/6c5d08240c73...65c3a0742626","commits":[{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"closes bpo-1: fix tests.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},{"id":"4488ebcdf2d16393d1a78c4105e4a18e4d0d77af","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"bpo-2: fix else.","timestamp":"2017-01-19T22:19:07+01:00","url":"https://git hub.com/python/cpython/commit/4488ebcdf2d16393d1a78c4105e4a18e4d0d77af","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]}],"head_commit":{"id":"65c3a074262662a2c55109ff9a2456ee7647fcc9","tree_id":"2a35adbb6fce03b51dce23b4ed48526a5a74255a","distinct":true,"message":"Fixes#1","timestamp":"2017-01-19T22:19:07+01:00","url":"https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9","author":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"committer":{"name":"Maciej Szulik","email":"soltysh at gmail.com","username":"soltysh"},"added":[],"removed":[],"modified":["README"]},"repository":{"id":76687672,"name":"cpython","full_name":"python/cpython","owner":{"name":"python"},"private":false,"html_url":"https://github.com/python/cpython","description":"Semi-officialread-onlymi rroroftheCPythonMercurialrepository","fork":true,"url":"https://github.com/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":" https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path }","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":1481924711,"updated_at":"2016-12-16T21:45:35Z","pushed_at":1484860759,"git_url":"git://github.com/python/cp ython.git","ssh_url":"git at github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"","size":269743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","stargazers":0,"master_branch":"master"},"pusher":{"name":"soltysh","email":"soltysh at gmail.com"},"sender":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.c om/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}} diff -r 1e58dddad971 test/test_github.py --- a/test/test_github.py Wed Feb 15 00:00:44 2017 +0200 +++ b/test/test_github.py Mon Feb 20 09:41:30 2017 +0530 @@ -292,7 +292,7 @@ msgs = self.db.issue.get('1', 'messages') self.assertEqual(len(msgs), 1) content = self.db.msg.get(msgs[0], 'content') - self.assertIn("""New changeset 65c3a074262662a2c55109ff9a2456ee7647fcc9 by Maciej Szulik in branch 'test1': + self.assertIn("""New changeset 65c3a074262662a2c55109ff9a2456ee7647fcc9 by Maciej Szulik in branch 'master': bpo-1: fix tests. https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9 """, @@ -312,7 +312,7 @@ msgs = self.db.issue.get('1', 'messages') self.assertEqual(len(msgs), 1) content = self.db.msg.get(msgs[0], 'content') - self.assertIn("""New changeset 65c3a074262662a2c55109ff9a2456ee7647fcc9 by Maciej Szulik in branch 'test1': + self.assertIn("""New changeset 65c3a074262662a2c55109ff9a2456ee7647fcc9 by Maciej Szulik in branch 'master': closes bpo-1: fix tests. https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9 """, @@ -332,11 +332,11 @@ msgs = self.db.issue.get('1', 'messages') self.assertEqual(len(msgs), 1) content = self.db.msg.get(msgs[0], 'content') - self.assertIn("""New changeset 65c3a074262662a2c55109ff9a2456ee7647fcc9 by Maciej Szulik in branch 'test1': + self.assertIn("""New changeset 65c3a074262662a2c55109ff9a2456ee7647fcc9 by Maciej Szulik in branch '2.7': bpo-1: fix tests. https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9 -New changeset 4488ebcdf2d16393d1a78c4105e4a18e4d0d77af by Maciej Szulik in branch 'test1': +New changeset 4488ebcdf2d16393d1a78c4105e4a18e4d0d77af by Maciej Szulik in branch '2.7': bpo-1: fix else. https://github.com/python/cpython/commit/4488ebcdf2d16393d1a78c4105e4a18e4d0d77af """, @@ -354,11 +354,11 @@ msgs = self.db.issue.get('1', 'messages') self.assertEqual(len(msgs), 1) content = self.db.msg.get(msgs[0], 'content') - self.assertIn("""New changeset 65c3a074262662a2c55109ff9a2456ee7647fcc9 by Maciej Szulik in branch 'test1': + self.assertIn("""New changeset 65c3a074262662a2c55109ff9a2456ee7647fcc9 by Maciej Szulik in branch '3.5': closing bpo-1: fix tests. https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9 -New changeset 4488ebcdf2d16393d1a78c4105e4a18e4d0d77af by Maciej Szulik in branch 'test1': +New changeset 4488ebcdf2d16393d1a78c4105e4a18e4d0d77af by Maciej Szulik in branch '3.5': bpo-1: fix else. https://github.com/python/cpython/commit/4488ebcdf2d16393d1a78c4105e4a18e4d0d77af """, @@ -380,7 +380,7 @@ msgs = self.db.issue.get('1', 'messages') self.assertEqual(len(msgs), 1) content = self.db.msg.get(msgs[0], 'content') - self.assertIn("""New changeset 65c3a074262662a2c55109ff9a2456ee7647fcc9 by Maciej Szulik in branch 'test1': + self.assertIn("""New changeset 65c3a074262662a2c55109ff9a2456ee7647fcc9 by Maciej Szulik in branch '3.6': closes bpo-1: fix tests. https://github.com/python/cpython/commit/65c3a074262662a2c55109ff9a2456ee7647fcc9 """, @@ -396,7 +396,7 @@ msgs = self.db.issue.get('2', 'messages') self.assertEqual(len(msgs), 1) content = self.db.msg.get(msgs[0], 'content') - self.assertIn("""New changeset 4488ebcdf2d16393d1a78c4105e4a18e4d0d77af by Maciej Szulik in branch 'test1': + self.assertIn("""New changeset 4488ebcdf2d16393d1a78c4105e4a18e4d0d77af by Maciej Szulik in branch '3.6': bpo-2: fix else. https://github.com/python/cpython/commit/4488ebcdf2d16393d1a78c4105e4a18e4d0d77af """, @@ -407,6 +407,16 @@ self.assertIsNone(self.db.issue.get('2', 'resolution')) self.assertIsNone(self.db.issue.get('2', 'stage')) + def testPushEventForMainBranches(self): + # message should be added only if commit is pushed into master/2.x/3.x branches + dummy_client = self._make_client('pushevent5.txt') + self.db.issue.create(title="Issue 2") + handler = GitHubHandler(dummy_client) + handler.dispatch() + # first issue messages + msgs = self.db.issue.get('1', 'messages') + self.assertEqual(len(msgs), 0) + def test_suite(): suite = unittest.TestSuite() for l in list_backends(): From metatracker at psf.upfronthosting.co.za Mon Feb 20 04:07:24 2017 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Mon, 20 Feb 2017 09:07:24 +0000 Subject: [Tracker-discuss] [issue589] Add GitHub PR to b.p.o issues using GitHub webhooks (depends on issue586) In-Reply-To: <1464035377.63.0.520552418309.issue589@psf.upfronthosting.co.za> Message-ID: <1487581644.78.0.396985779647.issue589@psf.upfronthosting.co.za> Ezio Melotti added the comment: This happened again in http://bugs.python.org/issue29554 -- not sure if someone was playing with the payloads or if something else triggered the duplication. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon Feb 20 04:10:11 2017 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Mon, 20 Feb 2017 09:10:11 +0000 Subject: [Tracker-discuss] [issue615] Set stage to 'patch review' when a PR is added In-Reply-To: <1487512232.69.0.355373365979.issue615@psf.upfronthosting.co.za> Message-ID: <1487581811.69.0.553331235426.issue615@psf.upfronthosting.co.za> Ezio Melotti added the comment: I think the patch is fine, but if we are going to update the stage when a PR is added through the webhooks, perhaps we should do it also when it's added manually. ---------- status: chatting -> unread _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon Feb 20 19:55:54 2017 From: metatracker at psf.upfronthosting.co.za (Paul Schreiber) Date: Tue, 21 Feb 2017 00:55:54 +0000 Subject: [Tracker-discuss] [issue616] Allow login to bugs.python.org with Google account Message-ID: <1487638554.22.0.157184955015.issue616@psf.upfronthosting.co.za> New submission from Paul Schreiber: Originally filed as http://bugs.python.org/issue29544 I created a standard account on bugs.python.org with username paulschreiber and email address paulschreiber at gmail.com. Later, I attempted to log in to bugs.python.org using Google and was shown an error message: There is already an account for paulschreiber at gmail.com Instead of showing me the error message, I should have been logged in. ---------- messages: 3270 nosy: paulschreiber priority: feature status: unread title: Allow login to bugs.python.org with Google account _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon Feb 20 19:57:13 2017 From: metatracker at psf.upfronthosting.co.za (Paul Schreiber) Date: Tue, 21 Feb 2017 00:57:13 +0000 Subject: [Tracker-discuss] [issue617] Logging in to bugs.python.org with email address fails Message-ID: <1487638633.91.0.556036936497.issue617@psf.upfronthosting.co.za> New submission from Paul Schreiber: Allow users to log in to bugs.python.org with their email address in the username field. Currently, this fails with an "Invalid login" error. ---------- messages: 3271 nosy: paulschreiber priority: bug status: unread title: Logging in to bugs.python.org with email address fails _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon Feb 20 21:26:32 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 21 Feb 2017 02:26:32 +0000 Subject: [Tracker-discuss] [issue618] Allow developers to edit and unlink pull requests Message-ID: <1487643992.3.0.880082111082.issue618@psf.upfronthosting.co.za> New submission from Berker Peksag: I noticed that developer cannot edit or unlink pull requests. The attached patch should fix this. ---------- messages: 3272 nosy: berker.peksag, ezio.melotti priority: bug status: unread title: Allow developers to edit and unlink pull requests _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon Feb 20 21:39:36 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Tue, 21 Feb 2017 02:39:36 +0000 Subject: [Tracker-discuss] [issue618] Allow developers to edit and unlink pull requests In-Reply-To: <1487643992.3.0.880082111082.issue618@psf.upfronthosting.co.za> Message-ID: <1487644776.84.0.56070714646.issue618@psf.upfronthosting.co.za> Berker Peksag added the comment: Ezio gave his LGTM on #python-dev and I applied the patch in https://hg.python.org/tracker/python-dev/rev/545a7d7ef9e4. ---------- status: unread -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 21 02:52:30 2017 From: metatracker at psf.upfronthosting.co.za (Maciej Szulik) Date: Tue, 21 Feb 2017 07:52:30 +0000 Subject: [Tracker-discuss] [issue614] Duplicate commit message on branch merge In-Reply-To: <1487395880.4.0.526142839342.issue614@psf.upfronthosting.co.za> Message-ID: <1487663550.88.0.801405658328.issue614@psf.upfronthosting.co.za> Maciej Szulik added the comment: Anish thanks! I had to tweak the patch a bit (just tests), since you forgot to include pushevent5.txt, but I've created it manually :) The change was pushed in https://hg.python.org/tracker/roundup/rev/3050f361cf3e ---------- status: chatting -> testing _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 21 03:00:08 2017 From: metatracker at psf.upfronthosting.co.za (Maciej Szulik) Date: Tue, 21 Feb 2017 08:00:08 +0000 Subject: [Tracker-discuss] [issue615] Set stage to 'patch review' when a PR is added In-Reply-To: <1487512232.69.0.355373365979.issue615@psf.upfronthosting.co.za> Message-ID: <1487664008.09.0.937785541754.issue615@psf.upfronthosting.co.za> Maciej Szulik added the comment: Yes and no. In majority of cases this is true, adding a patch to an issue will solve it and makes sense to move to patch review. But sometimes that single patch might hide the fact that the issue still needs resolution. So I'm not sure about the direction here, but I won't block doing this, just voicing my concerns ;) But most importantly I agree with Ezio, about being consistent setting the status when manually adding PR. But in that case it would be easier to create a detector in python-dev which would do just that. Similarly how we set status in https://hg.python.org/tracker/python-dev/file/tip/detectors/setresolved.py ---------- status: unread -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 21 21:11:59 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Wed, 22 Feb 2017 02:11:59 +0000 Subject: [Tracker-discuss] [issue619] Use author's name if committer is set to GitHub on commit notifications Message-ID: <1487729519.58.0.259472313196.issue619@psf.upfronthosting.co.za> New submission from Berker Peksag: New changeset 6336f0d156feec0f109a8d01da108cf96e3d9c60 by GitHub in branch '3.5': bpo-29554: Improve docs for pstat module and profile. (#88) (#228) https://github.com/python/cpython/commit/6336f0d156feec0f109a8d01da108cf96e3d9c60 I think we should use author's name on this case. I will attach a patch later today. ---------- messages: 3276 nosy: berker.peksag, ezio.melotti priority: bug status: unread title: Use author's name if committer is set to GitHub on commit notifications _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue Feb 21 22:15:12 2017 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Wed, 22 Feb 2017 03:15:12 +0000 Subject: [Tracker-discuss] [issue587] Link GitHub pull requests in comments In-Reply-To: <1468870442.58.0.0827952665631.issue587@psf.upfronthosting.co.za> Message-ID: <1487733312.47.0.405173397477.issue587@psf.upfronthosting.co.za> Ezio Melotti added the comment: I added the title and status to the link in https://hg.python.org/tracker/python-dev/rev/38de93af8c3d This only works if the info is already available in Roundup (currently they should only get set when a PR is added/updated by a webhook). _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon Feb 27 09:04:03 2017 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Mon, 27 Feb 2017 14:04:03 +0000 Subject: [Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o In-Reply-To: <1487081079.53.0.00639887245621.issue613@psf.upfronthosting.co.za> Message-ID: <1488204243.67.0.36138947267.issue613@psf.upfronthosting.co.za> Berker Peksag added the comment: I can reproduce this again, reopening. ---------- status: done-cbb -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________