File display - <span + i18n:name="tracker" tal:replace="config/TRACKER

From witten at alum.mit.edu Thu Nov 10 13:26:38 2016 From: witten at alum.mit.edu (Michael Witten) Date: Thu, 10 Nov 2016 18:26:38 -0000 Subject: [Tracker-discuss] Reviving a [mostly] dead account Message-ID: <9ea85e2d31c8425eabddc76e7c9de785-witten@alum.mit.edu> I suspect that this email is inappropriate for this list, yet I am unaware of a forum that would be more appropriate. In short, I registered the account `mfwitten' on Wed, 22 Oct 2008, at approximately 19:44:02 -0000; I still have the registration email, including the `key', if that matters. This account is associated with the following email address: mfwitten at mit.edu Alas, I have not had access to that email address for a very long time indeed, and even if I have managed to remember the password for my tracker account, it may have been obliterated when the system was told that I had forgotten my password. If possible, I would like to have the `mfwitten' account's primary email address reset to the one on this email, namely: witten at alum.mit.edu Alternatively, it would probably be enough to have the password-reset email sent to that address, so that I may configure things on my own. Thanks for you help, Michael Witten From ezio.melotti at gmail.com Thu Nov 10 13:43:28 2016 From: ezio.melotti at gmail.com (Ezio Melotti) Date: Thu, 10 Nov 2016 19:43:28 +0100 Subject: [Tracker-discuss] Reviving a [mostly] dead account In-Reply-To: <9ea85e2d31c8425eabddc76e7c9de785-witten@alum.mit.edu> References: <9ea85e2d31c8425eabddc76e7c9de785-witten@alum.mit.edu> Message-ID: I updated the email address. Let me know if it works. Best Regards, Ezio Melotti On Thu, Nov 10, 2016 at 7:26 PM, Michael Witten wrote: > I suspect that this email is inappropriate for this list, yet I am > unaware of a forum that would be more appropriate. > > In short, I registered the account `mfwitten' on Wed, 22 Oct 2008, at > approximately 19:44:02 -0000; I still have the registration email, > including the `key', if that matters. This account is associated with > the following email address: > > mfwitten at mit.edu > > Alas, I have not had access to that email address for a very long time > indeed, and even if I have managed to remember the password for my > tracker account, it may have been obliterated when the system was told > that I had forgotten my password. > > If possible, I would like to have the `mfwitten' account's primary email > address reset to the one on this email, namely: > > witten at alum.mit.edu > > Alternatively, it would probably be enough to have the password-reset email > sent to that address, so that I may configure things on my own. > > Thanks for you help, > Michael Witten > _______________________________________________ > Tracker-discuss mailing list > Tracker-discuss at python.org > https://mail.python.org/mailman/listinfo/tracker-discuss > Code of Conduct: https://www.python.org/psf/codeofconduct/ From witten at alum.mit.edu Thu Nov 10 14:40:45 2016 From: witten at alum.mit.edu (Michael Witten) Date: Thu, 10 Nov 2016 19:40:45 -0000 Subject: [Tracker-discuss] Reviving a [mostly] dead account In-Reply-To: References: <9ea85e2d31c8425eabddc76e7c9de785-witten@alum.mit.edu> Message-ID: <129685d61072407da64df36e1b8aa5bd-witten@alum.mit.edu> On Thu, 10 Nov 2016 19:43:28 +0100, Ezio Melotti wrote: > On Thu, Nov 10, 2016 at 7:26 PM, Michael Witten wrote: > >> If possible, I would like to have the `mfwitten' account's primary email >> address reset to the one on this email, namely: >> >> witten at alum.mit.edu >> >> ... > > I updated the email address. > Let me know if it works. Thank you kindly! That did the trick. From metatracker at psf.upfronthosting.co.za Wed Nov 16 15:03:47 2016 From: metatracker at psf.upfronthosting.co.za (Jim Nasby) Date: Wed, 16 Nov 2016 20:03:47 +0000 Subject: [Tracker-discuss] [issue608] Unable to associate additional Google OpenID (python bug tracker) Message-ID: <1479326627.53.0.383405708557.issue608@psf.upfronthosting.co.za> New submission from Jim Nasby: After logging into the python bug tracker and hitting "Your Details", I'm trying to associate another Google OpenID with my account, but the Associate box provides zero information on how to do this. I've attempted to use my gmail email address as well as https://accounts.google.com/{google account number}, neither of which worked. ---------- messages: 3190 nosy: Jim Nasby priority: bug status: unread title: Unable to associate additional Google OpenID (python bug tracker) _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Fri Nov 18 03:34:56 2016 From: metatracker at psf.upfronthosting.co.za (Berker Peksag) Date: Fri, 18 Nov 2016 08:34:56 +0000 Subject: [Tracker-discuss] [issue594] Fix ImportError: cannot import name rndstr in oic_login.py In-Reply-To: <1465452688.2.0.953419813695.issue594@psf.upfronthosting.co.za> Message-ID: <1479458096.91.0.112900011951.issue594@psf.upfronthosting.co.za> Berker Peksag added the comment: The patch also helped Ezio so I just committed it in https://hg.python.org/tracker/python-dev/rev/46237fce3bfe and pinged him. ---------- status: unread -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sun Nov 20 08:35:23 2016 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Sun, 20 Nov 2016 13:35:23 +0000 Subject: [Tracker-discuss] [issue586] Add GitHub Pull Request URL on issue page In-Reply-To: <1468311341.73.0.296282421587.issue586@psf.upfronthosting.co.za> Message-ID: <1479648923.34.0.937518681159.issue586@psf.upfronthosting.co.za> Ezio Melotti added the comment: I've looked at the latest patch (2016-07-21.16:13:52) and the only major issue I've found so far is that any user can unlink (remove) any PR, even the ones created by other users. This is likely because of wrong permissions in schema.py. There are also a few minor low-priority issues and feature requests that can be addressed later: 1) it's possible to add the same PR multiple times to the same issue (I also tested with http/https). 2) it would be good to support the username/repo#pr_num syntax, perhaps even just the PR number and default on the CPython repo; 3) I would prefer the "remove" button to be on the pull_request page. This will make it consistent with the files (they have an "unlink" button), avoid unnecessary clutter, and prevent accidental removal of linked PRs; 4) all the i18n:translate="" can be removed; 5) the "Author" column might be misleading, since it refers to whoever linked the PR, not the author of the PR. ---------- nosy: +ezio.melotti _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon Nov 21 18:21:18 2016 From: metatracker at psf.upfronthosting.co.za (Maciej Szulik) Date: Mon, 21 Nov 2016 23:21:18 +0000 Subject: [Tracker-discuss] [issue586] Add GitHub Pull Request URL on issue page In-Reply-To: <1468311341.73.0.296282421587.issue586@psf.upfronthosting.co.za> Message-ID: <1479770478.69.0.970694470227.issue586@psf.upfronthosting.co.za> Maciej Szulik added the comment: Addressed 1, 2, 4, 5. I'll handle 3rd along with title as a followup issue. _______________________________________________________ PSF Meta Tracker _______________________________________________________ -------------- next part -------------- diff --git a/detectors/pull_request.py b/detectors/pull_request.py new file mode 100644 --- /dev/null +++ b/detectors/pull_request.py @@ -0,0 +1,49 @@ +# Auditor for GitHub URLs +# Check if it is a valid GitHub Pull Request URL and extract PR number + +import re +import urlparse + + +def validate_pull_requests(db, cl, nodeid, newvalues): + newprs = set(newvalues.get('pull_requests',())) + oldprs = set() + if nodeid: + oldprs = set(db.issue.get(nodeid, 'pull_requests')) + newprs -= oldprs + newurl = '' + for prid in newprs: + newurl = parse_url(db.pull_request.get(prid, 'url')) + if newurl != '': + for prid in oldprs: + if newurl == db.pull_request.get(prid, 'url'): + raise ValueError("GitHub PR already added to issue") + +def validate_url(db, cl, nodeid, newvalues): + newurl = parse_url(newvalues.get('url', '')) + if newurl != '': + newvalues['url'] = newurl + # TODO: read PR title here + +def parse_url(url): + if url == '': + return + # TODO: transform following forms: + # - username/repo#prno + # - repo/#prno + parsed_url = urlparse.urlparse(url) + if parsed_url.scheme == '': + url = 'https://' + url + parsed_url = urlparse.urlparse(url) + if parsed_url.scheme not in ('http', 'https'): + raise ValueError("Invalid URL scheme in GitHub PR") + if 'github.com' not in parsed_url.netloc or 'pull' not in parsed_url.path: + raise ValueError("Invalid GitHub PR") + return parsed_url.geturl().strip('/') + + +def init(db): + db.issue.audit('create', validate_pull_requests) + db.issue.audit('set', validate_pull_requests) + db.pull_request.audit('create', validate_url) + db.pull_request.audit('set', validate_url) diff --git a/html/issue.item.html b/html/issue.item.html --- a/html/issue.item.html +++ b/html/issue.item.html @@ -220,6 +220,14 @@ + + GitHub PR: + + + + + + @@ -273,6 +281,31 @@

+ + + + + + + + + + + + +

Pull Requests
URL	Linked	Edit
+ + URL + +	+ creator's name, + creation date +	+ edit +

diff --git a/html/pull_request.item.html b/html/pull_request.item.html new file mode 100644 --- /dev/null +++ b/html/pull_request.item.html @@ -0,0 +1,72 @@ + +File display - +Pull Request + + + +

+ You are not allowed to view this page.

+ +

+ Please login with your username and password.

URL
Title
+ + + + +	submit button here

+ + + +

+ File has been classified as spam.

+ +

+ + + +

This PR is linked to : +

+ + + +

This PR has been unlinked from : +

+ + + + + + + + + diff --git a/schema.py b/schema.py --- a/schema.py +++ b/schema.py @@ -173,6 +173,11 @@ patchbranch=String(), ) +pull_request = Class(db, "pull_request", + url=String(), + title=String(), + ) + # IssueClass automatically gets these properties in addition to the Class ones: # title = String() # messages = Multilink("msg") @@ -194,7 +199,8 @@ stage=Link('stage'), nosy_count=Number(), message_count=Number(), - hgrepos=Multilink('hgrepo')) + hgrepos=Multilink('hgrepo'), + pull_requests=Multilink('pull_request')) # # TRACKER SECURITY SETTINGS @@ -222,7 +228,7 @@ for cl in ('issue_type', 'severity', 'component', 'version', 'priority', 'stage', 'status', 'resolution', - 'issue', 'keyword', 'hgrepo'): + 'issue', 'keyword', 'hgrepo', 'pull_request'): db.security.addPermissionToRole('User', 'View', cl) db.security.addPermissionToRole('Anonymous', 'View', cl) @@ -233,6 +239,13 @@ properties=['url', 'patchbranch']) db.security.addPermissionToRole('User', p) +def may_edit_pull_request(db, userid, itemid): + return userid == db.pull_request.get(itemid, "creator") +db.security.addPermissionToRole('User', 'Create', 'pull_request') +p = db.security.addPermission(name='Edit', klass='pull_request', + check=may_edit_pull_request, properties=['url', 'title']) +db.security.addPermissionToRole('User', p) + class may_view_spam: def __init__(self, klassname): self.klassname = klassname @@ -292,7 +305,7 @@ properties=('title', 'type', 'components', 'versions', 'severity', - 'messages', 'files', 'nosy', 'hgrepos'), + 'messages', 'files', 'nosy', 'hgrepos', 'pull_requests'), description='User can report and discuss issues') db.security.addPermissionToRole('User', p) @@ -300,7 +313,7 @@ properties=('title', 'type', 'components', 'versions', 'severity', - 'messages', 'files', 'nosy', 'hgrepos'), + 'messages', 'files', 'nosy', 'hgrepos', 'pull_requests'), description='User can report and discuss issues') db.security.addPermissionToRole('User', p) @@ -335,7 +348,7 @@ ########################## for cl in ('issue_type', 'severity', 'component', 'version', 'priority', 'stage', 'status', 'resolution', 'issue', - 'file', 'msg', 'hgrepo'): + 'file', 'msg', 'hgrepo', 'pull_request'): db.security.addPermissionToRole('Coordinator', 'View', cl) db.security.addPermissionToRole('Coordinator', 'Edit', cl) db.security.addPermissionToRole('Coordinator', 'Create', cl) From metatracker at psf.upfronthosting.co.za Mon Nov 21 19:12:14 2016 From: metatracker at psf.upfronthosting.co.za (Maciej Szulik) Date: Tue, 22 Nov 2016 00:12:14 +0000 Subject: [Tracker-discuss] [issue586] Add GitHub Pull Request URL on issue page In-Reply-To: <1468311341.73.0.296282421587.issue586@psf.upfronthosting.co.za> Message-ID: <1479773534.64.0.0570846668293.issue586@psf.upfronthosting.co.za> Maciej Szulik added the comment: Apparently I can't leave title set to none, I had to explicitly set it to empty if none is set. _______________________________________________________ PSF Meta Tracker _______________________________________________________ -------------- next part -------------- diff --git a/detectors/pull_request.py b/detectors/pull_request.py new file mode 100644 --- /dev/null +++ b/detectors/pull_request.py @@ -0,0 +1,55 @@ +# Auditor for GitHub URLs +# Check if it is a valid GitHub Pull Request URL and extract PR number + +import re +import urlparse + + +def validate_pull_requests(db, cl, nodeid, newvalues): + newprs = set(newvalues.get('pull_requests',())) + oldprs = set() + if nodeid: + oldprs = set(db.issue.get(nodeid, 'pull_requests')) + newprs -= oldprs + newurl = '' + for prid in newprs: + newurl = parse_url(db.pull_request.get(prid, 'url')) + if newurl != '': + for prid in oldprs: + if newurl == db.pull_request.get(prid, 'url'): + raise ValueError("GitHub PR already added to issue") + +def validate_url(db, cl, nodeid, newvalues): + try: + newurl = parse_url(newvalues['url']) + if newurl != '': + newvalues['url'] = newurl + except KeyError: + pass + try: + newvalues['title'] + except KeyError: + newvalues['title'] = '' + +def parse_url(url): + if url == '': + return + # TODO: transform following forms: + # - username/repo#prno + # - repo/#prno + parsed_url = urlparse.urlparse(url) + if parsed_url.scheme == '': + url = 'https://' + url + parsed_url = urlparse.urlparse(url) + if parsed_url.scheme not in ('http', 'https'): + raise ValueError("Invalid URL scheme in GitHub PR") + if 'github.com' not in parsed_url.netloc or 'pull' not in parsed_url.path: + raise ValueError("Invalid GitHub PR") + return parsed_url.geturl().strip('/') + + +def init(db): + db.issue.audit('create', validate_pull_requests) + db.issue.audit('set', validate_pull_requests) + db.pull_request.audit('create', validate_url) + db.pull_request.audit('set', validate_url) diff --git a/html/issue.item.html b/html/issue.item.html --- a/html/issue.item.html +++ b/html/issue.item.html @@ -220,6 +220,14 @@ + + GitHub PR: + + + + + + @@ -273,6 +281,31 @@

+ + + + + + + + + + + + +

Pull Requests
URL	Linked	Edit
+ + URL + +	+ creator's name, + creation date +	+ edit +

diff --git a/html/pull_request.item.html b/html/pull_request.item.html new file mode 100644 --- /dev/null +++ b/html/pull_request.item.html @@ -0,0 +1,72 @@ + +Pull Request - +Pull Request + + + +

+ You are not allowed to view this page.

+ +

+ Please login with your username and password.