From metatracker at psf.upfronthosting.co.za Mon May 2 21:23:24 2011 From: metatracker at psf.upfronthosting.co.za (Steffen Daode Nurpmeso) Date: Mon, 02 May 2011 19:23:24 +0000 Subject: [Tracker-discuss] [issue397] Content is swallowed (due to too aggressive NL merging?) In-Reply-To: <1304364204.59.0.815639718869.issue397@psf.upfronthosting.co.za> Message-ID: <1304364204.59.0.815639718869.issue397@psf.upfronthosting.co.za> New submission from Steffen Daode Nurpmeso : The first time i recognized this and i've used this kind of message format multiple times in the past. A post of mine to Python issue 11935, as copied from my outbox.mbox - note i use $ instead of EOL: === The following (reduced) HFS, case sensitive (UFS?) session brings$ out the problem:$ $ $ >>> os.utime('org.python', (t-3,t))$ Access: Mon May 2 20:49:51 2011$ Modify: Mon May 2 20:49:30 2011$ === The message (http://bugs.python.org/issue11935#msg134999): === The following (reduced) HFS, case sensitive (UFS?) session brings$ out the problem:$ $ Access: Mon May 2 20:49:51 2011$ Modify: Mon May 2 20:49:30 2011$ ---------- messages: 2040 nosy: sdaoden priority: feature status: unread title: Content is swallowed (due to too aggressive NL merging?) _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon May 2 21:28:44 2011 From: metatracker at psf.upfronthosting.co.za (Steffen Daode Nurpmeso) Date: Mon, 02 May 2011 19:28:44 +0000 Subject: [Tracker-discuss] [issue397] Content is swallowed (due to too aggressive NL merging?) In-Reply-To: <1304364204.59.0.815639718869.issue397@psf.upfronthosting.co.za> Message-ID: <1304364524.22.0.927101230929.issue397@psf.upfronthosting.co.za> Steffen Daode Nurpmeso added the comment: Oh - i see now that the line which disappeared actually starts with the Python prompt - is this treated special as in rST?? Well, then this could be closed again. (Python prompts were not part of the messages i referred to.) ---------- status: unread -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon May 2 21:34:28 2011 From: metatracker at psf.upfronthosting.co.za (Steffen Daode Nurpmeso) Date: Mon, 02 May 2011 19:34:28 +0000 Subject: [Tracker-discuss] [issue397] Document that Python prompt is treated special In-Reply-To: <1304364204.59.0.815639718869.issue397@psf.upfronthosting.co.za> Message-ID: <1304364868.99.0.296527846011.issue397@psf.upfronthosting.co.za> Steffen Daode Nurpmeso added the comment: Ok, i'm now pretty sure that was the reason. Unfortunately the documentation does not indicate that. ---------- priority: feature -> wish title: Content is swallowed (due to too aggressive NL merging?) -> Document that Python prompt is treated special _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon May 2 21:38:09 2011 From: metatracker at psf.upfronthosting.co.za (Steffen Daode Nurpmeso) Date: Mon, 02 May 2011 19:38:09 +0000 Subject: [Tracker-discuss] [issue395] My mails can change the title (nothing else) In-Reply-To: <1303216130.53.0.812232423265.issue395@psf.upfronthosting.co.za> Message-ID: <1304365089.02.0.6496903891.issue395@psf.upfronthosting.co.za> Steffen Daode Nurpmeso added the comment: If i knew where i could get a repository from, i could try to write a patch which prevents reverting of the title to a former value through non [x=y] ways. Not at once, but in the nearer future. I only found a tarball yet. ---------- status: unread -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon May 2 22:04:20 2011 From: metatracker at psf.upfronthosting.co.za (R David Murray) Date: Mon, 02 May 2011 20:04:20 +0000 Subject: [Tracker-discuss] [issue395] My mails can change the title (nothing else) In-Reply-To: <1303216130.53.0.812232423265.issue395@psf.upfronthosting.co.za> Message-ID: <1304366660.29.0.870651251418.issue395@psf.upfronthosting.co.za> R David Murray added the comment: Follow the 'tracker development' link in the left hand column of bugs.python.org. ---------- nosy: +r.david.murray _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue May 3 11:36:21 2011 From: metatracker at psf.upfronthosting.co.za (Steffen Daode Nurpmeso) Date: Tue, 03 May 2011 09:36:21 +0000 Subject: [Tracker-discuss] [issue395] My mails can change the title (nothing else) In-Reply-To: <1303216130.53.0.812232423265.issue395@psf.upfronthosting.co.za> Message-ID: <1304415381.22.0.844523086845.issue395@psf.upfronthosting.co.za> Steffen Daode Nurpmeso added the comment: Many thanks for the hint. (I always ended up at sourceforge yet.) _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sun May 8 17:18:24 2011 From: metatracker at psf.upfronthosting.co.za (Ralph Corderoy) Date: Sun, 08 May 2011 15:18:24 +0000 Subject: [Tracker-discuss] [issue398] Roundup Refused Update with No text/plain In-Reply-To: <1304867904.05.0.182774765173.issue398@psf.upfronthosting.co.za> Message-ID: <1304867904.05.0.182774765173.issue398@psf.upfronthosting.co.za> New submission from Ralph Corderoy : I raised http://bugs.python.org/issue12030 and was directed to raise it here instead. I tried to reply to the email I was sent when eric.araujo added a comment to Python bug #10713. The email I sent was plain text but wasn't a MIME email. It was rejected, "Failed issue tracker submission", "Roundup requires the submission to be plain text. The message parser could not find a text/plain part to use." I understand why it looks for plain/text parts of a MIME email, but shouldn't it be happy with a non-MIME email that by definition is plain text and has only one part? I've attached the rejected email. ---------- messages: 2046 nosy: ralph.corderoy priority: bug status: unread title: Roundup Refused Update with No text/plain _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon May 16 09:09:05 2011 From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=) Date: Mon, 16 May 2011 07:09:05 +0000 Subject: [Tracker-discuss] [issue378] Merge OpenID login feature upstream In-Reply-To: <1299181785.42.0.0532278744857.issue378@psf.upfronthosting.co.za> Message-ID: <1305529745.02.0.444319464944.issue378@psf.upfronthosting.co.za> Martin v. L?wis added the comment: There aren't really any changes yet (it's just an extension of roundup, not a patch to roundup). If a patch was developed based on that extension, I'd be willing to license it under whatever conditions are desired. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Mon May 16 10:22:07 2011 From: metatracker at psf.upfronthosting.co.za (anatoly techtonik) Date: Mon, 16 May 2011 08:22:07 +0000 Subject: [Tracker-discuss] [issue378] Merge OpenID login feature upstream In-Reply-To: <1305529745.02.0.444319464944.issue378@psf.upfronthosting.co.za> Message-ID: anatoly techtonik added the comment: On Mon, May 16, 2011 at 10:09 AM, Martin v. L?wis wrote: > > There aren't really any changes yet (it's just an extension of roundup, not a patch to roundup). If a patch was developed based on that extension, I'd be willing to license it under whatever conditions are desired. It is not that easy. For example, it came out that all Mercurial extensions should be GPL. Unfortunately, I can not explain the implication of merging AFL extension into MIT code base or distribution. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed May 18 05:54:00 2011 From: metatracker at psf.upfronthosting.co.za (anatoly techtonik) Date: Wed, 18 May 2011 03:54:00 +0000 Subject: [Tracker-discuss] [issue399] Link PEPs In-Reply-To: <1305690840.43.0.688202767106.issue399@psf.upfronthosting.co.za> Message-ID: <1305690840.43.0.688202767106.issue399@psf.upfronthosting.co.za> New submission from anatoly techtonik : Would be nice to get autolinking for PEPs also. ---------- messages: 2049 nosy: techtonik priority: feature status: unread title: Link PEPs _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed May 18 09:56:18 2011 From: metatracker at psf.upfronthosting.co.za (Georg Brandl) Date: Wed, 18 May 2011 07:56:18 +0000 Subject: [Tracker-discuss] [issue399] Link PEPs In-Reply-To: <1305690840.43.0.688202767106.issue399@psf.upfronthosting.co.za> Message-ID: <1305705378.51.0.370164764644.issue399@psf.upfronthosting.co.za> Georg Brandl added the comment: Please get a bit more specific. ---------- nosy: +gbrandl status: unread -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed May 18 11:30:01 2011 From: metatracker at psf.upfronthosting.co.za (anatoly techtonik) Date: Wed, 18 May 2011 09:30:01 +0000 Subject: [Tracker-discuss] [issue399] Link PEPs In-Reply-To: <1305690840.43.0.688202767106.issue399@psf.upfronthosting.co.za> Message-ID: <1305711001.6.0.426693384134.issue399@psf.upfronthosting.co.za> anatoly techtonik added the comment: If comment text in b.p.o tracker contains strings PEP368 or PEP 432 or PEP\s*\d+ - these links should be converted to links to appropriate PEPs (optionally showing a PEP title and perhaps other PEP info in onhover popup or in link title). _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed May 25 03:52:51 2011 From: metatracker at psf.upfronthosting.co.za (Benjamin Peterson) Date: Wed, 25 May 2011 01:52:51 +0000 Subject: [Tracker-discuss] [issue400] when replying by email, don't send another one In-Reply-To: <1306288371.68.0.154640030812.issue400@psf.upfronthosting.co.za> Message-ID: <1306288371.68.0.154640030812.issue400@psf.upfronthosting.co.za> New submission from Benjamin Peterson : It'd be nice if roundup didn't send another email with your message in it when you reply by email. ---------- messages: 2052 nosy: benjamin.peterson priority: feature status: unread title: when replying by email, don't send another one _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed May 25 08:39:13 2011 From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=) Date: Wed, 25 May 2011 06:39:13 +0000 Subject: [Tracker-discuss] [issue400] when replying by email, don't send another one In-Reply-To: <1306288371.68.0.154640030812.issue400@psf.upfronthosting.co.za> Message-ID: <1306305553.85.0.107456593487.issue400@psf.upfronthosting.co.za> Martin v. L?wis added the comment: Can you please elaborate? Roundup certainly needs to send an email forwarding your text to all people on the nosy list, since your reply only went to roundup, not to the people on the nosy list. ---------- nosy: +loewis status: unread -> chatting _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Wed May 25 15:53:30 2011 From: metatracker at psf.upfronthosting.co.za (Benjamin Peterson) Date: Wed, 25 May 2011 13:53:30 +0000 Subject: [Tracker-discuss] [issue400] when replying by email, don't send another one In-Reply-To: <1306305553.85.0.107456593487.issue400@psf.upfronthosting.co.za> Message-ID: Benjamin Peterson added the comment: 2011/5/25 Martin v. L?wis : > > Martin v. L?wis added the comment: > > Can you please elaborate? Roundup certainly needs to send an email forwarding your text to all people on the nosy list, since your reply only went to roundup, not to the people on the nosy list. But it does it have to go to me personally? _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Thu May 26 03:26:19 2011 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Thu, 26 May 2011 01:26:19 +0000 Subject: [Tracker-discuss] [issue399] Link PEPs In-Reply-To: <1305690840.43.0.688202767106.issue399@psf.upfronthosting.co.za> Message-ID: <1306373179.21.0.991113764629.issue399@psf.upfronthosting.co.za> Ezio Melotti added the comment: Fixed in r88839. ---------- status: chatting -> resolved _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Fri May 27 04:56:23 2011 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Fri, 27 May 2011 02:56:23 +0000 Subject: [Tracker-discuss] [issue401] Fold history in the issue pages In-Reply-To: <1306464983.45.0.41831171245.issue401@psf.upfronthosting.co.za> Message-ID: <1306464983.45.0.41831171245.issue401@psf.upfronthosting.co.za> New submission from Ezio Melotti : The attached patch folds history automatically and adds a "show history"/"hide history" button to fold/unfold it. With the history folded by default it's possible to use the 'end' key to jump to the last message without having to scroll up to skip the history at the bottom. See also #312. ---------- assignedto: ezio.melotti files: fold_history.diff messages: 2056 nosy: eric.araujo, ezio.melotti, pitrou priority: feature status: in-progress title: Fold history in the issue pages _______________________________________________________ PSF Meta Tracker _______________________________________________________ -------------- next part -------------- Index: issue.item.html =================================================================== --- issue.item.html (revision 88836) +++ issue.item.html (working copy) @@ -11,6 +11,7 @@ + Index: issue.item.js =================================================================== --- issue.item.js (revision 88836) +++ issue.item.js (working copy) @@ -41,3 +41,15 @@ nosy.style.display = 'inline'; nosy.style.width = new_width + "px"; } + +$(document).ready(function() { + var th = $('Show History'); + th.css({'cursor': 'pointer', 'text-align': 'center', + 'border': '1px solid #ccc'}); + $('table.history tr:not(:first-child)').toggle(); + th.click(function() { + $('table.history tr:not(:first-child)').toggle(); + th.text(th.text() == 'Show History' ? 'Hide History' : 'Show History'); + }); + $('table.history').append(th.wrap('')); +}) From metatracker at psf.upfronthosting.co.za Sat May 28 00:19:57 2011 From: metatracker at psf.upfronthosting.co.za (Nadeem Vawda) Date: Fri, 27 May 2011 22:19:57 +0000 Subject: [Tracker-discuss] [issue402] Unable to log in to Rietveld code review interface In-Reply-To: <1306534797.29.0.437152892578.issue402@psf.upfronthosting.co.za> Message-ID: <1306534797.29.0.437152892578.issue402@psf.upfronthosting.co.za> New submission from Nadeem Vawda : When I follow the "review" link next to a patch attachment, I am not signed in to Rietveld, even if I am signed in to Roundup when I follow the link. When I follow Rietveld's "sign in" link, I am taken back to http://bugs.python.org/. This seems to be related to the fact that I changed my username from "nvawda" to "nadeem.vawda" a while back. If I am on the nosy list for an issue, the CC list shown by Rietveld includes "nvawda" and not "nadeem.vawda" (or "me"). If I change my Roundup login back to "nvawda", I get signed in to Rietveld automatically, but when I change it back to "nadeem.vawda", I have the same problem of not being able to sign in. ---------- messages: 2057 nosy: nadeem.vawda priority: bug status: unread title: Unable to log in to Rietveld code review interface _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat May 28 03:28:30 2011 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Sat, 28 May 2011 01:28:30 +0000 Subject: [Tracker-discuss] [issue401] Fold history in the issue pages In-Reply-To: <1306464983.45.0.41831171245.issue401@psf.upfronthosting.co.za> Message-ID: <1306546110.65.0.108167092436.issue401@psf.upfronthosting.co.za> Ezio Melotti added the comment: Committed in r88843 and made it work on IE6/7 in r88844. It's somewhat slow on old computers when the history contains many elements but I don't think it's a big deal. It's possible to change the script to "enable" the button only if the history has e.g. more than 5-10 entries, or always show the last 5-10 entries and have a "Show more history" button, but it's probably not worth doing it. I'll leave this open for a while to see if there are any comments. ---------- status: in-progress -> testing _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat May 28 04:18:05 2011 From: metatracker at psf.upfronthosting.co.za (Ned Deily) Date: Sat, 28 May 2011 02:18:05 +0000 Subject: [Tracker-discuss] [issue401] Fold history in the issue pages In-Reply-To: <1306464983.45.0.41831171245.issue401@psf.upfronthosting.co.za> Message-ID: <1306549085.26.0.666959691335.issue401@psf.upfronthosting.co.za> Ned Deily added the comment: My initial reaction to this feature is a big -1. For most issues I want to look at the history and I am finding it quite jarring to see a blank space where I expected to find it. More importantly, I now have to use the mouse to expand. I really prefer the previous behavior. ---------- nosy: +ned.deily _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat May 28 05:54:51 2011 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Sat, 28 May 2011 03:54:51 +0000 Subject: [Tracker-discuss] [issue401] Fold history in the issue pages In-Reply-To: <1306464983.45.0.41831171245.issue401@psf.upfronthosting.co.za> Message-ID: <1306554891.15.0.115369602279.issue401@psf.upfronthosting.co.za> Ezio Melotti added the comment: What are you looking for in the history? _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat May 28 06:46:06 2011 From: metatracker at psf.upfronthosting.co.za (Ned Deily) Date: Sat, 28 May 2011 04:46:06 +0000 Subject: [Tracker-discuss] [issue401] Fold history in the issue pages In-Reply-To: <1306464983.45.0.41831171245.issue401@psf.upfronthosting.co.za> Message-ID: <1306557966.07.0.567927356198.issue401@psf.upfronthosting.co.za> Ned Deily added the comment: Lots of things: the timeline of the issue, who modified it, various items that don't result in messages. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat May 28 06:49:40 2011 From: metatracker at psf.upfronthosting.co.za (Ned Deily) Date: Sat, 28 May 2011 04:49:40 +0000 Subject: [Tracker-discuss] [issue401] Fold history in the issue pages In-Reply-To: <1306464983.45.0.41831171245.issue401@psf.upfronthosting.co.za> Message-ID: <1306558180.97.0.374693356961.issue401@psf.upfronthosting.co.za> Ned Deily added the comment: If the only reason for adding the suppression of the history is to make it easier to get to the last message, that does not strike me as a good trade-off. You can easily get to any message with a few keystrokes: End, then Up - whereas with the change, you now need to use the mouse which was not necessary before. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat May 28 07:11:26 2011 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Sat, 28 May 2011 05:11:26 +0000 Subject: [Tracker-discuss] [issue401] Fold history in the issue pages In-Reply-To: <1306464983.45.0.41831171245.issue401@psf.upfronthosting.co.za> Message-ID: <1306559486.72.0.560260829496.issue401@psf.upfronthosting.co.za> Ezio Melotti added the comment: IMHO you can already see most of the interesting things already. By the time you reach the history you already saw the nosy list, the attachments, the messages, each with an author and a date. The things that are left are changes in the nosy list (but I don't find these too interesting usually), changes in the file list (sometimes it's useful to figure out which one is "the attached patch" when there are several patches attached), and some changes in the other fields (and usually what matters is the current value, not who changed the value and when). So at least for me is not so useful. That said, if you can't really find the information you want elsewhere (or not as easily), it's possible to add a keyboard shortcut, remember if you prefer it folded or not, show just the last few entries (if those are the ones you find interesting), or even revert the change. In some issue 'up' is not enough, and even pgup needs to be hit a few times if the history is long enough (see e.g. http://bugs.python.org/issue8898 or http://bugs.python.org/issue2636 ). The folding can also be enabled selectively, depending on the number of messages/entries or something else. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat May 28 09:30:23 2011 From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=) Date: Sat, 28 May 2011 07:30:23 +0000 Subject: [Tracker-discuss] [issue401] Fold history in the issue pages In-Reply-To: <1306464983.45.0.41831171245.issue401@psf.upfronthosting.co.za> Message-ID: <1306567823.38.0.432825482248.issue401@psf.upfronthosting.co.za> Martin v. L?wis added the comment: I recommend to revert this change. It seems that some users are opposed to any kind of folding (as my earlier folding experiment has demonstrated); users who *really* don't want to see the history would need to step forward and request a per-user option to suppress it. I think the real solution to information flooding here is to have users split larger issues into smaller ones, only discuss one issue at the time, etc. ---------- nosy: +loewis _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat May 28 09:55:56 2011 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Sat, 28 May 2011 07:55:56 +0000 Subject: [Tracker-discuss] [issue401] Fold history in the issue pages In-Reply-To: <1306464983.45.0.41831171245.issue401@psf.upfronthosting.co.za> Message-ID: <1306569356.73.0.963336109587.issue401@psf.upfronthosting.co.za> Ezio Melotti added the comment: Remembering the folded/unfolded position is not difficult (like sphinx does with the sidebar in the py3k doc), so that's a way to have a per-user option without having to configure anything. I also don't think some users are opposed to *any* kind of folding, depending on what is folded and the users, there might be positive or negative reactions, and the difficult part is to find a balance. (Also reactions to changes are often negative, regardless of the kind of change. Giving some time to get used to new features is usually a good idea.) Another possible solution is to make the end key jump to the last message, rather than the end of the page. I'll wait for a few more opinions and see. _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat May 28 13:00:05 2011 From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=) Date: Sat, 28 May 2011 11:00:05 +0000 Subject: [Tracker-discuss] [issue400] when replying by email, don't send another one In-Reply-To: <1306288371.68.0.154640030812.issue400@psf.upfronthosting.co.za> Message-ID: <1306580405.9.0.95790367775.issue400@psf.upfronthosting.co.za> Martin v. L?wis added the comment: I'm not sure. When you enter a message in the web browser, would you want to receive an email with it or not? _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Sat May 28 14:22:07 2011 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Sat, 28 May 2011 12:22:07 +0000 Subject: [Tracker-discuss] [issue400] when replying by email, don't send another one In-Reply-To: <1306288371.68.0.154640030812.issue400@psf.upfronthosting.co.za> Message-ID: <1306585327.01.0.0194376708222.issue400@psf.upfronthosting.co.za> Ezio Melotti added the comment: I think he wants the email when he uses the browser, but when he replies via email he doesn't want to get back from the tracker the same mail he just sent to it. ---------- nosy: +ezio.melotti _______________________________________________________ PSF Meta Tracker _______________________________________________________ From metatracker at psf.upfronthosting.co.za Tue May 31 10:51:24 2011 From: metatracker at psf.upfronthosting.co.za (Ezio Melotti) Date: Tue, 31 May 2011 08:51:24 +0000 Subject: [Tracker-discuss] [issue401] Fold history in the issue pages In-Reply-To: <1306464983.45.0.41831171245.issue401@psf.upfronthosting.co.za> Message-ID: <1306831884.64.0.947257643712.issue401@psf.upfronthosting.co.za> Ezio Melotti added the comment: Attached patch tweaks the end key to jump to the last message rather than the end of the page when pressed for the first time. After the first hit, the normal 'end' behavior is restored. I'll revert the history folding and apply this instead, to see how it works. _______________________________________________________ PSF Meta Tracker _______________________________________________________ -------------- next part -------------- Index: issue.item.js =================================================================== --- issue.item.js (revision 88844) +++ issue.item.js (working copy) @@ -43,15 +43,14 @@ } $(document).ready(function() { - /* Add a "Show/Hide history" button that (un)folds the history. See #401 */ - var th = $('Show History'); - th.css({'cursor': 'pointer', 'text-align': 'center', - 'border': '1px solid #ccc'}); - /* select and hide all the tr except the first one ("History") */ - $('table.history tr:not(:first-child)').toggle(); - th.click(function() { - $('table.history tr:not(:first-child):not(#togglehistory)').toggle(); - th.text(th.text() == 'Show History' ? 'Hide History' : 'Show History'); + var offset = $('table.messages tr th a:last').offset() + $(document).keydown(function (event) { + var node = event.target.nodeName; + if ((event.keyCode == 35) && (node != 'TEXTAREA') + && (node != 'INPUT') && (node != 'SELECT')) { + window.scrollTo(offset.left, offset.top); + $(document).unbind('keydown') + return false; + } }); - $('table.history').append(th.wrap('').parent()); })