From metatracker at psf.upfronthosting.co.za  Thu Dec  1 00:00:44 2011
From: metatracker at psf.upfronthosting.co.za (Nick Coghlan)
Date: Wed, 30 Nov 2011 23:00:44 +0000
Subject: [Tracker-discuss] [issue428] Patch generator and dependent feature
	branches
In-Reply-To: <1322174451.03.0.274638212194.issue428@psf.upfronthosting.co.za>
Message-ID: <1322694044.8.0.047388756475.issue428@psf.upfronthosting.co.za>


Nick Coghlan <ncoghlan at gmail.com> added the comment:

Indeed, I agree the patch generator is doing the right thing in terms of trying to create a patch that applies cleanly to CPython.

For the review patch, I'm happy with generating it locally and uploading it directly - the case of dependent external branches is going to be rare enough that there's no point in expending a lot of effort automating dealing with it.

----------
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue428>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Dec  4 07:00:47 2011
From: metatracker at psf.upfronthosting.co.za (Nick Coghlan)
Date: Sun, 04 Dec 2011 06:00:47 +0000
Subject: [Tracker-discuss] [issue429] Can't generate patch for issue 11816
In-Reply-To: <1322296282.92.0.118756601209.issue429@psf.upfronthosting.co.za>
Message-ID: <1322978447.0.0.218151039965.issue429@psf.upfronthosting.co.za>


Nick Coghlan <ncoghlan at gmail.com> added the comment:

OK, the problem really is that it keeps trying to diff against the same changeset, ignoring all subsequent commits to that branch:
https://bitbucket.org/ncoghlan/cpython_sandbox/changesets/9512712044a6

----------
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue429>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Dec  4 11:18:34 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=)
Date: Sun, 04 Dec 2011 10:18:34 +0000
Subject: [Tracker-discuss] [issue429] Can't generate patch for issue 11816
In-Reply-To: <1322296282.92.0.118756601209.issue429@psf.upfronthosting.co.za>
Message-ID: <1322993914.67.0.198346946642.issue429@psf.upfronthosting.co.za>


Martin v. L?wis <martin at v.loewis.de> added the comment:

AFAICT, 9512712044a6 *is* the most recent change on the get_opinfo branch.

Which changeset do you think should it have used instead?

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue429>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Dec  4 11:24:15 2011
From: metatracker at psf.upfronthosting.co.za (Nick Coghlan)
Date: Sun, 04 Dec 2011 10:24:15 +0000
Subject: [Tracker-discuss] [issue429] Can't generate patch for issue 11816
In-Reply-To: <1322296282.92.0.118756601209.issue429@psf.upfronthosting.co.za>
Message-ID: <1322994255.97.0.613389238854.issue429@psf.upfronthosting.co.za>


Nick Coghlan <ncoghlan at gmail.com> added the comment:

Any of the changesets that appear above it here: https://bitbucket.org/ncoghlan/cpython_sandbox/changesets/tip/branch%28%22get_opinfo%22%29

There have been at least 4 meaningful updates since then, and 7 more recent merges from default.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue429>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Dec  4 11:26:42 2011
From: metatracker at psf.upfronthosting.co.za (Nick Coghlan)
Date: Sun, 04 Dec 2011 10:26:42 +0000
Subject: [Tracker-discuss] [issue429] Can't generate patch for issue 11816
In-Reply-To: <1322296282.92.0.118756601209.issue429@psf.upfronthosting.co.za>
Message-ID: <1322994402.52.0.933013997306.issue429@psf.upfronthosting.co.za>


Nick Coghlan <ncoghlan at gmail.com> added the comment:

The current latest changeset on that branch is this merge from default: https://bitbucket.org/ncoghlan/cpython_sandbox/changeset/5ce60675e572

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue429>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Dec  4 15:27:13 2011
From: metatracker at psf.upfronthosting.co.za (Stefan Krah)
Date: Sun, 04 Dec 2011 14:27:13 +0000
Subject: [Tracker-discuss] [issue424] Rietveld: AssertionError when trying
	to reply to comments
In-Reply-To: <1318328000.91.0.751562811451.issue424@psf.upfronthosting.co.za>
Message-ID: <1323008833.86.0.240600385829.issue424@psf.upfronthosting.co.za>


Stefan Krah <stefan-usenet at bytereef.org> added the comment:

I'm constantly getting this error:

Environment:

Request Method: GET
Request URL: http://bugs.python.org/review/7652/show
Django Version: 1.1.1 SVN-17159
Python Version: 2.5.2
Installed Applications:
['django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.sites',
 'django.contrib.admin',
 'gae2django',
 'rietveld_helper',
 'codereview']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'roundup_helper.middleware.LookupRoundupUser',
 'gae2django.middleware.FixRequestUserMiddleware',
 'rietveld_helper.middleware.AddUserToRequestMiddleware',
 'django.middleware.doc.XViewMiddleware')


Traceback:
File "/home/roundup/trackers/tracker/rietveld/django/core/handlers/base.py" in get_response
  88.                 response = middleware_method(request, callback, callback_args, callback_kwargs)
File "/home/roundup/trackers/tracker/rietveld/rietveld_helper/middleware.py" in process_view
  21.         response = view_func(request, *view_args, **view_kwargs)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in issue_wrapper
  643.     return func(request, *args, **kwds)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in show
  1493.                   'has_draft_message': has_draft_message,
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in respond
  416.     must_choose_nickname = not account.user_has_selected_nickname()

Exception Type: AttributeError at /review/7652/show
Exception Value: 'NoneType' object has no attribute 'user_has_selected_nickname'


Does that look like the same issue or should I open another one?

----------
nosy: +skrah
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue424>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Dec  4 19:32:57 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=)
Date: Sun, 04 Dec 2011 18:32:57 +0000
Subject: [Tracker-discuss] [issue429] Can't generate patch for issue 11816
In-Reply-To: <1322994402.52.0.933013997306.issue429@psf.upfronthosting.co.za>
Message-ID: <4EDBBCD7.9050009@v.loewis.de>


Martin v. L?wis <martin at v.loewis.de> added the comment:

> The current latest changeset on that branch is this merge from default: https://bitbucket.org/ncoghlan/cpython_sandbox/changeset/5ce60675e572

The repository you specified on issue 11816 is
http://hg.python.org/sandbox/ncoghlan, not
https://bitbucket.org/ncoghlan/cpython_sandbox.
In that repository, those changes (including 5ce60675e572) do not
exist.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue429>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Dec  4 22:14:28 2011
From: metatracker at psf.upfronthosting.co.za (Nadeem Vawda)
Date: Sun, 04 Dec 2011 21:14:28 +0000
Subject: [Tracker-discuss] [issue424] Rietveld: AssertionError when trying
	to reply to comments
In-Reply-To: <1318328000.91.0.751562811451.issue424@psf.upfronthosting.co.za>
Message-ID: <1323033268.34.0.720642963422.issue424@psf.upfronthosting.co.za>


Nadeem Vawda <nadeem.vawda at gmail.com> added the comment:

Nope, that looks like a different error. The one I was getting was an AssertionError,
not an AttributeError.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue424>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Dec  5 01:07:06 2011
From: metatracker at psf.upfronthosting.co.za (Nick Coghlan)
Date: Mon, 05 Dec 2011 00:07:06 +0000
Subject: [Tracker-discuss] [issue429] Can't generate patch for issue 11816
In-Reply-To: <1322296282.92.0.118756601209.issue429@psf.upfronthosting.co.za>
Message-ID: <1323043626.0.0.0160885956984.issue429@psf.upfronthosting.co.za>


Nick Coghlan <ncoghlan at gmail.com> added the comment:

Ah, you're right - I added it before I moved my sandbox over to BitBucket, and then my brain was doing the "fill in what you expect to see rather than reading what is actually there" trick.

Sorry for the noise.

----------
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue429>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Dec  5 15:14:13 2011
From: metatracker at psf.upfronthosting.co.za (Stefan Krah)
Date: Mon, 05 Dec 2011 14:14:13 +0000
Subject: [Tracker-discuss] [issue424] Rietveld: AssertionError when trying
	to reply to comments
In-Reply-To: <1323033268.34.0.720642963422.issue424@psf.upfronthosting.co.za>
Message-ID: <20111205141410.GA15905@sleipnir.bytereef.org>


Stefan Krah <stefan-usenet at bytereef.org> added the comment:

Nadeem Vawda <metatracker at psf.upfronthosting.co.za> wrote:
> Nope, that looks like a different error. The one I was getting was an AssertionError,
> not an AttributeError.

Thanks, I'll open another one.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue424>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Dec  5 17:32:31 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Mon, 05 Dec 2011 16:32:31 +0000
Subject: [Tracker-discuss] [issue422] Keyboard shortcuts
In-Reply-To: <1317625041.71.0.42670053076.issue422@psf.upfronthosting.co.za>
Message-ID: <1323102751.02.0.367543519856.issue422@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Attached patch and screenshot for a popup window with the description of the shortcuts that appears when '?' is pressed.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue422>
_______________________________________________________
-------------- next part --------------
Index: style.css
===================================================================
--- style.css	(revision 88927)
+++ style.css	(working copy)
@@ -531,3 +531,40 @@
     max-width: 20em;
     overflow: auto;
 }
+
+/* styles for the keyboard shortcut help popup */
+div#shortcuts-help {
+    background-color: #efefef;
+    border: 1px solid #afafaf;
+    position: fixed;
+    top: 6em;
+    left: 50%;
+    z-index: 42;
+    width: 400px;
+    margin-left: -200px;
+    padding: 1em;
+    text-align: center;
+    opacity: 0.95;
+}
+div#shortcuts-help table {
+    margin: 0 auto 1em;
+    border: 1px solid #afafaf;
+}
+div#shortcuts-help caption {
+    font-weight: bold;
+    padding: .2em;
+}
+div#shortcuts-help th, div#shortcuts-help td {
+    text-align: center;
+    padding: .2em;
+    background-color: #dddddd;
+}
+div#shortcuts-help tr th:first-child {
+    text-align: right;
+}
+div#shortcuts-help span {
+    cursor: pointer;
+    border: 1px solid #afafaf;
+    padding: .2em;
+    background-color: #dddddd;
+}
Index: issue.item.js
===================================================================
--- issue.item.js	(revision 88927)
+++ issue.item.js	(working copy)
@@ -56,31 +56,48 @@
         // scroll the page to the given node
         window.scrollTo(0, node.offset().top)
     }
-    function add_help() {
-        // add some help to the sidebar
-        $(['<li><strong>Keyboard shortcuts</strong>',
-           '<ul id="help" class="level-three">',
-           '  <li><a>f/h: first msg</a></li>',
-           '  <li><a>p/k: previous msg</a></li>',
-           '  <li><a>n/j: next msg</a></li>',
-           '  <li><a>l: last msg</a></li>',
-           '  <li><a>r/i: focus textarea</a></li>',
-           '  <li><a>ESC: unfocus textarea</a></li>',
-           '</ul></div>'].join('\n')).appendTo('div#menu ul.level-two');
-        // the empty <a> are just an hack to get the style right,
-        // this help will anyway be moved to the devguide soon
+    function create_help_popup() {
+        // create a popup that lists the available shortcuts
+        var div = $([
+           '<div id="shortcuts-help"><table>',
+           '  <caption>Keyboard shortcuts</caption>',
+           '  <tr><th></th><th>mnemonic</th><th>vim-style</th></tr>',
+           '  <tr><th>first message</th><td>f</td><td>h</td></tr>',
+           '  <tr><th>previous message</th><td>p</td><td>k</td></tr>',
+           '  <tr><th>next message</th><td>n</td><td>j</td></tr>',
+           '  <tr><th>last message</th><td>l</td><td>l</td></tr>',
+           '  <tr><th>focus textarea</th><td>r</td><td>i</td></tr>',
+           '  <tr><th>unfocus textarea</th><td>Esc</td><td>Esc</td></tr>',
+           '  <tr><th>shortcuts help</th><td>?</td><td>?</td></tr>',
+           '</table>',
+           '<span id="close-help">Close shortcuts help</span></div>'].join('\n'))
+        // this should point to the devguide once a section with the shortcuts
+        // is added
+        //$('<li><a href="#">Keyboard shortcuts (?)</a></li>').appendTo(
+        //        'div#menu ul.level-three:last');
+        div.find('span').click(function() { div.hide() })
+        div.hide()
+        div.appendTo('body');
     }
-    add_help()
+    create_help_popup()
+
+    var help_popup = $('#shortcuts-help');
     var textarea = $('textarea').first();
     var messages = $('table.messages tr th a:first-child');
     var last_index = messages.length - 1;
     // start from -1 so 'n' sends to the first message at the beginning
     var current = -1;
     $(document).keydown(function (event) {
+        // '?' shows the help if the user is not editing the form.
+        // this is here because usually '?' requires 'shift' too, and the
+        // switch below is not reached when shift is pressed
+        if (event.shiftKey && (event.which == 191) && !is_editing(event.target)) {
+            help_popup.toggle()
+            return false;
+        }
         // do nothing if ctrl/alt/shift/meta are pressed
         if (event.ctrlKey || event.altKey || event.shiftKey || event.metaKey)
             return true;
-
         // disable the shortcuts while editing form elements (except ESC)
         if (is_editing(event.target)) {
             // ESC - unfocus the form
@@ -90,6 +107,11 @@
             }
             return true;
         }
+        // ESC hides the help if the user is not editing
+        if (event.keyCode == 27) {
+            help_popup.hide();
+            return false;
+        }
 
         // support two groups of shortcuts for first/prev/next/last/reply:
         //    mnemonics: f/p/n/l/r

From metatracker at psf.upfronthosting.co.za  Mon Dec  5 17:36:53 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Mon, 05 Dec 2011 16:36:53 +0000
Subject: [Tracker-discuss] [issue422] Keyboard shortcuts
In-Reply-To: <1317625041.71.0.42670053076.issue422@psf.upfronthosting.co.za>
Message-ID: <1323103013.49.0.56284409501.issue422@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

The problem with the table is that it may suggest that users need to choose one of mnemonic or vim-style.  A simpler alternative might be something like:


    Keyboard Shortcuts

  first message: *f* or *h*
  previous message: *p* or *k*
  ...
  this help: *Shift+?*

(using ** to suggest ?strong? HTML elements)

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue422>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Dec  5 17:51:57 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Mon, 05 Dec 2011 16:51:57 +0000
Subject: [Tracker-discuss] [issue422] Keyboard shortcuts
In-Reply-To: <1317625041.71.0.42670053076.issue422@psf.upfronthosting.co.za>
Message-ID: <1323103917.91.0.30585998093.issue422@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

I was considering that, but since there's no evident way to select the "mode", people will just try to use whatever they prefer and regardless of what it is it will work (vim should be mentioned somewhere, to clarify what's the second set of keys is for).  Once I rework the tracker doc in the devguide I'm planning to add a section to describe the keyboard shortcuts.
Another option is to write under the table that both the "modes" are always "enabled".
I'm not sure the 'shift' needs to be mentioned, you say either A or shift+a, and here the key is '?', not shift+?.  Depending on the layout, it might be either shift+7, shift+', shift+/, shift+,, etc.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue422>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Dec  5 18:00:37 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Mon, 05 Dec 2011 17:00:37 +0000
Subject: [Tracker-discuss] [issue422] Keyboard shortcuts
In-Reply-To: <1317625041.71.0.42670053076.issue422@psf.upfronthosting.co.za>
Message-ID: <1323104437.57.0.0696274434307.issue422@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

> I was considering that, but since there's no evident way to select the "mode", people will
> just try to use whatever they prefer and regardless of what it is it will work
I still think using a table can be confusing.  There is no mode, so let?s not suggest there are modes, just list the shortcuts.

> (vim should be mentioned somewhere, to clarify what's the second set of keys is for).
If it?s obvious for Vim users and irrelevant for other people, we can also just say nothing (maybe a commen in the source).

> I'm not sure the 'shift' needs to be mentioned, you say either A or shift+a, and here the key is '?',
> not shift+?.
Oh you?re right, I was confused by Anatoly?s earlier mention of ?Shift+??, but the character triggering the help pop-up is ???.  So that?s one more that can?t be used for find as you type.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue422>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Dec  5 18:19:53 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Mon, 05 Dec 2011 17:19:53 +0000
Subject: [Tracker-discuss] [issue422] Keyboard shortcuts
In-Reply-To: <1317625041.71.0.42670053076.issue422@psf.upfronthosting.co.za>
Message-ID: <1323105593.57.0.122733681113.issue422@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

> If it?s obvious for Vim users and irrelevant for other people,
> we can also just say nothing (maybe a commen in the source).
But if I don't mention it somewhere it's not obvious.  If the Vim "mode"* is mentioned somewhere, Vim users will just pick that up and the others will simply ignore it.  If it's not mentioned Vim users might not realize that the second set of shortcuts comes from Vim, and non-Vim users will wonder what the second (unintuitive) set is for.
Mentioning that all the shortcuts always work might be enough, otherwise I can put them together and mention that the alternatives mimic Vim's shortcuts (an advantage of keeping them separate is that users will just need to look at a single column once they decide if they want to use the Vim "mode" or not).

* note that even if I'm calling it "mode", I agree that it's a confusing term and it shouldn't be used in the doc

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue422>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Dec 12 17:47:53 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Mon, 12 Dec 2011 16:47:53 +0000
Subject: [Tracker-discuss] [issue253] Remove outdated keywords
In-Reply-To: <1237513464.32.0.072891570662.issue253@psf.upfronthosting.co.za>
Message-ID: <1323708473.63.0.541681083511.issue253@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

I removed "after moratorium" too.
Since it doesn't seem possible to search for issues with a retired keywords from the UI, here's the link for reference (there are only 4 issues using it): http://bugs.python.org/issue?%40search_text=&ignore=file%3Acontent&title=&%40columns=title&id=&%40columns=id&stage=&creation=&creator=&activity=&%40columns=activity&%40sort=activity&actor=&nosy=&type=&components=&versions=&dependencies=&assignee=&keywords=10&priority=&%40group=priority&status=1&%40columns=status&resolution=&nosy_count=&message_count=&%40pagesize=50&%40startwith=0&%40queryname=&%40old-queryname=&%40action=search

----------
assignedto:  -> ezio.melotti
status: resolved -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue253>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Dec 12 22:58:31 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=)
Date: Mon, 12 Dec 2011 21:58:31 +0000
Subject: [Tracker-discuss] [issue427] Time synchronization defect
In-Reply-To: <1322166822.28.0.27718847317.issue427@psf.upfronthosting.co.za>
Message-ID: <1323727111.13.0.64351134074.issue427@psf.upfronthosting.co.za>


Martin v. L?wis <martin at v.loewis.de> added the comment:

Thanks!

----------
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue427>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Dec 13 01:16:28 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 13 Dec 2011 00:16:28 +0000
Subject: [Tracker-discuss] [issue408] Tracker development setup fails
In-Reply-To: <1309607729.46.0.543451245542.issue408@psf.upfronthosting.co.za>
Message-ID: <1323735388.49.0.0719327736396.issue408@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

FWIW I updated the TrackerDevelopment page and you should now be able to get a running instance of the tracker if you follow the instructions.
Basically you just have to disable the cia detector and also the spambayes and rietveld ones if you are not planning to use them.  You shouldn't need spambayes, but if you want to test things on rietveld you'll have to figure out how to make it work (and if you do, please update the wiki or write it down here).
Note that these are just workarounds, a proper fix would still be better.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue408>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Dec 13 09:05:58 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Tue, 13 Dec 2011 08:05:58 +0000
Subject: [Tracker-discuss] [issue408] Tracker development setup fails
In-Reply-To: <1323735388.49.0.0719327736396.issue408@psf.upfronthosting.co.za>
Message-ID: <CAPkN8x+u52EXFSXORisqUAQGqDmRPm0+b=HzpuauByFSQgauRw@mail.gmail.com>


anatoly techtonik <techtonik at gmail.com> added the comment:

On Tue, Dec 13, 2011 at 3:16 AM, Ezio Melotti <
metatracker at psf.upfronthosting.co.za> wrote:

>
> Ezio Melotti <ezio.melotti at gmail.com> added the comment:
>
> FWIW I updated the TrackerDevelopment page and you should now be able to
> get a running instance of the tracker if you follow the instructions.
> Basically you just have to disable the cia detector and also the spambayes
> and rietveld ones if you are not planning to use them.  You shouldn't need
> spambayes, but if you want to test things on rietveld you'll have to figure
> out how to make it work (and if you do, please update the wiki or write it
> down here).
> Note that these are just workarounds, a proper fix would still be better.
>

These patches doesn't look awesome. Is it possible to implement a plug-in
behavior for these components, so that they could be enabled in config?

----------
nosy: +techtonik

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue408>
_______________________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/tracker-discuss/attachments/20111213/79c9fb9d/attachment.html>

From techtonik at gmail.com  Tue Dec 13 09:05:34 2011
From: techtonik at gmail.com (anatoly techtonik)
Date: Tue, 13 Dec 2011 11:05:34 +0300
Subject: [Tracker-discuss] [issue408] Tracker development setup fails
In-Reply-To: <1323735388.49.0.0719327736396.issue408@psf.upfronthosting.co.za>
References: <1309607729.46.0.543451245542.issue408@psf.upfronthosting.co.za>
	<1323735388.49.0.0719327736396.issue408@psf.upfronthosting.co.za>
Message-ID: <CAPkN8x+u52EXFSXORisqUAQGqDmRPm0+b=HzpuauByFSQgauRw@mail.gmail.com>

On Tue, Dec 13, 2011 at 3:16 AM, Ezio Melotti <
metatracker at psf.upfronthosting.co.za> wrote:

>
> Ezio Melotti <ezio.melotti at gmail.com> added the comment:
>
> FWIW I updated the TrackerDevelopment page and you should now be able to
> get a running instance of the tracker if you follow the instructions.
> Basically you just have to disable the cia detector and also the spambayes
> and rietveld ones if you are not planning to use them.  You shouldn't need
> spambayes, but if you want to test things on rietveld you'll have to figure
> out how to make it work (and if you do, please update the wiki or write it
> down here).
> Note that these are just workarounds, a proper fix would still be better.
>

These patches doesn't look awesome. Is it possible to implement a plug-in
behavior for these components, so that they could be enabled in config?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/tracker-discuss/attachments/20111213/79c9fb9d/attachment-0001.html>

From metatracker at psf.upfronthosting.co.za  Tue Dec 13 17:02:43 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 13 Dec 2011 16:02:43 +0000
Subject: [Tracker-discuss] [issue384] Make removing a single keyword more
	intuitive
In-Reply-To: <1301339299.17.0.525456893161.issue384@psf.upfronthosting.co.za>
Message-ID: <1323792163.78.0.684385648381.issue384@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

FWIW I tried to replace the select/option with checkboxes, but the code was starting to get a bit too ugly so I gave up for now.

If I replace
 <td tal:content="structure python:context['keywords'].menu(height=5)">keywords</td>
with:
 <td><tal:block tal:repeat="key context/keywords">
     <input tal:attributes="value python:key._nodeid" name="keywords" type="checkbox">
     <tal:block tal:content="python:str(key._klass.get(key._nodeid, 'name'))" />
     </tal:block>
 </td>

I can get a check box for each /selected/ keyword, with its name next to it.
Using str(key._klass.get(key._nodeid, 'name')) to get to the name isn't too pretty already, and getting the list of all the keywords seems even worse.
In templating.py:MultilinkHTMLProperty.menu there's the code that creates the select/option, and IIUC to get the list of keywords names it does:
        for optionid in options:
            # get the option value, and if it's None use an empty string
            option = linkcl.get(optionid, k) or ''

where options is:
        options = [opt
            for opt in linkcl.filter(None, conditions, sort_on)
            if self._db.security.hasPermission("View", self._client.userid,
                linkcl.classname, itemid=opt)]

where linkcl is:
        linkcl = self._db.getclass(self._prop.classname)

maybe there's an easy way to do this, but if that's the case I didn't find it.  Putting all this in an extension might avoid some clutter in the template though.

The current code has a <select name="keywords"> and several <option value="N">keyname</option>, where N is the id.  The post request contains all the selected options, e.g. &keywords=2&keywords=3, or if "no selection" is selected, the request should be &keywords=-2,-3 (where 2 and 3 are the ids of the selected keywords).
Having several <input name="keywords" value="N" type="checkbox"> seems to work without having to change the server side but it still won't solve the original problem.

IIUC when you remove the last keyword, no '&keywords=' is sent to the server and in this case, instead of removing all the keywords, it leaves them unchanged.  Therefore you need to select "no selection" in order to send a &keywords=-N that explicitly removes the last keyword.

----------
nosy: +eric.araujo, ezio.melotti

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue384>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Dec 13 21:21:16 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 13 Dec 2011 20:21:16 +0000
Subject: [Tracker-discuss] [issue408] Tracker development setup fails
In-Reply-To: <1309607729.46.0.543451245542.issue408@psf.upfronthosting.co.za>
Message-ID: <1323807676.83.0.799003059974.issue408@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

As I said they are just workarounds, and in the meanwhile it's better to share them than waiting for someone to fix the installation.
The fix to /disable/ these components is probably quite easy -- putting the 'returns' in an 'if' that checks some value in the config should be enough.  OTOH it would be better to figure out how to install and enable the additional components, especially rietveld.  AFAIU the error reported by Vinay can be fixed by running some django/rietveld script (manage.py syncdb maybe?), but I didn't have time to try it yet.  Maybe Martin knows.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue408>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Dec 13 21:41:48 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Tue, 13 Dec 2011 20:41:48 +0000
Subject: [Tracker-discuss] [issue408] Tracker development setup fails
In-Reply-To: <1323807676.83.0.799003059974.issue408@psf.upfronthosting.co.za>
Message-ID: <CAPkN8xL=32h=v-Pe9r8u0==EEjy=y0gO85nAtQOUMKytT+uEhQ@mail.gmail.com>


anatoly techtonik <techtonik at gmail.com> added the comment:

On Tue, Dec 13, 2011 at 11:21 PM, Ezio Melotti <
metatracker at psf.upfronthosting.co.za> wrote:

> As I said they are just workarounds, and in the meanwhile it's better to
> share them than waiting for someone to fix the installation.
>

Right, but are there any issues opened at Roundup side to make mysterious
'someone' aware of the issues?

> The fix to /disable/ these components is probably quite easy -- putting
> the 'returns' in an 'if' that checks some value in the config should be
> enough.

Isn't Roundup config static? (I feel like I forgot a lot since the last
time I visited Roundup codebase)

>  OTOH it would be better to figure out how to install and enable the
> additional components, especially rietveld.  AFAIU the error reported by
> Vinay can be fixed by running some django/rietveld script (manage.py syncdb
> maybe?), but I didn't have time to try it yet.  Maybe Martin knows.

What error are you speaking about?

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue408>
_______________________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/tracker-discuss/attachments/20111213/8b7b273e/attachment.html>

From metatracker at psf.upfronthosting.co.za  Tue Dec 13 21:49:19 2011
From: metatracker at psf.upfronthosting.co.za (Vinay Sajip)
Date: Tue, 13 Dec 2011 20:49:19 +0000
Subject: [Tracker-discuss] [issue408] Tracker development setup fails
In-Reply-To: <1309607729.46.0.543451245542.issue408@psf.upfronthosting.co.za>
Message-ID: <1323809359.04.0.663180212483.issue408@psf.upfronthosting.co.za>


Vinay Sajip <vinay_sajip at yahoo.co.uk> added the comment:

> What error are you speaking about?

The one that I opened the issue with.

Ezio, thanks for the update, but I'm unfortunately tied up with other work for the moment, and will get back to this when time allows.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue408>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Dec 13 22:01:51 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Tue, 13 Dec 2011 21:01:51 +0000
Subject: [Tracker-discuss] [issue408] Tracker development setup fails
In-Reply-To: <1323809359.04.0.663180212483.issue408@psf.upfronthosting.co.za>
Message-ID: <CAPkN8xLo=kVG6YDxvWYA4xdYYBrkKYOiwfXeFe3DkDHqfSfTVQ@mail.gmail.com>


anatoly techtonik <techtonik at gmail.com> added the comment:

On Tue, Dec 13, 2011 at 11:49 PM, Vinay Sajip <
metatracker at psf.upfronthosting.co.za> wrote:

>
> Vinay Sajip <vinay_sajip at yahoo.co.uk> added the comment:
>
> > What error are you speaking about?
>
> The one that I opened the issue with.
>

Whoops. =)  Did anybody published incomplete findings in this regard?

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue408>
_______________________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/tracker-discuss/attachments/20111213/bffc1527/attachment.html>

From metatracker at psf.upfronthosting.co.za  Tue Dec 13 23:21:26 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 13 Dec 2011 22:21:26 +0000
Subject: [Tracker-discuss] [issue408] Tracker development setup fails
In-Reply-To: <1309607729.46.0.543451245542.issue408@psf.upfronthosting.co.za>
Message-ID: <1323814886.14.0.768046645442.issue408@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

> Right, but are there any issues opened at Roundup side to make mysterious
> 'someone' aware of the issues?

The extensions we use and how they are configured depend on us, so that 'someone' is probably either me or Martin.  Since I already have a tracker installed on my machine and I don't have to install new ones, installation problems are not high on my list.

> Isn't Roundup config static? (I feel like I forgot a lot since the last
> time I visited Roundup codebase)

I think you can just put in the .ini something like
[detectors]
spambayes = off
rietveld = on
cia = off

and then in e.g. detectors/cia.py:init
if db.config.detectors['cia'] != 'on':
    return

> Did anybody published incomplete findings in this regard?

Someone just pointed out that possibility during a discussion on IRC.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue408>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Thu Dec 15 10:50:02 2011
From: metatracker at psf.upfronthosting.co.za (Antoine Pitrou)
Date: Thu, 15 Dec 2011 09:50:02 +0000
Subject: [Tracker-discuss] [issue432] Rietveld traceback
Message-ID: <1323942602.68.0.925393034145.issue432@psf.upfronthosting.co.za>


New submission from Antoine Pitrou <pitrou at free.fr>:

When trying to click on the review link for be8a59fcba49.diff at http://bugs.python.org/issue7652, I get the following error:


Environment:

Request Method: GET
Request URL: http://bugs.python.org/review/7652/show
Django Version: 1.1.1 SVN-17159
Python Version: 2.5.2
Installed Applications:
['django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.sites',
 'django.contrib.admin',
 'gae2django',
 'rietveld_helper',
 'codereview']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'roundup_helper.middleware.LookupRoundupUser',
 'gae2django.middleware.FixRequestUserMiddleware',
 'rietveld_helper.middleware.AddUserToRequestMiddleware',
 'django.middleware.doc.XViewMiddleware')


Traceback:
File "/home/roundup/trackers/tracker/rietveld/django/core/handlers/base.py" in get_response
  88.                 response = middleware_method(request, callback, callback_args, callback_kwargs)
File "/home/roundup/trackers/tracker/rietveld/rietveld_helper/middleware.py" in process_view
  21.         response = view_func(request, *view_args, **view_kwargs)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in issue_wrapper
  643.     return func(request, *args, **kwds)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in show
  1493.                   'has_draft_message': has_draft_message,
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in respond
  416.     must_choose_nickname = not account.user_has_selected_nickname()

Exception Type: AttributeError at /review/7652/show
Exception Value: 'NoneType' object has no attribute 'user_has_selected_nickname'

----------
messages: 2358
nosy: ezio.melotti, loewis, pitrou
priority: bug
status: unread
title: Rietveld traceback

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue432>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Thu Dec 15 10:51:03 2011
From: metatracker at psf.upfronthosting.co.za (Antoine Pitrou)
Date: Thu, 15 Dec 2011 09:51:03 +0000
Subject: [Tracker-discuss] [issue432] Rietveld traceback
In-Reply-To: <1323942602.68.0.925393034145.issue432@psf.upfronthosting.co.za>
Message-ID: <1323942663.31.0.708371133287.issue432@psf.upfronthosting.co.za>


Antoine Pitrou <pitrou at free.fr> added the comment:

Looks like trying again succeeded. Perhaps a transient issue because of the sheer size of the patch being reviewed?

----------
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue432>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Dec 25 05:09:19 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Sun, 25 Dec 2011 04:09:19 +0000
Subject: [Tracker-discuss] [issue422] Keyboard shortcuts
In-Reply-To: <1317625041.71.0.42670053076.issue422@psf.upfronthosting.co.za>
Message-ID: <1324786159.04.0.0551054194466.issue422@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

I added a note under the table, tweaked a few minor things and committed the patch in r88929.

http://svn.python.org/view?view=revision&revision=88929

----------
status: chatting -> testing

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue422>
_______________________________________________________