[Tracker-discuss] commit review

[Brett Cannon]

On Tue, Mar 24, 2009 at 18:40, R. David Murray <rdmurray at bitdance.com>wrote:

> A message went by (from Martin?) that I seem to have deleted that I
> believe said that 'commit review' was appropriate if the reviewer thought
> the patch was ready for final committer review and (hopefully) commit.
> That's what I'd like it to mean, but http://www.python.org/dev/workflow
> indicates it is for a second review when (and only when?) a release
> candidate is in prep.


It means it is specifically ready for a core developer to review. Think of a
patch review as somebody such as yourself, David, has reviewed the patch and
said it looks good. Then you can set it to "committer review" for a core
developer to take a quick look and commit it. When Python is not in the
middle of an RC going through committer review is optional for core
developers. I will try to clarify that while I am at PyCon along with
documenting the Type and Versions fields.

-Brett
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/tracker-discuss/attachments/20090324/611ac04a/attachment.htm>