From dale at BriannasSaladDressing.com  Wed May  4 23:23:20 2011
From: dale at BriannasSaladDressing.com (Dale Schroeder)
Date: Wed, 04 May 2011 16:23:20 -0500
Subject: [spambayes-dev] [Spambayes] Bug solution for Spambayes
In-Reply-To: <19830.55259.401408.494213@montanaro.dyndns.org>
References: <4D64295F.90901@gmx.de>
	<19816.3717.813624.474521@montanaro.dyndns.org>
	<4D76A0EE.9020701@BriannasSaladDressing.com>
	<19830.55259.401408.494213@montanaro.dyndns.org>
Message-ID: <4DC1C3C8.1040109@BriannasSaladDressing.com>

On 03/08/2011 7:28 PM, skip at pobox.com wrote:
>      Dale>  Although the build happens and the correct dependencies are
>      Dale>  applied, this is what I got when I tried to run it.
>
>      Dale>  Traceback (most recent call last):
>      Dale>     File "/usr/bin/sb_server.py", line 96, in<module>
>      Dale>       from spambayes import Dibbler
>      Dale>     File "/usr/lib/python2.5/site-packages/spambayes/Dibbler.py", line 186, in<module>
>      Dale>       from spambayes import asyncore, asynchat
>      Dale>  ImportError: cannot import name asyncore
>
> Hmmm...  Looks like asyncore (and probably asynchat) probably didn't make it
> into the distribution.  I maybe have a messed up manifest.  I'll take a
> look.
>
> Skip
>

Well, today Debian provided an update to python that prevents the use of 
all Spambayes versions.
I had been running 1.1a6 with python 2.5.  Attempting that combination 
now yields:

     Traceback ( most recent call last):
         File "/usr/bin/sb_server.py", line 93, in <module>
             import spambayes.message
ImportError: No module named spambayes.message

Summarizing the current situation:

The official Debian version of 1.04 starts and allows email through, but 
training yields only error messages and no actual training occurs.
Version 1.1a6 will not start due to the spambayes.message module problem 
mentioned above.
Version 1.1b1 has the problems with asyncore and asynchat outlined at 
the top and also will not start.

I don't really know how to proceed at this point.

Thanks,
Dale

_Current python packages:_

ii  libpython2.6                       2.6.6-10
ii  python2.5                          2.5.5-11
ii  python2.5-minimal                  2.5.5-11
ii  python2.6                          2.6.6-10
ii  python                             2.6.6-14
ii  python2.6-minimal                  2.6.6-10
ii  python-cairo                       1.8.8-1+b1
ii  python-central                     0.6.17
ii  python-dbus                        0.83.1-1+b1
ii  python-dns                         2.3.5-2
ii  python-gobject                     2.28.3-2
ii  python-gobject-cairo               2.28.3-2
ii  python-imaging                     1.1.7-2+b1
ii  python-lockfile                    1:0.8-2
ii  python-minimal                     2.6.6-14
ii  python-pexpect                     2.3-1
ii  python-pkg-resources               0.6.15-2
ii  python-setuptools                  0.6.15-2
ii  python-support                     1.0.13


_Version 1.04 training errors:_

*Training... *


      *500 Server error*

*Traceback (most recent call last):

   File "/usr/lib/pymodules/python2.6/spambayes/Dibbler.py", line 470, in found_terminator
     getattr(plugin, name)(**params)

   File "/usr/lib/pymodules/python2.6/spambayes/ProxyUI.py", line 399, in onReview
     self.flush()

   File "/usr/lib/pymodules/python2.6/spambayes/Dibbler.py", line 706, in flush
     return self._handler.flush()

   File "/usr/lib/pymodules/python2.6/spambayes/Dibbler.py", line 221, in flush
     while (self.producer_fifo or self.ac_out_buffer) and not self._closed:

   File "/usr/lib/python2.6/asyncore.py", line 406, in __getattr__
     %(self.__class__.__name__, attr))

AttributeError: _HTTPHandler instance has no attribute 'ac_out_buffer'
*


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/spambayes-dev/attachments/20110504/489f92c0/attachment.html>

From skip at pobox.com  Thu May  5 15:51:46 2011
From: skip at pobox.com (skip at pobox.com)
Date: Thu, 5 May 2011 08:51:46 -0500
Subject: [spambayes-dev] [Spambayes] Bug solution for Spambayes
In-Reply-To: <4DC1C3C8.1040109@BriannasSaladDressing.com>
References: <4D64295F.90901@gmx.de>
	<19816.3717.813624.474521@montanaro.dyndns.org>
	<4D76A0EE.9020701@BriannasSaladDressing.com>
	<19830.55259.401408.494213@montanaro.dyndns.org>
	<4DC1C3C8.1040109@BriannasSaladDressing.com>
Message-ID: <19906.43890.66908.50222@montanaro.dyndns.org>

    Dale> Although the build happens and the correct dependencies are
    Dale> applied, this is what I got when I tried to run it.
    
    Dale> Traceback (most recent call last):
    Dale> File "/usr/bin/sb_server.py", line 96, in<module>
    Dale> from spambayes import Dibbler
    Dale> File "/usr/lib/python2.5/site-packages/spambayes/Dibbler.py", line 186, in<module>
    Dale> from spambayes import asyncore, asynchat
    Dale> ImportError: cannot import name asyncore
    
    Dale>     Hmmm...  Looks like asyncore (and probably asynchat) probably
    Dale>     didn't make it into the distribution.  I maybe have a messed
    Dale>     up manifest.  I'll take a look.

My apologies for not getting to this sooner.
    
    Dale> Well, today Debian provided an update to python that prevents the
    Dale> use of all Spambayes versions.  I had been running 1.1a6 with
    Dale> python 2.5.  Attempting that combination now yields:

    ...

    Dale> Version 1.1b1 has the problems with asyncore and asynchat outlined
    Dale> at the top and also will not start.

    Dale> I don't really know how to proceed at this point.

As it turns out distutils has a bug which causes it to not rebuild the
MANIFEST file in many situations, so the new asyncore and asynchat modules
were not incorporated into the original 1.1b1 release.  I fixed that problem
today and created a new 1.1b1 source release.  It's available in the usual
place:

    http://pypi.python.org/pypi?:action=display&name=spambayes

Before uploading it I verified that the new files were included:

    % tar tfz dist/spambayes-1.1b1.tar.gz | egrep async
    spambayes-1.1b1/Outlook2000/dialogs/async_processor.py
    spambayes-1.1b1/spambayes/asynchat.py
    spambayes-1.1b1/spambayes/asyncore.py

Please have the Debian folks regenerate their SpamBayes package.

-- 
Skip Montanaro - skip at pobox.com - http://www.smontanaro.net/

From dale at BriannasSaladDressing.com  Fri May  6 18:17:43 2011
From: dale at BriannasSaladDressing.com (Dale Schroeder)
Date: Fri, 06 May 2011 11:17:43 -0500
Subject: [spambayes-dev] [Spambayes] Bug solution for Spambayes
In-Reply-To: <19906.43890.66908.50222@montanaro.dyndns.org>
References: <4D64295F.90901@gmx.de>
	<19816.3717.813624.474521@montanaro.dyndns.org>
	<4D76A0EE.9020701@BriannasSaladDressing.com>
	<19830.55259.401408.494213@montanaro.dyndns.org>
	<4DC1C3C8.1040109@BriannasSaladDressing.com>
	<19906.43890.66908.50222@montanaro.dyndns.org>
Message-ID: <4DC41F27.9010805@BriannasSaladDressing.com>

On 05/05/2011 8:51 AM, skip at pobox.com wrote:
>      Dale>  Although the build happens and the correct dependencies are
>      Dale>  applied, this is what I got when I tried to run it.
>
>      Dale>  Traceback (most recent call last):
>      Dale>  File "/usr/bin/sb_server.py", line 96, in<module>
>      Dale>  from spambayes import Dibbler
>      Dale>  File "/usr/lib/python2.5/site-packages/spambayes/Dibbler.py", line 186, in<module>
>      Dale>  from spambayes import asyncore, asynchat
>      Dale>  ImportError: cannot import name asyncore
>
>      Dale>      Hmmm...  Looks like asyncore (and probably asynchat) probably
>      Dale>      didn't make it into the distribution.  I maybe have a messed
>      Dale>      up manifest.  I'll take a look.
>
> My apologies for not getting to this sooner.
No apologies necessary - just glad you're willing and able to do it.
>
>      Dale>  Well, today Debian provided an update to python that prevents the
>      Dale>  use of all Spambayes versions.  I had been running 1.1a6 with
>      Dale>  python 2.5.  Attempting that combination now yields:
>
>      ...
>
>      Dale>  Version 1.1b1 has the problems with asyncore and asynchat outlined
>      Dale>  at the top and also will not start.
>
>      Dale>  I don't really know how to proceed at this point.
>
> As it turns out distutils has a bug which causes it to not rebuild the
> MANIFEST file in many situations, so the new asyncore and asynchat modules
> were not incorporated into the original 1.1b1 release.  I fixed that problem
> today and created a new 1.1b1 source release.  It's available in the usual
> place:
>
>      http://pypi.python.org/pypi?:action=display&name=spambayes
>
> Before uploading it I verified that the new files were included:
>
>      % tar tfz dist/spambayes-1.1b1.tar.gz | egrep async
>      spambayes-1.1b1/Outlook2000/dialogs/async_processor.py
>      spambayes-1.1b1/spambayes/asynchat.py
>      spambayes-1.1b1/spambayes/asyncore.py
>
> Please have the Debian folks regenerate their SpamBayes package.
>
I went live with 1.1b1 today, and all has gone well.  It also seems to 
be somewhat faster than before.
Yesterday, I tested with python 2.6 and 2.7 - both worked.

For Debian users: I used python-stdeb to build the .deb package.  Unlike 
version 1.1a6, 1.1b1 would only work on the system on which it was built 
- even though all python packages were of the same version between systems.
Specifically, the .deb that was built on the test system installed on 
the production system, started on the production system, but would throw 
error messages when attempting to train email.  I did not put any effort 
into finding out why this happened, so it may or may not be universally 
applicable.

Skip, thank you very much for fixing this.  It is much appreciated.

Alexandre, please consider making this version an official Debian package.

Dale