[spambayes-dev] [Spambayes-checkins] spambayes/windows/py2exesetup_all.py, 1.26, 1.27

[Mark Hammond]

> > Update of /cvsroot/spambayes/spambayes/windows/py2exe
> > In directory sc8-pr-cvs8.sourceforge.net:/tmp/cvs-serv6540
> >
> > Modified Files:
> > 	setup_all.py
> > Log Message:
> > Ship with PIL (but no Tkinter) and pyDNS
> >
> >
> > [...]
> > !     excludes = "Tkinter," # side-effect of PIL and markh doesn't
> > have it :)
> > !                 "win32ui,pywin,pywin.debugger," # *sob* - these
> > still appear
> > !                 # Keep zope out else outlook users lose training.
> > !                 # (sob - but some of these may still appear!)
> > !
> > "ZODB,_zope_interface_coptimizations,_OOBTree,cPersistence",
>
> I don't care about this for 1.1a3, but is this right?  Outlook users
> (any users, really) would only lose training if they chose not to
> convert the database on installation and didn't change their
> configuration to continue to use bsddb.

If the inno installer offers to convert databases, then you may be correct.
However, for my testing I didn't use the inno installer, so suddenly and
without warning 'lost' the training info.  I wonder if people who roll
spambayes out to many seats all use our Inno setup to achieve that - if not,
they too will lose.

More generally though, even if I was prompted about converting the
databases, if I answered 'No' I would expect my old existing database would
still work as before.  An upgrade that *forces* pain on you (answer yes,
wait while 1x20MB and 1x10MB pickles are migrated, or answer 'no' and take
the pain of retraining from scratch) doesn't sound friendly.  A better
approach may be that before *creating* a database in the new format, check
to see if the old format exists and continue to use it.

And more generally still, the ZODB that I have installed is built from Zope3
from SVN - from a branch, but not (necessarily) corresponding to an official
release.  This didn't seem prudent (but OTOH, probably would not itself have
caused me to exclude it without the above :)

Cheers,

Mark