From noreply at sourceforge.net Fri Dec 4 06:40:57 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 04 Dec 2009 05:40:57 +0000 Subject: [spambayes-bugs] [ spambayes-Bugs-2908573 ] spambayes corrupts mailbox (From_ escaping) Message-ID: Bugs item #2908573, was opened at 2009-12-04 16:40 Message generated for change (Tracker Item Submitted) made by earth-native You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2908573&group_id=61702 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: 1.0.4 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Owen Cameron (earth-native) Assigned to: Nobody/Anonymous (nobody) Summary: spambayes corrupts mailbox (From_ escaping) Initial Comment: I'm using debian package of spambayes: Version: 1.0.4-5.1 Messages piped through spambayes are corrupted in their From_ escaping. mbox is a poorly defined format, with multiple variations. They are summarised here: http://homepages.tesco.net/J.deBoynePollard/FGA/mail-mbox-formats.html /usr/lib/python2.5/email/generator.py appears to be the culprit, and says this: Optional mangle_from_ is a flag that, when True (the default), escapes From_ lines in the body of the message by putting a `>' in front of them. This is "mboxo" format - which irreversibly corrupts messages. My opinions on the correctness (or not) of generator.py's behaviour aside, surely spambayes should surely never need to alter the body at all? Request that spambayes sets mangle_from_ to false when calling generator.py. The following demonstrates the behaviour directly: ---- $ echo -e "From this is a pretend header\n\nFrom a line with no > quotes\n>From a line with one > quote\n>>From a line with two > quotes" | sb_filter.py >From this is a pretend header X-Spambayes-Classification: unsure; 0.77 >From a line with no > quotes >From a line with one > quote >>From a line with two > quotes ---- ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2908573&group_id=61702 From noreply at sourceforge.net Sun Dec 6 21:28:15 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Sun, 06 Dec 2009 20:28:15 +0000 Subject: [spambayes-bugs] [ spambayes-Bugs-2908573 ] spambayes corrupts mailbox (From_ escaping) Message-ID: Bugs item #2908573, was opened at 2009-12-03 23:40 Message generated for change (Comment added) made by montanaro You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2908573&group_id=61702 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None >Group: 1.1.x >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Nemo Thorx (earth-native) >Assigned to: Skip Montanaro (montanaro) Summary: spambayes corrupts mailbox (From_ escaping) Initial Comment: I'm using debian package of spambayes: Version: 1.0.4-5.1 Messages piped through spambayes are corrupted in their From_ escaping. mbox is a poorly defined format, with multiple variations. They are summarised here: http://homepages.tesco.net/J.deBoynePollard/FGA/mail-mbox-formats.html /usr/lib/python2.5/email/generator.py appears to be the culprit, and says this: Optional mangle_from_ is a flag that, when True (the default), escapes From_ lines in the body of the message by putting a `>' in front of them. This is "mboxo" format - which irreversibly corrupts messages. My opinions on the correctness (or not) of generator.py's behaviour aside, surely spambayes should surely never need to alter the body at all? Request that spambayes sets mangle_from_ to false when calling generator.py. The following demonstrates the behaviour directly: ---- $ echo -e "From this is a pretend header\n\nFrom a line with no > quotes\n>From a line with one > quote\n>>From a line with two > quotes" | sb_filter.py >From this is a pretend header X-Spambayes-Classification: unsure; 0.77 >From a line with no > quotes >From a line with one > quote >>From a line with two > quotes ---- ---------------------------------------------------------------------- >Comment By: Skip Montanaro (montanaro) Date: 2009-12-06 14:28 Message: Thanks for the bug report. I checked in a fix to a couple support files (rev 3255) which will hopefully correct this problem. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2908573&group_id=61702 From noreply at sourceforge.net Thu Dec 17 17:22:18 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 17 Dec 2009 16:22:18 +0000 Subject: [spambayes-bugs] [ spambayes-Bugs-2916335 ] From lines get mangled by sb_filter.py Message-ID: Bugs item #2916335, was opened at 2009-12-17 17:22 Message generated for change (Tracker Item Submitted) made by alexratti You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: hammie Group: Source code - CVS Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandre Ratti (alexratti) Assigned to: Nobody/Anonymous (nobody) Summary: From lines get mangled by sb_filter.py Initial Comment: I installed the SVN code to get around the From escaping problem discussed on these pages: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=559977 https://sourceforge.net/tracker/?func=detail&aid=2908573&group_id=61702&atid=498103 However, messages still get mangled by the latest SVN code (revision 3255): the first From header of a messages is stripped. As a result, messages stored in mbox files on a Linux server are invisible to mail readers such as Thunderbird (IMAP access) and Mutt (local access). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 From noreply at sourceforge.net Thu Dec 17 17:37:42 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 17 Dec 2009 16:37:42 +0000 Subject: [spambayes-bugs] [ spambayes-Bugs-2916335 ] From lines get mangled by sb_filter.py Message-ID: Bugs item #2916335, was opened at 2009-12-17 17:22 Message generated for change (Comment added) made by alexratti You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: hammie Group: Source code - CVS Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandre Ratti (alexratti) >Assigned to: Skip Montanaro (montanaro) Summary: From lines get mangled by sb_filter.py Initial Comment: I installed the SVN code to get around the From escaping problem discussed on these pages: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=559977 https://sourceforge.net/tracker/?func=detail&aid=2908573&group_id=61702&atid=498103 However, messages still get mangled by the latest SVN code (revision 3255): the first From header of a messages is stripped. As a result, messages stored in mbox files on a Linux server are invisible to mail readers such as Thunderbird (IMAP access) and Mutt (local access). ---------------------------------------------------------------------- >Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 17:37 Message: I clicked Submit too fast; I wanted to attach files for testing and now I can't. So I uploaded the files to: http://alexandre.ratti.free.fr/sb/ To test, I first mailed myself a message with the command line "mail" utility. This message went through my system (procmail and clamav), but it was NOT filtered by spambayes (deactivated in .procmailrc). Then I filter the message through sb_filter.py on the command line and I created a diff. As you can see, the first From line is missing from the processed message. I'm assigning this report to user "montanaro" since he checked in the fix for the From escaping issue. Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 From noreply at sourceforge.net Thu Dec 17 17:50:12 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 17 Dec 2009 16:50:12 +0000 Subject: [spambayes-bugs] [ spambayes-Bugs-2916335 ] From lines get mangled by sb_filter.py Message-ID: Bugs item #2916335, was opened at 2009-12-17 10:22 Message generated for change (Comment added) made by montanaro You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: hammie Group: Source code - CVS Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandre Ratti (alexratti) Assigned to: Skip Montanaro (montanaro) Summary: From lines get mangled by sb_filter.py Initial Comment: I installed the SVN code to get around the From escaping problem discussed on these pages: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=559977 https://sourceforge.net/tracker/?func=detail&aid=2908573&group_id=61702&atid=498103 However, messages still get mangled by the latest SVN code (revision 3255): the first From header of a messages is stripped. As a result, messages stored in mbox files on a Linux server are invisible to mail readers such as Thunderbird (IMAP access) and Mutt (local access). ---------------------------------------------------------------------- >Comment By: Skip Montanaro (montanaro) Date: 2009-12-17 10:50 Message: Alexandre, what SpamBayes tool demonstrates this problem? I tested the change using sb_filter.py. It seems you're seeing this with another one of the SpamBayes tools. ---------------------------------------------------------------------- Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 10:37 Message: I clicked Submit too fast; I wanted to attach files for testing and now I can't. So I uploaded the files to: http://alexandre.ratti.free.fr/sb/ To test, I first mailed myself a message with the command line "mail" utility. This message went through my system (procmail and clamav), but it was NOT filtered by spambayes (deactivated in .procmailrc). Then I filter the message through sb_filter.py on the command line and I created a diff. As you can see, the first From line is missing from the processed message. I'm assigning this report to user "montanaro" since he checked in the fix for the From escaping issue. Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 From noreply at sourceforge.net Thu Dec 17 18:12:22 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 17 Dec 2009 17:12:22 +0000 Subject: [spambayes-bugs] [ spambayes-Bugs-2916335 ] From lines get mangled by sb_filter.py Message-ID: Bugs item #2916335, was opened at 2009-12-17 17:22 Message generated for change (Comment added) made by alexratti You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: hammie Group: Source code - CVS Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandre Ratti (alexratti) Assigned to: Skip Montanaro (montanaro) Summary: From lines get mangled by sb_filter.py Initial Comment: I installed the SVN code to get around the From escaping problem discussed on these pages: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=559977 https://sourceforge.net/tracker/?func=detail&aid=2908573&group_id=61702&atid=498103 However, messages still get mangled by the latest SVN code (revision 3255): the first From header of a messages is stripped. As a result, messages stored in mbox files on a Linux server are invisible to mail readers such as Thunderbird (IMAP access) and Mutt (local access). ---------------------------------------------------------------------- >Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 18:12 Message: I'm actually seeing this with sb_filter.py. To double-check, I just ran: cat test-message.txt | sb_filter.py > take2.txt diff -u test-message.txt take2.txt > take2.diff I'm getting the same result. First "From" line is deleted. which sb_filter.py /usr/bin/sb_filter.py This is what I have in sb_filter.py: #!/usr/bin/python # EASY-INSTALL-SCRIPT: 'spambayes==1.1b1','sb_filter.py' __requires__ = 'spambayes==1.1b1' import pkg_resources pkg_resources.run_script('spambayes==1.1b1', 'sb_filter.py') I installed this Spambayes copy from SVN. To get it: 1) I checked out trunk two days ago. 2) I made a source release with "python setup.py sdist --formats gztar". 3) I installed this release (with "setup.py install", I think). Do you think I have a version mixup? ---------------------------------------------------------------------- Comment By: Skip Montanaro (montanaro) Date: 2009-12-17 17:50 Message: Alexandre, what SpamBayes tool demonstrates this problem? I tested the change using sb_filter.py. It seems you're seeing this with another one of the SpamBayes tools. ---------------------------------------------------------------------- Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 17:37 Message: I clicked Submit too fast; I wanted to attach files for testing and now I can't. So I uploaded the files to: http://alexandre.ratti.free.fr/sb/ To test, I first mailed myself a message with the command line "mail" utility. This message went through my system (procmail and clamav), but it was NOT filtered by spambayes (deactivated in .procmailrc). Then I filter the message through sb_filter.py on the command line and I created a diff. As you can see, the first From line is missing from the processed message. I'm assigning this report to user "montanaro" since he checked in the fix for the From escaping issue. Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 From noreply at sourceforge.net Thu Dec 17 18:48:17 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 17 Dec 2009 17:48:17 +0000 Subject: [spambayes-bugs] [ spambayes-Bugs-2916335 ] From lines get mangled by sb_filter.py Message-ID: Bugs item #2916335, was opened at 2009-12-17 17:22 Message generated for change (Comment added) made by alexratti You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: hammie Group: Source code - CVS Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandre Ratti (alexratti) Assigned to: Skip Montanaro (montanaro) Summary: From lines get mangled by sb_filter.py Initial Comment: I installed the SVN code to get around the From escaping problem discussed on these pages: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=559977 https://sourceforge.net/tracker/?func=detail&aid=2908573&group_id=61702&atid=498103 However, messages still get mangled by the latest SVN code (revision 3255): the first From header of a messages is stripped. As a result, messages stored in mbox files on a Linux server are invisible to mail readers such as Thunderbird (IMAP access) and Mutt (local access). ---------------------------------------------------------------------- >Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 18:48 Message: OK, some more checks: In "/usr/lib/python2.4/site-packages/", I can find the file "spambayes-1.1b1-py2.4.egg" This egg was generated when installing from the source release (see previous comment). I had a look at its content and I can see your recent changes to "message.py": def as_string(self, unixfrom=False, mangle_from_=False): http://spambayes.svn.sourceforge.net/viewvc/spambayes/trunk/spambayes/spambayes/message.py?sortby=rev&view=diff&r1=3255&r2=3254&diff_format=h So I guess that I'm actually running the last SVN code (I was worried I wasn't :-). ---------------------------------------------------------------------- Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 18:12 Message: I'm actually seeing this with sb_filter.py. To double-check, I just ran: cat test-message.txt | sb_filter.py > take2.txt diff -u test-message.txt take2.txt > take2.diff I'm getting the same result. First "From" line is deleted. which sb_filter.py /usr/bin/sb_filter.py This is what I have in sb_filter.py: #!/usr/bin/python # EASY-INSTALL-SCRIPT: 'spambayes==1.1b1','sb_filter.py' __requires__ = 'spambayes==1.1b1' import pkg_resources pkg_resources.run_script('spambayes==1.1b1', 'sb_filter.py') I installed this Spambayes copy from SVN. To get it: 1) I checked out trunk two days ago. 2) I made a source release with "python setup.py sdist --formats gztar". 3) I installed this release (with "setup.py install", I think). Do you think I have a version mixup? ---------------------------------------------------------------------- Comment By: Skip Montanaro (montanaro) Date: 2009-12-17 17:50 Message: Alexandre, what SpamBayes tool demonstrates this problem? I tested the change using sb_filter.py. It seems you're seeing this with another one of the SpamBayes tools. ---------------------------------------------------------------------- Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 17:37 Message: I clicked Submit too fast; I wanted to attach files for testing and now I can't. So I uploaded the files to: http://alexandre.ratti.free.fr/sb/ To test, I first mailed myself a message with the command line "mail" utility. This message went through my system (procmail and clamav), but it was NOT filtered by spambayes (deactivated in .procmailrc). Then I filter the message through sb_filter.py on the command line and I created a diff. As you can see, the first From line is missing from the processed message. I'm assigning this report to user "montanaro" since he checked in the fix for the From escaping issue. Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 From noreply at sourceforge.net Fri Dec 18 20:51:41 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 18 Dec 2009 19:51:41 +0000 Subject: [spambayes-bugs] [ spambayes-Bugs-2916335 ] From lines get mangled by sb_filter.py Message-ID: Bugs item #2916335, was opened at 2009-12-17 17:22 Message generated for change (Comment added) made by alexratti You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: hammie Group: Source code - CVS Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandre Ratti (alexratti) Assigned to: Skip Montanaro (montanaro) Summary: From lines get mangled by sb_filter.py Initial Comment: I installed the SVN code to get around the From escaping problem discussed on these pages: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=559977 https://sourceforge.net/tracker/?func=detail&aid=2908573&group_id=61702&atid=498103 However, messages still get mangled by the latest SVN code (revision 3255): the first From header of a messages is stripped. As a result, messages stored in mbox files on a Linux server are invisible to mail readers such as Thunderbird (IMAP access) and Mutt (local access). ---------------------------------------------------------------------- >Comment By: Alexandre Ratti (alexratti) Date: 2009-12-18 20:51 Message: Update. What I understood so far: 1) Spambayes 1.03 + mail 2.5.4 (from Python 2.3) -> no problem. This was the Debian Sarge setup. 2) Spambayes 1.04 + mail 2.5.4 (from Python 2.3) -> no problem. 3) Spambayes 1.03 + mail 3.0.2 (from Python 2.4) -> broken. 4) Spambayes 1.04 + mail 3.0.2 (from Python 2.4) -> broken. This is what happens on Debian Etch and Lenny. 5) Spambayes 1.1 from SVN (revision 3256 checked in today): mangles every test message I send from Thunderbird 2. Spambayes headers (X-Spambayes-*) get inserted just after the first "From" header. See previous bug report: https://sourceforge.net/tracker/?func=detail&aid=2908573&group_id=61702&ati d=498103 ---------------------------------------------------------------------- Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 18:48 Message: OK, some more checks: In "/usr/lib/python2.4/site-packages/", I can find the file "spambayes-1.1b1-py2.4.egg" This egg was generated when installing from the source release (see previous comment). I had a look at its content and I can see your recent changes to "message.py": def as_string(self, unixfrom=False, mangle_from_=False): http://spambayes.svn.sourceforge.net/viewvc/spambayes/trunk/spambayes/spambayes/message.py?sortby=rev&view=diff&r1=3255&r2=3254&diff_format=h So I guess that I'm actually running the last SVN code (I was worried I wasn't :-). ---------------------------------------------------------------------- Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 18:12 Message: I'm actually seeing this with sb_filter.py. To double-check, I just ran: cat test-message.txt | sb_filter.py > take2.txt diff -u test-message.txt take2.txt > take2.diff I'm getting the same result. First "From" line is deleted. which sb_filter.py /usr/bin/sb_filter.py This is what I have in sb_filter.py: #!/usr/bin/python # EASY-INSTALL-SCRIPT: 'spambayes==1.1b1','sb_filter.py' __requires__ = 'spambayes==1.1b1' import pkg_resources pkg_resources.run_script('spambayes==1.1b1', 'sb_filter.py') I installed this Spambayes copy from SVN. To get it: 1) I checked out trunk two days ago. 2) I made a source release with "python setup.py sdist --formats gztar". 3) I installed this release (with "setup.py install", I think). Do you think I have a version mixup? ---------------------------------------------------------------------- Comment By: Skip Montanaro (montanaro) Date: 2009-12-17 17:50 Message: Alexandre, what SpamBayes tool demonstrates this problem? I tested the change using sb_filter.py. It seems you're seeing this with another one of the SpamBayes tools. ---------------------------------------------------------------------- Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 17:37 Message: I clicked Submit too fast; I wanted to attach files for testing and now I can't. So I uploaded the files to: http://alexandre.ratti.free.fr/sb/ To test, I first mailed myself a message with the command line "mail" utility. This message went through my system (procmail and clamav), but it was NOT filtered by spambayes (deactivated in .procmailrc). Then I filter the message through sb_filter.py on the command line and I created a diff. As you can see, the first From line is missing from the processed message. I'm assigning this report to user "montanaro" since he checked in the fix for the From escaping issue. Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 From noreply at sourceforge.net Sat Dec 19 01:10:09 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Sat, 19 Dec 2009 00:10:09 +0000 Subject: [spambayes-bugs] [ spambayes-Bugs-2916335 ] From lines get mangled by sb_filter.py Message-ID: Bugs item #2916335, was opened at 2009-12-17 10:22 Message generated for change (Comment added) made by montanaro You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: hammie Group: Source code - CVS Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandre Ratti (alexratti) Assigned to: Skip Montanaro (montanaro) Summary: From lines get mangled by sb_filter.py Initial Comment: I installed the SVN code to get around the From escaping problem discussed on these pages: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=559977 https://sourceforge.net/tracker/?func=detail&aid=2908573&group_id=61702&atid=498103 However, messages still get mangled by the latest SVN code (revision 3255): the first From header of a messages is stripped. As a result, messages stored in mbox files on a Linux server are invisible to mail readers such as Thunderbird (IMAP access) and Mutt (local access). ---------------------------------------------------------------------- >Comment By: Skip Montanaro (montanaro) Date: 2009-12-18 18:10 Message: Thanks for the report. Obviously the fix is going to be a little tougher than I first thought. I've reverted the previous change. ---------------------------------------------------------------------- Comment By: Alexandre Ratti (alexratti) Date: 2009-12-18 13:51 Message: Update. What I understood so far: 1) Spambayes 1.03 + mail 2.5.4 (from Python 2.3) -> no problem. This was the Debian Sarge setup. 2) Spambayes 1.04 + mail 2.5.4 (from Python 2.3) -> no problem. 3) Spambayes 1.03 + mail 3.0.2 (from Python 2.4) -> broken. 4) Spambayes 1.04 + mail 3.0.2 (from Python 2.4) -> broken. This is what happens on Debian Etch and Lenny. 5) Spambayes 1.1 from SVN (revision 3256 checked in today): mangles every test message I send from Thunderbird 2. Spambayes headers (X-Spambayes-*) get inserted just after the first "From" header. See previous bug report: https://sourceforge.net/tracker/?func=detail&aid=2908573&group_id=61702&ati d=498103 ---------------------------------------------------------------------- Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 11:48 Message: OK, some more checks: In "/usr/lib/python2.4/site-packages/", I can find the file "spambayes-1.1b1-py2.4.egg" This egg was generated when installing from the source release (see previous comment). I had a look at its content and I can see your recent changes to "message.py": def as_string(self, unixfrom=False, mangle_from_=False): http://spambayes.svn.sourceforge.net/viewvc/spambayes/trunk/spambayes/spambayes/message.py?sortby=rev&view=diff&r1=3255&r2=3254&diff_format=h So I guess that I'm actually running the last SVN code (I was worried I wasn't :-). ---------------------------------------------------------------------- Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 11:12 Message: I'm actually seeing this with sb_filter.py. To double-check, I just ran: cat test-message.txt | sb_filter.py > take2.txt diff -u test-message.txt take2.txt > take2.diff I'm getting the same result. First "From" line is deleted. which sb_filter.py /usr/bin/sb_filter.py This is what I have in sb_filter.py: #!/usr/bin/python # EASY-INSTALL-SCRIPT: 'spambayes==1.1b1','sb_filter.py' __requires__ = 'spambayes==1.1b1' import pkg_resources pkg_resources.run_script('spambayes==1.1b1', 'sb_filter.py') I installed this Spambayes copy from SVN. To get it: 1) I checked out trunk two days ago. 2) I made a source release with "python setup.py sdist --formats gztar". 3) I installed this release (with "setup.py install", I think). Do you think I have a version mixup? ---------------------------------------------------------------------- Comment By: Skip Montanaro (montanaro) Date: 2009-12-17 10:50 Message: Alexandre, what SpamBayes tool demonstrates this problem? I tested the change using sb_filter.py. It seems you're seeing this with another one of the SpamBayes tools. ---------------------------------------------------------------------- Comment By: Alexandre Ratti (alexratti) Date: 2009-12-17 10:37 Message: I clicked Submit too fast; I wanted to attach files for testing and now I can't. So I uploaded the files to: http://alexandre.ratti.free.fr/sb/ To test, I first mailed myself a message with the command line "mail" utility. This message went through my system (procmail and clamav), but it was NOT filtered by spambayes (deactivated in .procmailrc). Then I filter the message through sb_filter.py on the command line and I created a diff. As you can see, the first From line is missing from the processed message. I'm assigning this report to user "montanaro" since he checked in the fix for the From escaping issue. Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498103&aid=2916335&group_id=61702