[spambayes-bugs] [ spambayes-Bugs-675811 ] Dead buttons left on uninstall

Wed Nov 3 02:36:18 CET 2004

Bugs item #675811, was opened at 2003-01-28 12:37
Message generated for change (Comment added) made by anadelonbrin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=675811&group_id=61702

Category: Outlook
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Tony Meyer (anadelonbrin)
Assigned to: Mark Hammond (mhammond)
Summary: Dead buttons left on uninstall

Initial Comment:
The toolbar buttons are temporary, which causes 
problems if they are moved.  If they are permanent, then 
we are left with dead buttons if we uninstall the plugin 
(why would we do this? ;p ).

----------------------------------------------------------------------

>Comment By: Tony Meyer (anadelonbrin)
Date: 2004-11-03 14:36

Message:
Logged In: YES 
user_id=552329

It would be really good to have this fixed for 1.1 - we
still regularly get people confused by this bug.

I'm not sure about the temporary option, as described by
Kenny - I do like having our own toolbar (although we have
already reduced the size of the buttons).

Attached is a patch that simply deletes the toolbar on
unregister, launching Outlook if necessary to do so.  (It
quits when done, which could be only done if Outlook wasn't
already running, or in that case could relaunch it - those
are minor details).  This works for the source, but I
haven't tested it with the installer yet.

Any thoughts on this method?

----------------------------------------------------------------------

Comment By: Kenny Pitt (kpitt)
Date: 2004-02-17 04:06

Message:
Logged In: YES 
user_id=859086

I don't think it would be that "expensive" computationally, but 
it would destroy any customizations done to the toolbar 
including repositioning. That seems to defeat the purpose of 
making the toolbar permanent in the first place.

As an example, if I delete the SpamBayes toolbar manually 
and then restart Outlook, the SpamBayes toolbar appears in a 
second toolbar row all by itself. That wastes a lot of screen 
real-estate so I immediately drag it over to the end of the 
main toolbar to make a single row, and it stays there from 
then on no matter how many times I restart Outlook. If we 
delete the SpamBayes toolbar every time Outlook is closed, 
the toolbar would go back to the second row every time I 
restart.

Personally, I think I would rather see us go back to using 
temporary buttons. The hard part is figuring out how to use 
them correctly. Here are some thoughts that might at least 
spark some discussion (I'm not fully aware of all the history on 
this, so I apologize if any of this has already been found to 
not work well).

(1) Don't create a separate toolbar if it is temporary, because 
the user won't be able to reposition it to a convenient 
location (just like above with deleting the permanent one 
every time).
(2) Don't tack the buttons onto the end of the main toolbar 
because it is too easy to lose them off the edge if people 
aren't using wide screens and maximized Outlook windows. A 
good place to put them might be to insert them where 
Outlook inserts its "Not Junk" button, which is by default 
between the Delete button and the Reply button.
(3) Use shorter text descriptions so that the buttons don't 
take up as much room. Similar to Outlook's "Not Junk", I've 
renamed my SpamBayes buttons as "Spam" and "Not Spam".
(4) We could possibly save even more room on the toolbar by 
making the SpamBayes menu a submenu in the Action menu 
after Outlook's Junk E-mail submenu instead of using a toolbar 
button.

----------------------------------------------------------------------

Comment By: Tony Meyer (anadelonbrin)
Date: 2004-02-15 14:34

Message:
Logged In: YES 
user_id=552329

How expensive would it be to delete the toolbar every time
we close Outlook?  That would fix this and also step around
the bug that makes the toolbar get recreated all the time. 
(For me, at least, the toolbar is recreated because of that
failure every time I start Outlook, so it would make almost
no difference).

Just a thought.  (This tracker was opened over a year ago -
wow!).

----------------------------------------------------------------------

Comment By: Tony Meyer (anadelonbrin)
Date: 2003-08-14 10:39

Message:
Logged In: YES 
user_id=552329

That's right - I wrote that solution before SpamBayes had it's 
own toolbar.

If you right-click on the toolbar, then choose customize, then 
select the spambayes toolbar, then choose delete, it goes 
away and everything else is left alone.

----------------------------------------------------------------------

Comment By: Hugh Brackett (hbrackett)
Date: 2003-08-14 05:46

Message:
Logged In: YES 
user_id=837287

Dead buttons - Less drastic is to customize the toolbar and 
drag the spambayes buttons off. This avoids loosing all your 
customizations. I also had to select the spambayes toolbar in 
the View menu to see the real 0.6 buttons.

----------------------------------------------------------------------

Comment By: Mark Hammond (mhammond)
Date: 2003-07-04 00:29

Message:
Logged In: YES 
user_id=14198

Still in the latest version, even with the new toolbar :(

----------------------------------------------------------------------

Comment By: Tony Meyer (anadelonbrin)
Date: 2003-07-01 12:15

Message:
Logged In: YES 
user_id=552329

For anyone reading this because they have buttons left over 
after uninstalling, you can get rid of them by resetting the 
toolbar.

(Right click on the toolbar, click
customize, then select the standard toolbar, then click reset).

Presumably the next release, when we have our own toolbar, 
will remove this issue and this can be closed.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=675811&group_id=61702