[spambayes-bugs] [ spambayes-Bugs-933473 ] Unnecessary spam folder hook

[SourceForge.net]

Bugs item #933473, was opened at 2004-04-12 13:23
Message generated for change (Comment added) made by anadelonbrin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=933473&group_id=61702

Category: Outlook
Group: Source code - CVS
>Status: Closed
>Resolution: Fixed
Priority: 1
Submitted By: Tony Meyer (anadelonbrin)
Assigned to: Tony Meyer (anadelonbrin)
Summary: Unnecessary spam folder hook

Initial Comment:
[From discussion on spambayes-dev]

The spam folder gets hooked for incremental training,
even if the train_manual_spam option is False.  In the
hooked event, it checks for the train_manual_spam
option and quits if it's False.

I asked:
"""
Would it not be better to only add the hook if the
train_manual_spam option is True?  Or is there some
other reason that the spam folder has to be hooked?
"""

Mark replied:
"""I think you are correct - we could avoid the hook
alltogether.  However, I'm still reluctant to change
this, as it does risk breakage.  We can fix it post 1.0.
"""

Opening this so that I remember that this needs to be
done.  Attaching a patch that does the job, and I'll
run with this in my own day-to-day plug-in so there's
some limited testing at least before it gets checked in.

----------------------------------------------------------------------

>Comment By: Tony Meyer (anadelonbrin)
Date: 2004-07-04 18:20

Message:
Logged In: YES 
user_id=552329

Checked into the HEAD.

Checking in Outlook2000/addin.py;
new revision: 1.129; previous revision: 1.128


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=933473&group_id=61702