[spambayes-bugs] [ spambayes-Bugs-874784 ] Error in onReview code

[SourceForge.net]

Bugs item #874784, was opened at 2004-01-11 19:27
Message generated for change (Comment added) made by anadelonbrin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=874784&group_id=61702

Category: pop3proxy
Group: Source code - CVS
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Brendon Whateley (brendonw)
>Assigned to: Tony Meyer (anadelonbrin)
Summary: Error in onReview code

Initial Comment:
Hi, 
 
I don't know how significant this error is, since everything 
seems to work even though the code is wrong!  In 
ProxyUI.py in the def of 'onReview', there is the following 
code: 
if params.get('go') != 'refresh': 
to presumably miss this block unless we are doing a 
refresh.  The problem is that this is ALWAYS true because 
the value of the param 'go' is 'Refresh', not 'refresh' 
 
I assume that this is an unintended, and harmless 
oversight? 
 
Brendon. 
 
P.S.  I'll make a patch if one is needed <wink> 
 

----------------------------------------------------------------------

>Comment By: Tony Meyer (anadelonbrin)
Date: 2004-01-13 11:25

Message:
Logged In: YES 
user_id=552329

It's not really significant, but you're right, it's an error 
nonetheless.

Fixed, thanks.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=874784&group_id=61702