[spambayes-bugs] [ spambayes-Bugs-872044 ] HTTP review page date problems

[SourceForge.net]

Bugs item #872044, was opened at 2004-01-07 12:56
Message generated for change (Comment added) made by anadelonbrin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=872044&group_id=61702

Category: pop3proxy
Group: Source code - CVS
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Brendon Whateley (brendonw)
Assigned to: Tony Meyer (anadelonbrin)
Summary: HTTP review page date problems

Initial Comment:
I've occasionally complained (or at least alluded to) a 
problem when training sb_server using the web interface.  
The problem has the symptom of getting more than one 
days defects listed in the review page, mixed with finding 
no messages to review and similar strange date related 
problems.  The reason I classified the problem as strange 
was that I've not seen any other reports of this type of 
problem... 
 
So, I finally borrowed 10 minutes to learn python and dig 
into the problem: 
 
In _buildReviewKeys in ProxyUI.py, the array returned by  
state.unknownCorpus.keys() is not sorted in any particular 
order.  This leads to allKeys[-1] returning unpredictable 
starting dates instead of the latest date.  It also violates the 
assumptions required to use bisect() on the keys.  I solve 
my problem by adding an "allKeys.sort()" after getting the 
keys. 
 
I assume that the keys are expected to be in order? 
(Hence I'm not convinced I've understood the real problem, 
let alone solved the problem!) 
 
This also probably explains why I can't (usually) use any 
of the query functionality on the home page?  It often 
returned the "message may have been deleted" message. 
 
The things I am doing that may qualify as "not typical": 
1) I'm running from CVS. 
2) I'm running on Linux. 
3) I expire messages in the cache after a VERY long time. 
4) I almost never "forget" any messages AND only train on 
unsures/mistakes and none extreme correctly classified 
stuff.  Hence I have over a months worth of web pages 
available for review. 
 
I've attached the diff of my hacked version of ProxyUI.py 
with debug stuff and the sort inserted. 

----------------------------------------------------------------------

>Comment By: Tony Meyer (anadelonbrin)
Date: 2004-01-07 19:02

Message:
Logged In: YES 
user_id=552329

I believe this is my fault.  I made various changes to the 
sorting with what was once the 1.1a1 line so that you can 
now sort a page by column.  I believe I introduced this then.

I've checked in the one line fix, thanks.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=872044&group_id=61702