[spambayes-bugs] [ spambayes-Patches-831941 ] Empty Spam Folder menu item

[SourceForge.net]

Patches item #831941, was opened at 2003-10-28 16:18
Message generated for change (Comment added) made by kpitt
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498105&aid=831941&group_id=61702

Category: Outlook
Group: None
Status: Open
Resolution: None
Priority: 3
Submitted By: Kenny Pitt (kpitt)
Assigned to: Mark Hammond (mhammond)
Summary: Empty Spam Folder menu item

Initial Comment:
RFE 788755 asks for a menu item to empty the spam 
folder, and I have seen this requested several times on 
the lists.  I've come up with an initial patch to implement 
this as a menu item on the SpamBayes dropdown.  It 
works very much like the Empty "Deleted Items" Folder 
context menu item, which means it prompts with a 
Yes/No message box before deleting, and just does 
nothing if the spam folder is already empty. 

This seems to work well on my Outlook 2003 setup, but 
probably needs more wide-spread testing before being 
considered entirely stable.

----------------------------------------------------------------------

>Comment By: Kenny Pitt (kpitt)
Date: 2003-12-17 11:34

Message:
Logged In: YES 
user_id=859086

I knew there had to be a way to generate a combined patch 
file, but didn't know the syntax.  Thanks.  I made the 
AskQuestion/_GetParent changes, and uploaded a partially 
updated patch pending the following questions/comments.  
This is now diff'ed against latest CVS updates from 
anonymous.

I didn't want to do anything "silently" that could irretrievably 
remove messages, but I also didn't want to display a removal 
confirmation question when there was nothing to remove.  I 
added the check for items to avoid the unnecessary 
confirmation, which matches Outlook's Deleted Items 
behavior.  I'd rather not call EmptyFolder silently, but I'll be 
glad to add a message box indicating that there are no items 
to remove if you think it's needed.  I would have preferred to 
just disable the menu item if the folder is empty, but it 
seemed like it would be a lot of trouble to track it properly 
and keep the menu state updated.

I added the print statements for logging so that I could check 
for any problems, and also so that we could diagnose future 
user problems such as, "I used Empty Spam Folder, but the 
spam messages didn't get deleted."  I noticed that there is a 
mixture in addin.py of print and LogDebug.  What are the 
current guidelines for which to use?

----------------------------------------------------------------------

Comment By: Mark Hammond (mhammond)
Date: 2003-12-17 02:18

Message:
Logged In: YES 
user_id=14198

This looks like a good start.  manager.py has _GetParent and
AskQuestion - can you update the patch to use these.  Also,
if no items are in the folder, we should display a message
to the user rather than a simple 'print'.  In fact, I see no
real good reason to have the check for items - even with no
items, still silently call EmptyFolder, and if there are no
items, then big deal - the folder is still empty after the
event, so we can consider that it worked Ok.

If possible, attach a patch as a single file - just "cvs -z5
diff -u file1.py file2.py > whatever.patch", then just
upload the .patch (or .diff)

Thanks

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498105&aid=831941&group_id=61702