[Security-sig] Implementation of the PEP 524

Nick Coghlan ncoghlan at gmail.com
Thu Aug 18 09:03:53 EDT 2016


On 18 August 2016 at 22:10, Nick Coghlan <ncoghlan at gmail.com> wrote:
> On 18 August 2016 at 03:16, Victor Stinner <victor.stinner at gmail.com> wrote:
>> 2016-08-17 18:39 GMT+02:00 Nick Coghlan <ncoghlan at gmail.com>:
>>> - if blocking *is* set, it prints a warning to stderr, before trying
>>> again without the GRND_NONBLOCK flag
>>
>> I implemented the PEP 524. Such warning is not part of the PEP.
>>
>> Sorry, but I'm not interested to reopen the discussion on the PEP
>> since the PEP was accepted...
>
> OK, I'll review it on that basis, and then submit a follow-up RFE and
> patch to add the warning.

Mostly +1 from me on the code and test changes in both patches (I did
have a few requests for clarification and confirmation, but nothing
major).

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia


More information about the Security-SIG mailing list