[SciPy-Dev] SciPy-Dev Digest, Vol 195, Issue 9

Mon Jan 13 12:40:59 EST 2020

> On Jan 13, 2020, at 12:00 PM, scipy-dev-request at python.org wrote:
> 
> Send SciPy-Dev mailing list submissions to
>    scipy-dev at python.org
> 
> To subscribe or unsubscribe via the World Wide Web, visit
>    https://mail.python.org/mailman/listinfo/scipy-dev
> or, via email, send a message with subject or body 'help' to
>    scipy-dev-request at python.org
> 
> You can reach the person managing the list at
>    scipy-dev-owner at python.org
> 
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of SciPy-Dev digest..."
> 
> 
> Today's Topics:
> 
>   1. Re: PR's fixing hypergeometric function (Matthew Brett)
>   2. Missing whitespace after commas in pycodestyle check
>      (Joshua Wilson)
>   3. Re: PR's fixing hypergeometric function (Tyler Reddy)
> 
> 
> ----------------------------------------------------------------------
> 
> Message: 1
> Date: Sun, 12 Jan 2020 17:56:36 +0000
> From: Matthew Brett <matthew.brett at gmail.com>
> To: SciPy Developers List <scipy-dev at python.org>
> Subject: Re: [SciPy-Dev] PR's fixing hypergeometric function
> Message-ID:
>    <CAH6Pt5oNu8A+ZQkSwZ1TgrhYLCzN54w_JZxoEVSVNbMF+Qb12Q at mail.gmail.com>
> Content-Type: text/plain; charset="UTF-8"
> 
> Hi,
> 
>> On Sun, Jan 12, 2020 at 4:39 PM Adam Kullberg <Former at physicist.net> wrote:
>> 
>> Hello guys,
>> 
>> Is there anything I can do to expedite these PR's?  They fix the
>> hypergeometric function and are a couple of years old. I am still
>> willing to make fixes if there is any appetite for these fixes.
>> 
>> https://github.com/scipy/scipy/pull/8548
>> 
>> https://github.com/scipy/scipy/pull/8151
>> 
>> https://github.com/scipy/scipy/pull/8110
>> 
>> Thank you!
> 
> It would be great to see these get in.
> 
> Cheers,
> 
> Matthew
> 
> 
> ------------------------------
> 
> Message: 2
> Date: Sun, 12 Jan 2020 16:43:43 -0800
> From: Joshua Wilson <josh.craig.wilson at gmail.com>
> To: SciPy Developers List <scipy-dev at python.org>
> Subject: [SciPy-Dev] Missing whitespace after commas in pycodestyle
>    check
> Message-ID:
>    <CAKFGQGxEb2gJJUsz1ZmVEi93YFN-WEky8vcm_qecPxpLBBA7sA at mail.gmail.com>
> Content-Type: text/plain; charset="UTF-8"
> 
> Hey everyone,
> 
> During code review, it seems that we care about missing whitespace
> after commas. (I have no data on this, but I suspect it is our most
> common linting nit.) Linting for this is currently disabled. Now on
> the one hand, we generally avoid turning on checks like this because
> of the disruption to open PRs and what they do to git history. On the
> other hand, I don't think enforcing this check by hand works.
> Reminding an author to add spaces after commas can easily add several
> rounds of extra review (some places almost invariably get missed on
> the first try, and then the problem tends to sneak back in in later
> commits), and I usually just give up after a while. So I don't think
> we are heading in the direction of "in 5 years all the bad cases will
> be gone and we can turn on the check without disruption".
> 
> So I would kind of like to push us to either:
> 
> 1. Turn the lint check on. We can do this module-by-module or even
> file-by-file if necessary to minimize disruption.
> 2. Declare that this is not something we care about in code review.
> 
> Thoughts?

Turning it on and the concomitant changes required might be a lot of work. Assuming that is true:

Mechanism to enforce on new prs could be a pre-commit hook in git that has the linter configurations used plus the one you mention. The pre-commit hook fails the commit locally if the linter fails. There are lots of examples on github using flake8/black linters.

If the disruption to enable is minimal then this may not be needed.

If we don’t care about spaces after comma the also not needed.
> - Josh
> 
> 
> ------------------------------
> 
> Message: 3
> Date: Sun, 12 Jan 2020 21:09:51 -0700
> From: Tyler Reddy <tyler.je.reddy at gmail.com>
> To: SciPy Developers List <scipy-dev at python.org>
> Subject: Re: [SciPy-Dev] PR's fixing hypergeometric function
> Message-ID:
>    <CAHPuU_Z=xr4H9EYOyoA4k12X3wnG00XUP++W1crnb+4U59V6RA at mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
> 
> I've added 1.5.0 milestones to the subset of those PRs lacking them to help
> prevent falling through the cracks. Fortran source adjustments are among
> the hardest for the team to review.
> 
>> On Sun, 12 Jan 2020 at 10:57, Matthew Brett <matthew.brett at gmail.com> wrote:
>> 
>> Hi,
>> 
>>> On Sun, Jan 12, 2020 at 4:39 PM Adam Kullberg <Former at physicist.net>
>>> wrote:
>>> 
>>> Hello guys,
>>> 
>>> Is there anything I can do to expedite these PR's?  They fix the
>>> hypergeometric function and are a couple of years old. I am still
>>> willing to make fixes if there is any appetite for these fixes.
>>> 
>>> https://github.com/scipy/scipy/pull/8548
>>> 
>>> https://github.com/scipy/scipy/pull/8151
>>> 
>>> https://github.com/scipy/scipy/pull/8110
>>> 
>>> Thank you!
>> 
>> It would be great to see these get in.
>> 
>> Cheers,
>> 
>> Matthew
>> _______________________________________________
>> SciPy-Dev mailing list
>> SciPy-Dev at python.org
>> https://mail.python.org/mailman/listinfo/scipy-dev
>> 
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20200112/8b12a5f0/attachment-0001.html>
> 
> ------------------------------
> 
> Subject: Digest Footer
> 
> _______________________________________________
> SciPy-Dev mailing list
> SciPy-Dev at python.org
> https://mail.python.org/mailman/listinfo/scipy-dev
> 
> 
> ------------------------------
> 
> End of SciPy-Dev Digest, Vol 195, Issue 9
> *****************************************