[SciPy-Dev] Github workflow

[Daπid]

On Thu, 10 Oct 2019 at 19:21, Todd <toddrjen at gmail.com> wrote:

>
>
> On Thu, Oct 10, 2019, 12:34 Daπid <davidmenhur at gmail.com> wrote:
>
>>
>>
>> On Thu, 10 Oct 2019 at 18:11, Todd <toddrjen at gmail.com> wrote:
>>
>>> On Thu, Oct 10, 2019 at 2:34 AM Andrew Nelson <andyfaff at gmail.com>
>>> wrote:
>>>
>>>> devs,
>>>> I'm involved in giving some feedback to Github at the moment, as
>>>> related to how SciPy users experience Github. Does anyone have any feedback
>>>> on:
>>>>
>>>> - Bugs / Feature requests - are there Github workflows you want to
>>>> enable? What's the specific feature you want?
>>>>
>>>> This would be an ideal opportunity to tell GIthub of those features
>>>> you'd really like to see fixed or implemented.
>>>>
>>>> A.
>>>>
>>>>
>>> The "quote reply" button in PR's doesn't add the name of the person you
>>> are talking to, nor does it link to the comment, and I can't find another
>>> way to make really threaded replies.  At the very least having quotes
>>> automatically tag the person being quoted so they get a notification about
>>> it, but better yet having some sort of threaded reply system outside of
>>> comments on particular lines, would be useful in my opinion.
>>>
>>> Also, although there is a way to comment on particular lines of code in
>>> a PR, I can't figure out a way to link to particular lines of code.  That
>>> would be useful.  For example someone asks a question in a comment on one
>>> line, you can link to another line that has the answer.
>>>
>>
>>
>> That you can do:
>> https://github.com/numpy/numpy/blob/master/numpy/core/machar.py#L128-L133
>>
>> And even a permalink to the specific commit:
>>
>>
>> https://github.com/numpy/numpy/blob/9451d6f26ab9ab1bd204bf1865ac743a5dff6ae0/numpy/core/machar.py#L128-L133
>>
>> To do this, click on the line number. Shift-click to select a range of
>> lines.
>>
>
> Yes, you can link to lines in the repository or a commit, but not in the
> pull request itself as far as I can tell.  I think it would be helpful when
> discussing the pull request to be able to link to a line inside the pull
> request interface.
>

If I am understanding what you mean correctly, same trick still works,
click on the line numbers:

https://github.com/numpy/numpy/pull/14657/files#diff-758e4b79c5a0e4db54723d82a8436418R3617-R3619
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20191010/60e48187/attachment-0001.html>