[SciPy-Dev] scipy stats tutorial

[Ralf Gommers]

On Sat, May 12, 2012 at 9:20 PM, nicky van foreest <vanforeest at gmail.com>wrote:

> > Could you remove the use of the extradoc parameter? It's not needed
> anymore,
> > and we'll probably get rid of it at some point. Looking at the docstring
> can
> > be done with help() in the Python interpreter or "?" in IPython.
>
> I have removed it.
>

Thanks. Looks like you still have to push that change to Github.

>
> > Note that when you push commits to a branch on Github from which you have
> > already made a pull request, those commits are added to that PR. So yours
> > ended up at https://github.com/scipy/scipy/pull/205. Which is fine with
> me,
> > since it's related anyway. And diffs are always good to have.
>
> I was not aware of this. I hope the commits are separated, though,
> just to separate the different changes (some wrt distribututions.py
> and some wrt the tutorial). So I suppose that I could/should have
> prevented this by making a new branch.
>
> Yes, one commit stays one commit, no merging of those behind the scenes.
So it should look fine. You should normally indeed make a new branch when
you start working on some unrelated changes.

Ralf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20120512/031b99e3/attachment.html>