[SciPy-Dev] Bug in KDTree

[Ralf Gommers]

On Sun, Jan 9, 2011 at 5:40 AM, Benjamin Root <ben.root at ou.edu> wrote:

> On Sat, Jan 1, 2011 at 5:47 AM, Ralf Gommers <ralf.gommers at googlemail.com>wrote:
>
>>
>>
>> On Sat, Jan 1, 2011 at 3:30 AM, Benjamin Root <ben.root at ou.edu> wrote:
>>
>>>
>>>
>>> On Fri, Dec 10, 2010 at 4:54 PM, Benjamin Root <ben.root at ou.edu> wrote:
>>>
>>>> Hello,
>>>>
>>>> I came across an issue using KDTree.  I searched the bug list, and it
>>>> appears that there has already been a patch submitted for review.  I have
>>>> added comments to the bug report and I think the patch is good to go.  I am
>>>> not an expert in KDTree myself, but I think the logic is sound.
>>>>
>>>> http://projects.scipy.org/scipy/ticket/1052
>>>>
>>>> If the first node of the tree is a leafnode, then query_pairs() will
>>>> fail if the points are closer than the distance threshold.  This is because
>>>> the algorithm is assuming that the first node will always be an innernode.
>>>> By rearranging the if-statements so that a check for a leafnode is done
>>>> first, you protect against such a situation.
>>>>
>>>> At least, that is my understanding.  I welcome comments on this.
>>>>
>>>> Thanks,
>>>> Ben Root
>>>>
>>>
>>> I am re-pinging this.  Is there any chance this will make it to the
>>> upcoming release?  I am very certain the patch given 6 months ago is
>>> correct.
>>>
>>> It can go in I think. I'll check and apply before RC1 if no one beats me
>> to it.
>>
>> Cheers,
>> Ralf
>>
>>
> This still hasn't been committed yet...
>
> It's still 6 days to RC1 and I came home from holiday + business trip last
night..... don't worry just yet.

Ralf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20110110/0c0ebcbb/attachment.html>