[SciPy-Dev] Another easy patch review: ticket #996

Robert Kern robert.kern at gmail.com
Sun Mar 21 17:08:12 EDT 2010


On Sun, Mar 21, 2010 at 15:51, Warren Weckesser
<warren.weckesser at enthought.com> wrote:
> I added a patch to ticket #996 that implements the change discussed
> there.  The change to the code is trivial; the main issue is that
> everyone else agrees that the `find` function should return the list of
> keys instead of printing them.  Personally I think it's another no-brainer.

Requests for "no-brainer" reviews tend to go faster when they include
a link to the ticket. :-)

Anyways, +1 on the patch.

-- 
Robert Kern

"I have come to believe that the whole world is an enigma, a harmless
enigma that is made terrible by our own mad attempt to interpret it as
though it had an underlying truth."
  -- Umberto Eco



More information about the SciPy-Dev mailing list