[scikit-learn] Code review

Raghav R V ragvrv at gmail.com
Thu Jun 23 08:47:35 EDT 2016


> "nag if needed"!

I always assume it to be an implicit advice ;P

On Wed, Jun 22, 2016 at 9:39 PM, Andreas Mueller <t3kcit at gmail.com> wrote:

> Sorry, I've been off review duty for a while, should be back later this
> summer ;)
>
>
> On 06/21/2016 12:09 AM, olologin wrote:
>
>> Hi guys, I know scikit-learn may not be your main project, and you all
>> are very busy at work so you don't have free time to review all pull
>> requests, I understand it.
>>
>> Is there something project leaders can do to speed-up review process?
>> Because I have bunch of pull requests which I made 5-7 months ago, and they
>> are relatively useful :), but they wasn't reviewed. Some of them are quite
>> simple for review (~10 lines in python), and still have only 1 vote. Maybe
>> it's possible to increase size of team which have permission to review? Or
>> all I can do is just wait? :)
>>
>> I'm writing this letter because yesterday one guy complained about this
>> in one of my PR's (I forgot about that PR by the time)
>> https://github.com/scikit-learn/scikit-learn/pull/6116#issuecomment-227044224
>> .
>> _______________________________________________
>> scikit-learn mailing list
>> scikit-learn at python.org
>> https://mail.python.org/mailman/listinfo/scikit-learn
>>
>
> _______________________________________________
> scikit-learn mailing list
> scikit-learn at python.org
> https://mail.python.org/mailman/listinfo/scikit-learn
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scikit-learn/attachments/20160623/baf0ebd8/attachment.html>


More information about the scikit-learn mailing list