[scikit-image] How to move pull requests forward (devs, please read)

Juan Nunez-Iglesias jni.soma at gmail.com
Fri Apr 14 19:43:13 EDT 2017


My concern with fully automated tools is that they tend to be overly stringent. There's many places where we violate PEP8 for valid stylistic reasons, e.g. to align the values of an array literal.

btw Stéfan, how's the PR for using PEP8speaks only for the diff?

On 15 Apr 2017, 9:40 AM +1000, Stefan van der Walt <stefanv at berkeley.edu>, wrote:
> On Fri, Apr 14, 2017, at 15:23, Nathaniel Smith wrote:
> > On Apr 14, 2017 9:12 AM, "Stefan van der Walt" <stefanv at berkeley.edu> wrote:
> > > On Fri, Apr 14, 2017, at 00:14, Nathaniel Smith wrote:
> > > > I wonder if it would be worthwhile to have a bot that automatically
> > > > pushes formatting fixes to submitted PRs (using autopep8 or yapf).
> > >
> > > That'd be great; do you know if such a thing exists?
> >
> > I don't know of any off the shelf implementation of this, no.
>
> Oh, we already have it!
>
> https://github.com/OrkoHunter/pep8speaks
>
> Just type
>
> @pep8speaks pep8ify
>
> as a comment, and you get a PR back.
>
> Stéfan
>
> _______________________________________________
> scikit-image mailing list
> scikit-image at python.org
> https://mail.python.org/mailman/listinfo/scikit-image
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scikit-image/attachments/20170415/0d1fe7f2/attachment-0001.html>


More information about the scikit-image mailing list