From andreas.roehler at online.de Mon Jan 7 09:56:06 2019 From: andreas.roehler at online.de (=?UTF-8?Q?Andreas_R=c3=b6hler?=) Date: Mon, 7 Jan 2019 15:56:06 +0100 Subject: [Python-mode] Dropping position functions Message-ID: <4350222c-ee22-8a83-4451-ce4c22049b17@online.de> Hi all, while in another re-write WRT speed and maintenance --see my previous post-- stumble over? a couple of functions reporting position like `py--beginning-of-if-block-position' - which doesn't look useful. Consider to drop them. Any objections? Happy new year, Andreas -------------- next part -------------- An HTML attachment was scrubbed... URL: From barry at python.org Mon Jan 7 13:10:28 2019 From: barry at python.org (Barry Warsaw) Date: Mon, 7 Jan 2019 13:10:28 -0500 Subject: [Python-mode] Dropping position functions In-Reply-To: <4350222c-ee22-8a83-4451-ce4c22049b17@online.de> References: <4350222c-ee22-8a83-4451-ce4c22049b17@online.de> Message-ID: <074E50FE-D4CE-42EF-A047-795745CF390B@python.org> On Jan 7, 2019, at 09:56, Andreas R?hler wrote: > > while in another re-write WRT speed and maintenance --see my previous post-- stumble over a couple of functions reporting position like `py--beginning-of-if-block-position' - which doesn't look useful. Consider to drop them. Any objections? AFAIK, I don?t use them, so I don?t have any particular objections. BTW, I am playing with built-in python.el just to see what the main differences are these days. I ran into this one pretty quickly: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33979 Cheers, -Barry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: Message signed with OpenPGP URL: From andreas.roehler at online.de Tue Jan 8 02:52:31 2019 From: andreas.roehler at online.de (=?UTF-8?Q?Andreas_R=c3=b6hler?=) Date: Tue, 8 Jan 2019 08:52:31 +0100 Subject: [Python-mode] Dropping position functions In-Reply-To: <074E50FE-D4CE-42EF-A047-795745CF390B@python.org> References: <4350222c-ee22-8a83-4451-ce4c22049b17@online.de> <074E50FE-D4CE-42EF-A047-795745CF390B@python.org> Message-ID: <82ad958e-6b99-7f9e-6635-3baeaf1e0c0f@online.de> On 07.01.19 19:10, Barry Warsaw wrote: > On Jan 7, 2019, at 09:56, Andreas R?hler wrote: >> while in another re-write WRT speed and maintenance --see my previous post-- stumble over a couple of functions reporting position like `py--beginning-of-if-block-position' - which doesn't look useful. Consider to drop them. Any objections? > AFAIK, I don?t use them, so I don?t have any particular objections. Okay, thanks. As this part is generated by in `py-write-beginning-position-forms' from devel/python-mode-utils.el it might be re-installed any time. > > BTW, I am playing with built-in python.el just to see what the main differences are these days. I ran into this one pretty quickly: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33979 Yes, noticed your report. Confirmed. AFAIK python-mode.el runs a lot more and deeper tests - i.e. integration tests. See run-travis-ci.sh -------------- next part -------------- An HTML attachment was scrubbed... URL: