[Python-mode] M-x beginning-of-defun

[Barry Warsaw]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Nov 29, 2008, at 12:02 PM, Andreas Roehler wrote:

> `beginning-of-defun-raw' in GNU Emacs has a nice
> feature, enabling functions instead of regexps to
> determine beginning and end of defun, i.e. function or form.
>
> In python-mode.el I see you solved this by binding the
> beginning- and end-of-defun keys seperatly.
> (Maybe, because XEmacs lacks this feature?)
>
> However, this lets commands like M-x beginning-of-defun
> empty.
>
> My suggestion is to follow GNU conventions here, by
> introducing the missing forms in XEmacs lisp.el and
> python-mode.el alike.
>
> Herewith a patch against latest python-mode.el, which I
> enjoy, thanks BTW.
>
> Also a patch against latest XEmacs lisp.el.

Thanks for the contribution Andreas, but I don't think we can accept a  
patch that relies on patching XEmacs.  I don't have the energy for  
that.  ;)

Can you rewrite the patch so that it doesn't rely on a XEmacs change?   
Also, please open a bug on Launchpad and attach the patch to that, or  
create a branch with your changes that would be easy for us to review  
and merge.  Having patches sitting in an inbox is a surefire way to  
have it get lost.

Thanks,
Barry

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)

iQCVAwUBSTGOgnEjvBPtnXfVAQLlxAP+J7UUfTG6Ph44w5fKw+LdTdgCtPaeui05
2QjxHc13GUivvGR3kFP7seqfGnMLFy2MIpU/O4HBQ+nQHrHmEHy+tYfSOjimbo/m
54azM0BczDi+B7KeQWBxgMpS6SzMPGqdtDJ/PQlwupMGJW8FHtqPm8q28XQ+Ww1s
NjIbF+jc74U=
=lris
-----END PGP SIGNATURE-----