[Python-mode] py-newline-and-close-THING

[Andreas Roehler]

Barry Warsaw wrote:
> On Dec 4, 2008, at 1:53 PM, Andreas Roehler wrote:
> 
>> seeing your announcement of "Python 3.0 final" I imagine
>> you being busy with other stuff...
> 
>> Let's see if we can figure out how to contribute here
>> nonetheless.
> 
>> Probably I got rights to check in already some months
>> ago.
> 
>> However, I'm still hesitating, as it's not a matter of
>> bugs alone.
> 
>> Different people usually have different opinions how
>> the code should look like.
> 
>> May I check in `py-newline-and-close-block' and the
>> functions mentioned in this line?
> 
>> Too I would refactor the existing code a little bit:
>> Split up functions to make them better readable, easier
>> to maintain and extend.
> 
>> What about --given I have the rights already-- if I
>> send patches to this list, wait a week and check in if
>> no one objects?
> 
> The way I'd really like to see contributions like this handled is by
> using the features in Launchpad and Bazaar most effectively, like so:
> 
> * Open a bug on http://bugs.launchpad.net/python-mode for this enhancement
> * Create a branch of the main line: bzr branch lp:python-mode
> * <hack> <hack> <hack>
> * Commit your changes locally: bzr commit --fixes=lp:123456
> * Push your branch to Launchpad: bzr push
> lp:~<you>/python-mode/py-newline-and-close
> * Create a merge proposal for your branch, requesting review e.g. from
> me or skip
> * Wait for the reviewer to approve it, addressing any issues that come up
> * Once it's approved, merge it into the main line, commit and push
> * Close the bug
> 
> I know it sounds like a lot, but it's really a fairly smooth workflow,
> and bzr can help a lot with that (there are plans to make it even
> easier).  The nice thing about all this is that there are artifacts we
> can use to track everything and we don't have to rely on people's
> inboxes to make decisions.
> 
> Can you give this a try?
> -Barry
> 

Sure, let's go on, thanks.

Andreas