code review

[Alister]

On Fri, 29 Jun 2012 09:03:22 -0600, Littlefield, Tyler wrote:

> On 6/29/2012 1:31 AM, Steven D'Aprano wrote:
>> On Thu, 28 Jun 2012 20:58:15 -0700, alex23 wrote:
>>
>>> On Jun 29, 12:57 pm, "Littlefield, Tyler" <ty... at tysdomain.com> wrote:
>>>> I was curious if someone wouldn't mind poking at some code. The
>>>> project page is at:http://code.google.com/p/pymud Any information is
>>>> greatly appreciated.
>>> I couldn't find any actual code at that site, the git repository is
>>> currently empty.
> 
> OOPS, sorry. Apparently I'm not as good with git as I thought.
> Everything's in the repo now.

I think I may be on firmer grounds with the next few:

isValidPassword can be simplified to

def isValidPassword(password:
	count=len(password)
	return count>= mud.minpass and count<= mud.maxpass

( I used count to save finding the length of password twice although it 
probably makes no difference in this scenario)

similar construct can be used for isValidUser

def isValidUser(name):
	if name.isalpha():
		count=len(name)
		return count>=mud.minname and count >mud.maxname
	return False


-- 
No one wants war.
		-- Kirk, "Errand of Mercy", stardate 3201.7