code review

Alister alister.ware at ntlworld.com
Fri Jun 29 16:43:02 EDT 2012


On Fri, 29 Jun 2012 13:27:54 -0700, Martin P. Hellwig wrote:

> On Friday, 29 June 2012 20:41:11 UTC+1, Alister  wrote:
>> On Fri, 29 Jun 2012 09:03:22 -0600, Littlefield, Tyler wrote:
>> 
>> > On 6/29/2012 1:31 AM, Steven D'Aprano wrote:
>> >> On Thu, 28 Jun 2012 20:58:15 -0700, alex23 wrote:
>> >>
>> >>> On Jun 29, 12:57 pm, "Littlefield, Tyler" <ty... at tysdomain.com>
>> >>> wrote:
>> >>>> I was curious if someone wouldn't mind poking at some code. The
>> >>>> project page is at:http://code.google.com/p/pymud Any information
>> >>>> is greatly appreciated.
>> >>> I couldn't find any actual code at that site, the git repository is
>> >>> currently empty.
>> > 
>> > OOPS, sorry. Apparently I'm not as good with git as I thought.
>> > Everything's in the repo now.
>> 
>> I am no expert but from what have picked up so far
>> 
>> from x import
>> 
>>  is frowned upon in most cases
> 
> from x import * is frowned upon, however, from x import y is fine IMHO.
>> 
well I said I was no expert & picking things up. re investigation I see 
your reasoning and yes it was the from X import * I was thinking of.
 
Although a simple import X retaining the name-space ref does make it easy 
to identify the origins of a function (at the expense of more typing)
-- 
Flying is the second greatest feeling you can have.  The greatest feeling?
Landing...  Landing is the greatest feeling you can have.



More information about the Python-list mailing list