Style formating of multiline query, advise

[Tino Wildenhain]

John Machin wrote:
> On Mar 18, 11:25 pm, someone <petshm... at googlemail.com> wrote:
>> Hi,
>>
>> what is good :) style for multiline queries to database?
>> Is that one ok?
>> query = """ SELECT * FROM (
>>                    SELECT a.columna, a.columnb, a.iso
>>                       FROM all a
>>                       WHERE (a.name = LOWER(%s))  ) AS c
>>                  JOIN other as b on c.gid = b.id
>>                  WHERE class = 'A'
>>                  ORDER BY population DESC
>>                  LIMIT %s;"""
> 
> There's no tablet of stone, like PEP 8 :-) It seems to be a matter of
> individual taste; clarity and consistency and not overdoing
> parentheses count for me.
> 
> IMO you have too much leading whitespace, you have "as" in upper,
> lower and no case, and I'd set out the inner select differently:
> 
> query = """
>     SELECT * FROM (
>         SELECT a.columna, a.columnb, a.iso
>         FROM all AS a
>         WHERE a.name = LOWER(%s)
>         ) AS c
>     JOIN other AS b ON c.gid = b.id
>     WHERE class = 'A'
>     ORDER BY population DESC
>     LIMIT %s;
> """

And I'd not recomment SELECT * for anything beside test queries in an
interactive session or if you are going to copy tables...

Regards
Tino
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3241 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://mail.python.org/pipermail/python-list/attachments/20090318/c1330b5e/attachment-0001.bin>