Help cleaning up some code
odeits
odeits at gmail.com
Fri Mar 6 23:55:51 EST 2009
I am looking to clean up this code... any help is much appreciated.
Note: It works just fine, I just think it could be done cleaner.
The result is a stack of dictionaries. the query returns up to
STACK_SIZE ads for a user. The check which i think is very ugly is
putting another contraint saying that all of the ni have to be the
same.
stack = []
rows = self.con.execute(adquerystring,(user,STACK_SIZE)).fetchall()
for row in rows:
ad = dict()
ad['ni'] = row['ni']
ad['adid'] = row['adid']
ad['rundateid'] = row['rundateid']
ad['rundate'] = row['rundate']
if row['city'] is None:
ad['city'] = 'None'
else:
ad['city'] = row['city']
if row['state'] is None:
ad['state'] = 'None'
else:
ad['state'] = row['state']
ad['status'] = row['status']
try:
if stack[0]['ni'] != ad['ni']:
break;
except IndexError:
pass
stack.append(ad)
More information about the Python-list
mailing list