[python-ldap] syncrepl fix for pyasn1 >= 0.3
Ilya Etingof
ilya at glas.net
Sat Nov 11 16:41:04 EST 2017
LGTM.
I’d only suggest slight re-wording for this piece of code:
self.result = int(p.getComponentByName('virtualListViewResult'))
self.result_code = p.getComponentByName(‘virtualListViewResult’).prettyOut(self.result)
Into something like this mostly for clarity:
self.result = int(p.getComponentByName('virtualListViewResult'))
self.result_code = p.getComponentByName(‘virtualListViewResult’).prettyPrint()
ps. I’m working on adding defaults to the pyasn1 getters.
> On 11 Nov 2017, at 21:31, Michael Ströder <michael at stroeder.com> wrote:
>
> Although I'm not happy with all the if-statements I've committed a
> slightly modified version of your submitted patch.
>
> Please review CVS HEAD now!
>
> Ciao, Michael.
>
> P.S.:
> Yes, I will provide another VCS repo soon because SF shuts down CVS at
> 2017-11-30.
>
More information about the python-ldap
mailing list