[Python-ideas] Improving fn(arg=arg, name=name, wibble=wibble) code
Jonathan Fine
jfine2358 at gmail.com
Sat Sep 8 13:52:28 EDT 2018
OK. Here's another piece of code to look at, from a URL that Kyle
Lahnakoski posted to a different thread.
<code>
https://github.com/django/django/blob/master/django/contrib/admin/options.py#L1477-L1493
def get_inline_formsets(self, request, formsets, inline_instances,
obj=None):
inline_admin_formsets = []
for inline, formset in zip(inline_instances, formsets):
fieldsets = list(inline.get_fieldsets(request, obj))
readonly = list(inline.get_readonly_fields(request, obj))
has_add_permission = inline._has_add_permission(request, obj)
has_change_permission = inline.has_change_permission(request, obj)
has_delete_permission = inline.has_delete_permission(request, obj)
has_view_permission = inline.has_view_permission(request, obj)
prepopulated = dict(inline.get_prepopulated_fields(request, obj))
inline_admin_formset = helpers.InlineAdminFormSet(
inline, formset, fieldsets, prepopulated, readonly,
model_admin=self,
has_add_permission=has_add_permission,
has_change_permission=has_change_permission,
has_delete_permission=has_delete_permission,
has_view_permission=has_view_permission,
)
inline_admin_formsets.append(inline_admin_formset)
return inline_admin_formsets
</code>
How can we make this code better? Again, ideas please, and no
discussion of "which is best". (We can get to that later.)
--
Jonathan
More information about the Python-ideas
mailing list