[Python-Dev] Can we use "designated initializer" widely in core modules?

Victor Stinner victor.stinner at gmail.com
Tue Jan 17 20:16:28 EST 2017


2017-01-18 1:59 GMT+01:00 INADA Naoki <songofacandy at gmail.com>:
> I think mixing two forms is OK only if new form is used only at bottom.
> (like keyword arguments are allowed after all positional arguments in
> Python function calling)
>
> Complete rewriting makes diff huge.  And there is PyVarObject_HEAD_INIT already.

I'm in favor of replacing all long list of fields with the /* tp_xxx
*/ comments to use designated initializers. It would allow to remove a
lot of "0,     /* tp_xxx */" lines and make the code much more
readable! It should help to prevent bugs when the code is modified.

Victor


More information about the Python-Dev mailing list