[Python-Dev] [Python-checkins] cpython: Use HTTP in testPythonOrg

[Victor Stinner]

I just noticed a failure on a recent Windows build:
http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/11620/steps/test/logs/stdio

"urllib.error.URLError: <urlopen error [SSL:
CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:747)>"

So I guess that the change is to restrict the unit test on parsing the
robot failed and not test the SSL module.

Am I right?

Victor


2016-09-11 14:58 GMT+02:00 Eric V. Smith <eric at trueblade.com>:
> Hi, Berker.
>
> Could you add a comment to the test on why this should use http? I can see
> this bouncing back and forth between http and https, as people clean an up
> all http usages to be https.
>
> Thanks.
> Eric.
>
> On 9/11/2016 8:46 AM, berker.peksag wrote:
>>
>> https://hg.python.org/cpython/rev/bc085b7e8fd8
>> changeset:   103634:bc085b7e8fd8
>> user:        Berker Peksag <berker.peksag at gmail.com>
>> date:        Sun Sep 11 15:46:47 2016 +0300
>> summary:
>>   Use HTTP in testPythonOrg
>>
>> files:
>>   Lib/test/test_robotparser.py |  2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>>
>> diff --git a/Lib/test/test_robotparser.py b/Lib/test/test_robotparser.py
>> --- a/Lib/test/test_robotparser.py
>> +++ b/Lib/test/test_robotparser.py
>> @@ -276,7 +276,7 @@
>>          support.requires('network')
>>          with support.transient_internet('www.python.org'):
>>              parser = urllib.robotparser.RobotFileParser(
>> -                "https://www.python.org/robots.txt")
>> +                "http://www.python.org/robots.txt")
>>              parser.read()
>>              self.assertTrue(
>>                  parser.can_fetch("*",
>> "http://www.python.org/robots.txt"))
>>
>>
>>
>> _______________________________________________
>> Python-checkins mailing list
>> Python-checkins at python.org
>> https://mail.python.org/mailman/listinfo/python-checkins
>>
>
> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> https://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe:
> https://mail.python.org/mailman/options/python-dev/victor.stinner%40gmail.com