[Python-Dev] O(1) deletes from the front of bytearray (was: Re: Adding bytes.frombuffer() constructor to PEP 467 (was: [Python-ideas] Adding bytes.frombuffer() constructor)
Serhiy Storchaka
storchaka at gmail.com
Wed Oct 12 03:17:12 EDT 2016
On 12.10.16 09:31, Nathaniel Smith wrote:
> But amortized O(1) deletes from the front of bytearray are totally
> different, and more like amortized O(1) appends to list: there are
> important use cases[1] that simply cannot be implemented without some
> feature like this, and putting the implementation inside bytearray is
> straightforward, deterministic, and more efficiently than hacking
> together something on top. Python should just guarantee it, IMO.
>
> -n
>
> [1] My use case is parsing HTTP out of a receive buffer. If deleting
> the first k bytes of an N byte buffer is O(N), then not only does
> parsing becomes O(N^2) in the worst case, but it's the sort of O(N^2)
> that random untrusted network clients can trigger at will to DoS your
> server.
Deleting from buffer can be avoided if pass the starting index together
with the buffer. For example:
def read_line(buf: bytes, start: int) -> (bytes, int):
try:
end = buf.index(b'\r\n', start)
except ValueError:
return b'', start
return buf[start:end], end+2
More information about the Python-Dev
mailing list