[Python-Dev] Inconsistency of PyModule_AddObject()

Nick Coghlan ncoghlan at gmail.com
Wed Apr 27 09:10:55 EDT 2016


On 27 April 2016 at 23:08, Nick Coghlan <ncoghlan at gmail.com> wrote:
> On 27 April 2016 at 17:14, Serhiy Storchaka <storchaka at gmail.com> wrote:
>> I think that we can resolve this issue by following steps:
>>
>> 1. Add a new function PyModule_AddObject2(), that steals a reference even on
>> failure.
>
> I'd suggest a variant on this that more closely matches the
> PyList_SetItem and PyTuple_SetItem cases: PyModule_SetAttrString

And for the record: that suggestion was prompted by Hrvoje's email
suggesting using a more descriptive name, I just went and looked up
the name of the corresponding PyObject_* API.

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia


More information about the Python-Dev mailing list