[Python-Dev] [Python-checkins] cpython: no one passes NULL here (or should anyway)

[Benjamin Peterson]

2011/7/3 Nick Coghlan <ncoghlan at gmail.com>:
> On Mon, Jul 4, 2011 at 12:54 PM, Benjamin Peterson <benjamin at python.org> wrote:
>> 2011/7/3 Nick Coghlan <ncoghlan at gmail.com>:
>>> May need to replace that with an assert(f != NULL) to keep static
>>> analysers happy.
>>
>> Surely static analyzers don't assume every argument passed in is NULL?
>
> I didn't check - was this change in a static function? For those, I
> think they can figure it out. For functions exposed to the linker, I
> think they demand an explicit check for a non-NULL pointer (which may
> be in the form of an assertion).

If someone's static analysis tool starts complaining about it, I'd be
happy to consider adding an assert...


-- 
Regards,
Benjamin