[Python-Dev] [Python-checkins] r87980 - in python/branches/py3k/Lib/importlib: _bootstrap.py abc.py

[Michael Foord]

On 13/01/2011 13:21, Jim Jewett wrote:
> Why?
>
> Are annotations being deprecated in general?  Or are these particular
> annotations no longer accurate?

See issue 10899.

http://bugs.python.org/issue10899

Annotations are not deprecated but there is no accepted convention on 
their use (plus third party developers are free to create whatever use 
cases they want for annotations) so annotations are being kept out of 
the standard library. Particularly given that they were untested and unused.

All the best,

Michael Foord

> -jJ
>
> On Wed, Jan 12, 2011 at 9:31 PM, raymond.hettinger
> <python-checkins at python.org>  wrote:
>> Author: raymond.hettinger
>> Date: Thu Jan 13 03:31:25 2011
>> New Revision: 87980
>>
>> Log:
>> Issue 10899: Remove function type annotations from the stdlib
>>
>> Modified:
>>    python/branches/py3k/Lib/importlib/_bootstrap.py
>>    python/branches/py3k/Lib/importlib/abc.py
>>
>> Modified: python/branches/py3k/Lib/importlib/_bootstrap.py
>> ==============================================================================
>> --- python/branches/py3k/Lib/importlib/_bootstrap.py    (original)
>> +++ python/branches/py3k/Lib/importlib/_bootstrap.py    Thu Jan 13 03:31:25 2011
>> @@ -345,7 +345,7 @@
>>
>>   class SourceLoader(_LoaderBasics):
>>
>> -    def path_mtime(self, path:str) ->  int:
>> +    def path_mtime(self, path):
>>          """Optional method that returns the modification time for the specified
>>          path.
>>
>> @@ -354,7 +354,7 @@
>>          """
>>          raise NotImplementedError
>>
>> -    def set_data(self, path:str, data:bytes) ->  None:
>> +    def set_data(self, path, data):
>>          """Optional method which writes data to a file path.
>>
>>          Implementing this method allows for the writing of bytecode files.
>>
>> Modified: python/branches/py3k/Lib/importlib/abc.py
>> ==============================================================================
>> --- python/branches/py3k/Lib/importlib/abc.py   (original)
>> +++ python/branches/py3k/Lib/importlib/abc.py   Thu Jan 13 03:31:25 2011
>> @@ -18,7 +18,7 @@
>>      """Abstract base class for import loaders."""
>>
>>      @abc.abstractmethod
>> -    def load_module(self, fullname:str) ->  types.ModuleType:
>> +    def load_module(self, fullname):
>>          """Abstract method which when implemented should load a module."""
>>          raise NotImplementedError
>>
>> @@ -28,7 +28,7 @@
>>      """Abstract base class for import finders."""
>>
>>      @abc.abstractmethod
>> -    def find_module(self, fullname:str, path:[str]=None) ->  Loader:
>> +    def find_module(self, fullname, path=None):
>>          """Abstract method which when implemented should find a module."""
>>          raise NotImplementedError
>>
>> @@ -47,7 +47,7 @@
>>      """
>>
>>      @abc.abstractmethod
>> -    def get_data(self, path:str) ->  bytes:
>> +    def get_data(self, path):
>>          """Abstract method which when implemented should return the bytes for
>>          the specified path."""
>>          raise NotImplementedError
>> @@ -63,19 +63,19 @@
>>      """
>>
>>      @abc.abstractmethod
>> -    def is_package(self, fullname:str) ->  bool:
>> +    def is_package(self, fullname):
>>          """Abstract method which when implemented should return whether the
>>          module is a package."""
>>          raise NotImplementedError
>>
>>      @abc.abstractmethod
>> -    def get_code(self, fullname:str) ->  types.CodeType:
>> +    def get_code(self, fullname):
>>          """Abstract method which when implemented should return the code object
>>          for the module"""
>>          raise NotImplementedError
>>
>>      @abc.abstractmethod
>> -    def get_source(self, fullname:str) ->  str:
>> +    def get_source(self, fullname):
>>          """Abstract method which should return the source code for the
>>          module."""
>>          raise NotImplementedError
>> @@ -94,7 +94,7 @@
>>      """
>>
>>      @abc.abstractmethod
>> -    def get_filename(self, fullname:str) ->  str:
>> +    def get_filename(self, fullname):
>>          """Abstract method which should return the value that __file__ is to be
>>          set to."""
>>          raise NotImplementedError
>> @@ -117,11 +117,11 @@
>>
>>      """
>>
>> -    def path_mtime(self, path:str) ->  int:
>> +    def path_mtime(self, path):
>>          """Return the modification time for the path."""
>>          raise NotImplementedError
>>
>> -    def set_data(self, path:str, data:bytes) ->  None:
>> +    def set_data(self, path, data):
>>          """Write the bytes to the path (if possible).
>>
>>          Any needed intermediary directories are to be created. If for some
>> @@ -170,7 +170,7 @@
>>          raise NotImplementedError
>>
>>      @abc.abstractmethod
>> -    def source_path(self, fullname:str) ->  object:
>> +    def source_path(self, fullname):
>>          """Abstract method which when implemented should return the path to the
>>          source code for the module."""
>>          raise NotImplementedError
>> @@ -279,19 +279,19 @@
>>          return code_object
>>
>>      @abc.abstractmethod
>> -    def source_mtime(self, fullname:str) ->  int:
>> +    def source_mtime(self, fullname):
>>          """Abstract method which when implemented should return the
>>          modification time for the source of the module."""
>>          raise NotImplementedError
>>
>>      @abc.abstractmethod
>> -    def bytecode_path(self, fullname:str) ->  object:
>> +    def bytecode_path(self, fullname):
>>          """Abstract method which when implemented should return the path to the
>>          bytecode for the module."""
>>          raise NotImplementedError
>>
>>      @abc.abstractmethod
>> -    def write_bytecode(self, fullname:str, bytecode:bytes) ->  bool:
>> +    def write_bytecode(self, fullname, bytecode):
>>          """Abstract method which when implemented should attempt to write the
>>          bytecode for the module, returning a boolean representing whether the
>>          bytecode was written or not."""
>> _______________________________________________
>> Python-checkins mailing list
>> Python-checkins at python.org
>> http://mail.python.org/mailman/listinfo/python-checkins
>>
> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> http://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe: http://mail.python.org/mailman/options/python-dev/fuzzyman%40voidspace.org.uk


-- 
http://www.voidspace.org.uk/

May you do good and not evil
May you find forgiveness for yourself and forgive others
May you share freely, never taking more than you give.
-- the sqlite blessing http://www.sqlite.org/different.html