[Python-Dev] [Python-checkins] r88395 - python/branches/py3k/Lib/asyncore.py

[Guido van Rossum]

On Fri, Feb 11, 2011 at 6:28 AM, Victor Stinner
<victor.stinner at haypocalc.com> wrote:
> Le vendredi 11 février 2011 à 14:52 +0100, Giampaolo Rodolà a écrit :
>> >> New Revision: 88395
>> >>
>> >> Log:
>> >> asyncore: introduce a new 'closed' attribute to make sure that dispatcher gets closed only once.
>> >> In different occasions close() might be called more than once, causing problems with already disconnected sockets/dispatchers.
>> > (...)
>> I'm sorry, I'm going to revert those checkins.
>> They are very minor changes which I'm sure don't break anything, but I
>> understand your complain.
>
> dispatcher.closing is a public attribute: some programs my rely on it. I
> checked mine: it uses "connected", but not closing :-)
>
> I think that it will be fine for Python 3.3, but not for 3.2 (too late).
> And you should document your change, because it is the public API.

And finally remember that asyncore is the most monkey-patched module
in the world. :-)

-- 
--Guido van Rossum (python.org/~guido)