[Python-Dev] PEP 3144 review.
Dj Gilcrease
digitalxero at gmail.com
Mon Sep 28 02:12:52 CEST 2009
Looking though the tests you have setup for ipaddr it is clear that
you want the following to be True
ip1 = ipaddr.IPv4Network('1.1.1.0/24')
ip2 = ipaddr.IPv4Network('1.1.1.1/24')
ip1 == ip2
based on this test
self.assertEquals(ip1.compare_networks(ip2), 0)
but your ><= operators all compare against _ip instead of network. I
submitted a patch for review @ http://codereview.appspot.com/124057
More information about the Python-Dev
mailing list