[Python-Dev] speeding up PyObject_GetItem

Raymond Hettinger python at rcn.com
Wed Mar 25 06:18:04 CET 2009


>>> 4% on a micro-micro-benchmark is hardly compelling...
>>
>> I concur!  This is utterly insignificant and certainly does
>> not warrant removing the checks.
>>
>> -1 on these sort of fake optimizations.  We should focus
>> on algorithmic improvements and eliminating redundant
>> work and whatnot.  Removing checks that were put there for a reason  
>> doesn't seem useful at all.
> 
> To be fair, the main proposed optimization(s) would speed up the  
> microbenchmark by 15-25% (Daniel already stated that the NULL checks  
> didn't have a significant impact).  This seems significant,  
> considering that tight loops whose cost is heavily due to array access  
> are common.

I thought people used PyList_GET_ITEM or something similar
in those use situations.


Raymond


More information about the Python-Dev mailing list