[Python-Dev] off-by-one on ftell on wine, but no regression test to catch it

Antoine Pitrou solipsis at pitrou.net
Sat Jan 17 21:58:04 CET 2009


Luke Kenneth Casson Leighton <lkcl <at> lkcl.net> writes:
> running under wine, ftell() has an off-by-one bug, where the file
> position accidentally doesn't include the fact that the CR of the CRLF
> has been skipped.  but, now with the fgets() bug fixed, the regression
> tests pass, but there's still the off-by-one bug which _isn't_ caught.

I don't understand why we should have a test for this. The regression tests are
meant to caught bugs in Python itself, not in the underlying OS libs... The only
reason to care about this would be if the aforementioned OS bug managed to crash
the interpreter.




More information about the Python-Dev mailing list