[Python-Dev] very bad network performance

[Curt Hagenlocher]

On Mon, Apr 14, 2008 at 9:12 AM, Ralf Schmitt <schmir at gmail.com> wrote:
>
> I've tracked it down to this change:
> http://hgpy.de/py/release25-maint/rev/e9446c6ab3cd
> this is svn revision 61009.
> [...]
> self._rbufsize if 1, and so the code reads one byte at a time

The change is correct, but exposes a flaw earlier in the same method.
"_rbufsize == 1" represents a request to buffer "by line", which is
clearly irrelevant in this context.  A request to read n bytes should
just use the default buffer size if buffering "by line".  Sample patch
is attached.


--
Curt Hagenlocher
curt at hagenlocher.org
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: socket.py.diff
Url: http://mail.python.org/pipermail/python-dev/attachments/20080414/4003efd8/attachment.txt