[Python-Dev] Proper place to put extra args for building

"Martin v. Löwis" martin at v.loewis.de
Wed Apr 20 23:08:57 CEST 2005


Brett C. wrote:
> The other option is to not make configure.in skip injecting arguments when a
> pydebug build is done based on whether OPT is defined in the environment.  So
> configure.in:670 could change to ``OPT="$OPT -g -Wall -Wstrict-prototypes"``.

That's a procedural question: do we want to accept environment settings
only when running configure, or do we also want to honor environment or
make command line settings when make is invoked. IOW, it is ok if

export OPT=-O6
./configure
make

works. But what about

./configure
export OPT=-O6
make

or

./configure
make OPT=-O6

All three can be only supported for environment variables that are never
explicitly set in Makefile, be it explicitly in Makefile.pre.in, or
implicitly through configure.

> The line for a non-debug build could stay as-is since if people are bothering
> to tweak those settings for a normal build they are going out of there way to
> tweak settings.  Seems like special-casing this for pydebug builds makes sense
> since the default values will almost always be desired for a pydebug build.
> And those rare cases you don't want them you could just edit the generated
> Makefile by hand.  Besides it just makes our lives easier and the special
> builds even more usual since it is one less thing to have to tweak.
> 
> Sound reasonable?

No. I thought you were talking about extra args, such as -fbrett-cannon.
But now you seem to be talking about arguments that replace the ones
that configure comes up with. Either of these might be reasonable, but
they require different treatment. Replacing configure results is
possible already


More information about the Python-Dev mailing list