[Python-Dev] Patch wanted

[Raymond Hettinger]

> Revision 1.29 
 . . .
> Tests the wrong thing
 . . .
> This affects any C compilers on Windows that don't have the uintptr_t
> and intptr_t types (those without the newer include file stdint.h)
> except VC 6.0. 


Here's a proposed patch:

--- pyconfig.h  23 Sep 2004 19:11:32 -0000      1.30
+++ pyconfig.h  15 Oct 2004 02:44:27 -0000
@@ -273,10 +273,12 @@

 /* VC 7.1 has them and VC 6.0 does not.  VC 6.0 has a version number of
1200.
    If some compiler does not provide them, modify the #if
appropriately. */
-#if _MSC_VER != 1200
+#if defined(_MSC_VER)
+#if _MSC_VER > 1200
 #define HAVE_UINTPTR_T 1
 #define HAVE_INTPTR_T 1
-#endif
+#endif  /* _MSC_VER > 1200  */
+#endif  /* _MSC_VER */

 #endif





> Ray Hettinger's fix 1.29 to PC/pyconfig.h
 . . .
> His test presumes 
 . . .

Please watch the personalisms.  I'm not the one who broke the build in
the first place.  Ideally, someone who knows all about the various
compilers can propose a generic fix so that a lot of the ifdeffery in
this file can be taken out.  For someone trying to repair a broken
build, they can often only test in one environment.



Raymond


Side note:  It looks like I may be the only one testing/maintaining the
MSVC++6.0 build.  It got broken again this week, so I have to fix it up
tonight (looks like a minor repair though).