[Python-Dev] RE: [Python-checkins] python/dist/src/Modules posixmodule.c, 2.300.8.10, 2.300.8.11

[Andrew MacIntyre]

On Fri, 17 Dec 2004, Raymond Hettinger wrote:

> The Dec 12th check-ins break tests on WinME:
>
>
> test_glob.py
> ------------
> Traceback (most recent call last):
>   File "test_glob.py", line 78, in test_glob_one_directory
>     eq(self.glob('a*'), map(self.norm, ['a', 'aab', 'aaa']))
>   File "test_glob.py", line 67, in assertSequencesEqual_noorder
>     self.assertEqual(set(l1), set(l2))
> AssertionError: set(['/tmp\\@test_dir\\aaa', '/tmp\\@test_dir\\aab',
> '/tmp\\@tes
> t_dir\\a']) != set(['\\tmp\\@test_dir\\aab', '\\tmp\\@test_dir\\aaa',
> '\\tmp\\@t
> est_dir\\a'])
>
>
> test_urllib.py
> --------------
> FAIL: test_basic (__main__.urlretrieve_FileTests)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "test_urllib.py", line 142, in test_basic
>     self.assertEqual(result[0], test_support.TESTFN)
> AssertionError: '\\tmp\\@test' != '/tmp\\@test'
>
>
>
> Please fix,

????

I don't see any possible way for those checkins to affect any platform
other than OS/2.

2 of the files are platform specific files (PC/os2emx/getpath.c,
PC/os2vacpp/getpath.c), and the checkin to Modules/posixmodule.c is
contained within a platform specific #if/#endif:

...
#ifdef HAVE_POPEN        <<<-- line 3241
...
#if defined(PYOS_OS2)
#if defined(PYCC_VACPP)
...                      <<<-- changes here
#elif defined(PYCC_GCC)
...
#endif /* PYCC_??? */
#elif defined(MS_WINDOWS)
...
#else /* which OS? */
...
#endif /* PYOS_??? */
#endif /* HAVE_POPEN */
...

Note that the posixmodule change affects popen().

The matching PC/getpath.c changes that apply to Windows were checked in by
Tim Peters back in August.

I don't have any Windows development environment, so can't cross check
your report :-(

If you have verified the cause of failure by backing out v2.300.8.11, then
there's a deeper problem about the Windows build picking up explicitly
non-Windows components - which I find hard to believe.

In the absence of more evidence, not guilty your honour.

-------------------------------------------------------------------------
Andrew I MacIntyre                     "These thoughts are mine alone..."
E-mail: andymac at bullseye.apana.org.au  (pref) | Snail: PO Box 370
        andymac at pcug.org.au             (alt) |        Belconnen ACT 2616
Web:    http://www.andymac.org/               |        Australia