[Python-Dev] add a bunch of tests to test_urlparse

Skip Montanaro skip@pobox.com
Mon, 18 Mar 2002 08:00:40 -0600


Bug 450225 references a bunch of URL parsing tests based on RFC 2396.  I've
added them to test_urlparse.py.  The problem is, two of them fail.  Should I

    * check in test_urlparse.py & create an output/test_urlparse that
      reflects those two errors

    * check in test_urlparse.py & create an output/test_urlparse that
      reflects how those two problematic URLs ought to be parsed

    * comment out those two failing tests, and generate a 0-error
      output/test_urlparse file

    * do nothing

Those two failing tests are:

    urljoin('http://a/b/c/d;p?q', '?y')
    expected 'http://a/b/c/?y',
         got 'http://a/b/c/d;p?y'

    urljoin('http://a/b/c/d;p?q', ';x')
    expected 'http://a/b/c/;x',
         got 'http://a/b/c/d;x'

Finally, this uses the old test format.  Since so much of the test script
gets touched, should I go ahead and convert to unittest?

Skip